From patchwork Wed Jul 3 08:09:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seung-Woo Kim X-Patchwork-Id: 2815391 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 375E8BF4A1 for ; Wed, 3 Jul 2013 08:10:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0A27F20129 for ; Wed, 3 Jul 2013 08:10:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9E3102011B for ; Wed, 3 Jul 2013 08:10:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B88BE63B7 for ; Wed, 3 Jul 2013 01:10:16 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A815E63B7 for ; Wed, 3 Jul 2013 01:09:15 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MPC00IU9PATXLP0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 03 Jul 2013 17:09:09 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.114]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id D5.28.17404.42CD3D15; Wed, 03 Jul 2013 17:09:08 +0900 (KST) X-AuditID: cbfee68d-b7f096d0000043fc-b3-51d3dc243527 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 41.9A.28381.42CD3D15; Wed, 03 Jul 2013 17:09:08 +0900 (KST) Received: from localhost.localdomain ([10.90.8.56]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MPC007P9PB5BV50@mmp1.samsung.com>; Wed, 03 Jul 2013 17:09:08 +0900 (KST) From: Seung-Woo Kim To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH v2 2/3] drm/exynos: fix pages allocation size in lowlevel_buffer_allocate Date: Wed, 03 Jul 2013 17:09:20 +0900 Message-id: <1372838961-3372-2-git-send-email-sw0312.kim@samsung.com> X-Mailer: git-send-email 1.7.4.1 In-reply-to: <1372838961-3372-1-git-send-email-sw0312.kim@samsung.com> References: <1372838961-3372-1-git-send-email-sw0312.kim@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsWyRsSkSFflzuVAg+NLzC16z51ksrjy9T2b xaT7E1gsXty7yGJxtukNu8WMyS/ZLL7/W8hksXfnZEYHDo/t3x6wesw7Gehxv/s4k0ffllWM ASxRXDYpqTmZZalF+nYJXBlzpi5jK7jHWdG46xh7A+N0ji5GDg4JAROJiYvKuhg5gUwxiQv3 1rN1MXJxCAksZZTY+20+M0zN7H5LiPgiRokJ538zQzjNTBL3pnWxgXSzCehI7F/ymxXEFhGw lHiwFaKIWWA6o0R33zNGkEnCAtESj/aZgtSwCKhKzNi/GqyeV8BVont7KyvEFQoSC+69BZvJ KeAm0bD9HyvEsj5GiZ77UxlBHAmBRewS975sZoaYJCDxbfIhFohTZSU2HWCGGCQpcXDFDZYJ jMILGBlWMYqmFiQXFCelFxnqFSfmFpfmpesl5+duYgSG+el/z3p3MN4+YH2IMRlo3ERmKdHk fGCc5JXEGxqbGVmYmpgaG5lbmpEmrCTOq9ZiHSgkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB MYbpSjhLMWty7w7nbXw/1q3KqdRm57/tI5f652hVY7rC0lrWTU/aVstdFFifVnSDf/KV5ZKc hx+WcV4xyeD7lea668bzjGUvkrsrZmbzxv14+2nS1sL3RnauOusl1r+OTYi3swu2EFrpy31v xj3PE9cVPh7wXFeh2bxzqkfhZLv9q/zWcl9drsRSnJFoqMVcVJwIAIq4yKKJAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jAV2VO5cDDVbd0bPoPXeSyeLK1/ds FpPuT2CxeHHvIovF2aY37BYzJr9ks/j+byGTxd6dkxkdODy2f3vA6jHvZKDH/e7jTB59W1Yx BrBENTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gDd oaRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHMmDN1GVvBPc6Kxl3H2BsY p3N0MXJwSAiYSMzut+xi5AQyxSQu3FvP1sXIxSEksIhRYsL538wQTjOTxL1pXWwgVWwCOhL7 l/xmBbFFBCwlHmyFKGIWmM4o0d33jBFkqrBAtMSjfaYgNSwCqhIz9q8Gq+cVcJXo3t7KCrFN QWLBvbdgMzkF3CQatv9jhVjWxyjRc38q4wRG3gWMDKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLz czcxguPomdQOxpUNFocYBTgYlXh4HZ5dChRiTSwrrsw9xCjBwawkwrtk0eVAId6UxMqq1KL8 +KLSnNTiQ4zJQGdNZJYSTc4HxnheSbyhsYmZkaWRuaGFkbE5acJK4rwHWq0DhQTSE0tSs1NT C1KLYLYwcXBKNTCyHDnL+vLMnsALO3kFH1xf3y4YfW+WgEz9e8ZXhXPmTalvSA+LVez+6GHw 77dC1rFanpxs35meCS81p3gX2fp/9JPduqhZ4EaPfpP4kr3uuwvSHjzaWVLWfHtp1u+Wnquu Ak/+Pf5cv2nxlmVbeg8v9ZylPKdr2x7Gtpt/rvxotI3/vbXzUJqlEktxRqKhFnNRcSIAg07C T+cCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: sw0312.kim@samsung.com, yj44.cho@samsung.com, kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: YoungJun Cho When IOMMU is not supported, buf->pages has to be allocated to assign the result of phys_to_page() which return type is struct page *. So it is sufficient to allocate buf->pages with the size of multiple struct page pointers. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change from v1: - adds precedence patch to fix allocation of array as Ville and Inki commented drivers/gpu/drm/exynos/exynos_drm_buf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c b/drivers/gpu/drm/exynos/exynos_drm_buf.c index 245c9ae..c300b2a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c @@ -57,7 +57,7 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, dma_addr_t start_addr; unsigned int i = 0; - buf->pages = drm_calloc_large(nr_pages, sizeof(struct page)); + buf->pages = drm_calloc_large(nr_pages, sizeof(struct page *)); if (!buf->pages) { DRM_ERROR("failed to allocate pages.\n"); return -ENOMEM;