From patchwork Thu Jul 4 12:25:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Herrmann X-Patchwork-Id: 2823171 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A90FFBF4A1 for ; Thu, 4 Jul 2013 12:33:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A0D9D20172 for ; Thu, 4 Jul 2013 12:33:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 0BB8B20171 for ; Thu, 4 Jul 2013 12:33:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 151EEE66CC for ; Thu, 4 Jul 2013 05:33:41 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id BCBD5E5FE7 for ; Thu, 4 Jul 2013 05:26:35 -0700 (PDT) Received: by mail-ea0-f182.google.com with SMTP id d10so758844eaj.13 for ; Thu, 04 Jul 2013 05:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=mgQoZlcUdqq8YxSA5qjmP6fcqozMtKSVjfgLHjbFmmw=; b=Q1Lma4iAwrmWuCooaApUqkFjmrG/oI7WlmlpQ/fCeZGE7zf2d197ptszSWTfX6HgLi jvztyXtk62ggUGSjsDX60rmEX4SywcHOqg+HPeLPWroUexlPIEn8ZobwE48W81IpoZ4W S8lD48hggbXsfwHZMfXo981SLRmk7hFJjK5Y7RSKyiPqPVCrifFqNiYJtpK5/SQwikDn i6Iv1P8wsMznr27VfCcBD+PlHKgMUYQIvgEzbC5DkeGadF2382jQLGrsspU7YX9dHuX7 58JWCWKHDev4vI2mX2vgU08i3KWhKjBcehcOJkoFwczaf3Zb+Xr4TrBeGvF7FFUBqETQ lijA== X-Received: by 10.14.3.73 with SMTP id 49mr6482131eeg.72.1372940794982; Thu, 04 Jul 2013 05:26:34 -0700 (PDT) Received: from localhost.localdomain (stgt-5f718597.pool.mediaWays.net. [95.113.133.151]) by mx.google.com with ESMTPSA id n5sm4678843eed.9.2013.07.04.05.26.33 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 04 Jul 2013 05:26:34 -0700 (PDT) From: David Herrmann To: linux-kernel@vger.kernel.org Subject: [PATCH v2 08/14] fbdev: fbcon: select VT_HW_CONSOLE_BINDING Date: Thu, 4 Jul 2013 14:25:08 +0200 Message-Id: <1372940714-12470-9-git-send-email-dh.herrmann@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1372940714-12470-1-git-send-email-dh.herrmann@gmail.com> References: <1372940714-12470-1-git-send-email-dh.herrmann@gmail.com> Cc: Tomi Valkeinen , Jean-Christophe Plagniol-Villard , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP fbdev provides framebuffer hotplugging, hence, we need to allow fbcon to unbind from framebuffers. Unfortunately, fbcon_fb_unbind() cannot unbind from the last framebuffer, unless console-unbinding is supported. Fixing fbcon_unbind() to return 0 caused some horrible NULL-derefs in the VT layer and I couldn't figure out why. Hence, lets just require console-unbinding so fbdev hotplugging works with fbcon. Signed-off-by: David Herrmann --- drivers/video/console/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index bc922c4..538d700 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig @@ -89,7 +89,8 @@ config DUMMY_CONSOLE_ROWS config FRAMEBUFFER_CONSOLE tristate "Framebuffer Console support" - depends on FB + depends on FB && !UML + select VT_HW_CONSOLE_BINDING select CRC32 help Low-level framebuffer-based console driver.