| Message ID | 1375900754-3574-2-git-send-email-damien.lespiau@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 07, 2013 at 07:39:13PM +0100, Damien Lespiau wrote: > A few styles issues have creept in here, fix them before touching this > code again. You could also sprinke a bit of constness into these functions while you're touching them. > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > --- > drivers/gpu/drm/drm_edid.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 95d6f4b..51342c4 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2442,10 +2442,10 @@ add_alternate_cea_modes(struct drm_connector *connector, struct edid *edid) > } > > static int > -do_cea_modes (struct drm_connector *connector, u8 *db, u8 len) > +do_cea_modes(struct drm_connector *connector, u8 *db, u8 len) > { > struct drm_device *dev = connector->dev; > - u8 * mode, cea_mode; > + u8 *mode, cea_mode; > int modes = 0; > > for (mode = db; mode < db + len; mode++) { > @@ -2502,8 +2502,8 @@ cea_db_offsets(const u8 *cea, int *start, int *end) > static int > add_cea_modes(struct drm_connector *connector, struct edid *edid) > { > - u8 * cea = drm_find_cea_extension(edid); > - u8 * db, dbl; > + u8 *cea = drm_find_cea_extension(edid); > + u8 *db, dbl; > int modes = 0; > > if (cea && cea_revision(cea) >= 3) { > @@ -2517,7 +2517,7 @@ add_cea_modes(struct drm_connector *connector, struct edid *edid) > dbl = cea_db_payload_len(db); > > if (cea_db_tag(db) == VIDEO_BLOCK) > - modes += do_cea_modes (connector, db+1, dbl); > + modes += do_cea_modes(connector, db + 1, dbl); > } > } > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 95d6f4b..51342c4 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -2442,10 +2442,10 @@ add_alternate_cea_modes(struct drm_connector *connector, struct edid *edid) } static int -do_cea_modes (struct drm_connector *connector, u8 *db, u8 len) +do_cea_modes(struct drm_connector *connector, u8 *db, u8 len) { struct drm_device *dev = connector->dev; - u8 * mode, cea_mode; + u8 *mode, cea_mode; int modes = 0; for (mode = db; mode < db + len; mode++) { @@ -2502,8 +2502,8 @@ cea_db_offsets(const u8 *cea, int *start, int *end) static int add_cea_modes(struct drm_connector *connector, struct edid *edid) { - u8 * cea = drm_find_cea_extension(edid); - u8 * db, dbl; + u8 *cea = drm_find_cea_extension(edid); + u8 *db, dbl; int modes = 0; if (cea && cea_revision(cea) >= 3) { @@ -2517,7 +2517,7 @@ add_cea_modes(struct drm_connector *connector, struct edid *edid) dbl = cea_db_payload_len(db); if (cea_db_tag(db) == VIDEO_BLOCK) - modes += do_cea_modes (connector, db+1, dbl); + modes += do_cea_modes(connector, db + 1, dbl); } }
A few styles issues have creept in here, fix them before touching this code again. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- drivers/gpu/drm/drm_edid.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)