From patchwork Thu Aug 8 13:41:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 2841239 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 22DB39F294 for ; Thu, 8 Aug 2013 14:21:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 31926204E2 for ; Thu, 8 Aug 2013 14:21:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id E8619204D7 for ; Thu, 8 Aug 2013 14:21:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B3A9E64B5 for ; Thu, 8 Aug 2013 07:21:27 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 94A9EE6837 for ; Thu, 8 Aug 2013 06:42:06 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id d41so1506879eek.36 for ; Thu, 08 Aug 2013 06:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cxh0W7OU+RNPoyW8hqcwsx6K/95Xwvnu3rqHg+ZWcJ0=; b=QBQTInumMUR+IWxp16nZ6Fjxoc5TMCEqDp7fca8VF4un+hf2Eiauh10N7hgyVSxM9C UJTtZBrE5K3jYCZDyWegEoj9Ee9IfT1TK263FOr6dDC51BA38wcnqpqY38kwgNWOWQXo a40H/Uv9xK/zXMtYXONaF9Trea32K5g9BoeOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cxh0W7OU+RNPoyW8hqcwsx6K/95Xwvnu3rqHg+ZWcJ0=; b=KQQa5qGgADrujrIEtabl2097TpiQ/B9EBeOwaJ4q4Wf2ABhseH8GW0vkOFaZC8gymi KSMXSZJ1/Scj3cUFtRDSIDYz1xsiE6oYirrhm6Jy09QSbc8e1jNyaAmIuRlC+dIV6Bne n1d0sT7hkU0/65AFdyX4MdsZ/niN81Oqekzvv8vN75jbDD66Sczh0I4SNSgf7GM0F7b9 WRzDmZb5y9LGpTHpe5TLUUvrPv0aSjR5cF2xgZ1Ii+CMwh+KzwScK4HHiDfBSPETZBt8 ihuJIzPTe9x6mAft0bPAcnrrf9hv2tcKG3BQcBAUsuxpcaNsSWLjlKZpyxOYZqoT9/Ft zKNg== X-Gm-Message-State: ALoCoQlBKpbhhAgGnUfo8QwABIOdBVw8EI/McXh/X8boOUAzZdTZiiV/AuyiqPy4DC7po/iK4GY3 X-Received: by 10.14.204.194 with SMTP id h42mr8394657eeo.47.1375969325861; Thu, 08 Aug 2013 06:42:05 -0700 (PDT) Received: from phenom.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPSA id bn13sm19282226eeb.11.2013.08.08.06.42.04 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 08 Aug 2013 06:42:05 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 20/25] drm/memory: don't export agp helpers Date: Thu, 8 Aug 2013 15:41:30 +0200 Message-Id: <1375969295-18929-21-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1375969295-18929-1-git-send-email-daniel.vetter@ffwll.ch> References: <1375969295-18929-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP They're only used by the agpgart support code in drm_agpgart.c, not by any drivers. I think long-term we should create a drm_internal.h include file with all the various functions only used by the drm core and not exported to drivers, and remove them from drmP.h. Oh, and someone should kill that upper-case P sometimes ;-) But that's all stuff for future patch bombs. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_memory.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 126d50e..64e44fa 100644 --- a/drivers/gpu/drm/drm_memory.c +++ b/drivers/gpu/drm/drm_memory.c @@ -86,7 +86,6 @@ void drm_free_agp(DRM_AGP_MEM * handle, int pages) { agp_free_memory(handle); } -EXPORT_SYMBOL(drm_free_agp); /** Wrapper around agp_bind_memory() */ int drm_bind_agp(DRM_AGP_MEM * handle, unsigned int start) @@ -99,7 +98,6 @@ int drm_unbind_agp(DRM_AGP_MEM * handle) { return agp_unbind_memory(handle); } -EXPORT_SYMBOL(drm_unbind_agp); #else /* __OS_HAS_AGP */ static inline void *agp_remap(unsigned long offset, unsigned long size,