| Message ID | 1375969295-18929-7-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Aug 8, 2013 at 9:41 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Totally unused, so just rip it out. Anyway, we want drivers to be > fully backwards compatible, allowing them to change behaviour is just > a recipe for them to break badly. > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Rob Clark <robdclark@gmail.com> > --- > drivers/gpu/drm/drm_ioctl.c | 3 --- > include/drm/drmP.h | 2 -- > 2 files changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c > index ffd7a7b..0acf080 100644 > --- a/drivers/gpu/drm/drm_ioctl.c > +++ b/drivers/gpu/drm/drm_ioctl.c > @@ -352,9 +352,6 @@ int drm_setversion(struct drm_device *dev, void *data, struct drm_file *file_pri > retcode = -EINVAL; > goto done; > } > - > - if (dev->driver->set_version) > - dev->driver->set_version(dev, sv); > } > > done: > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index fba5473..7495fb2 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -885,8 +885,6 @@ struct drm_driver { > void (*irq_preinstall) (struct drm_device *dev); > int (*irq_postinstall) (struct drm_device *dev); > void (*irq_uninstall) (struct drm_device *dev); > - void (*set_version) (struct drm_device *dev, > - struct drm_set_version *sv); > > /* Master routines */ > int (*master_create)(struct drm_device *dev, struct drm_master *master); > -- > 1.8.3.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index ffd7a7b..0acf080 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -352,9 +352,6 @@ int drm_setversion(struct drm_device *dev, void *data, struct drm_file *file_pri retcode = -EINVAL; goto done; } - - if (dev->driver->set_version) - dev->driver->set_version(dev, sv); } done: diff --git a/include/drm/drmP.h b/include/drm/drmP.h index fba5473..7495fb2 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -885,8 +885,6 @@ struct drm_driver { void (*irq_preinstall) (struct drm_device *dev); int (*irq_postinstall) (struct drm_device *dev); void (*irq_uninstall) (struct drm_device *dev); - void (*set_version) (struct drm_device *dev, - struct drm_set_version *sv); /* Master routines */ int (*master_create)(struct drm_device *dev, struct drm_master *master);
Totally unused, so just rip it out. Anyway, we want drivers to be fully backwards compatible, allowing them to change behaviour is just a recipe for them to break badly. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/drm_ioctl.c | 3 --- include/drm/drmP.h | 2 -- 2 files changed, 5 deletions(-)