From patchwork Thu Aug 8 13:41:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 2841157 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 97B7B9F295 for ; Thu, 8 Aug 2013 13:55:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7704B204B5 for ; Thu, 8 Aug 2013 13:55:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4BE84204B2 for ; Thu, 8 Aug 2013 13:55:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21346E71ED for ; Thu, 8 Aug 2013 06:55:37 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 5189AE67F8 for ; Thu, 8 Aug 2013 06:41:42 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id b47so1516839eek.17 for ; Thu, 08 Aug 2013 06:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=61djAzjjaeS0znkhp3NDSihOPN4NZR1N37Rbl29JpeM=; b=XNJkA2h/cCr4uca78ySwvc+Xmnb2K+rwOgizYJnEr8qSJ9BA3R0Lx9BqC8FH5VUMZK Ixb7oIBnCZkuEvMCCKN3MAAjaKAlHh6FE2hNftWI0x3h+gAtIY45w/e9ieAMVQ6u+O7C NP46Q3SfDlMRz8bu7aQ9vkQt0w0aSl7m4HJfk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=61djAzjjaeS0znkhp3NDSihOPN4NZR1N37Rbl29JpeM=; b=J6yuIPwGsQIZsV8gD3Y2RoDbeF5UzjlfkHODCOjO3a3aJLrFdPaumaVf2qidyv0F8D /DW55q+k+l9HyHSuS22Z8wW6Hqqhivvkq1oPWkvbN8GPSlIvnrvXbry3WlEg/T9IA6ki BJCVeDlPwRSito/ctymx/Y5ZjeR1bUGlZHon0YxaEs9V83dU4pKfkeA8u2YeM0ViVSKY rC6F45WHDjDPEZVn5kfbZ4jDnGICSFw7GACetVgOA2jRdfya00sfNBirqmAtxj7yIJj7 3FG14XEw8sCpnkZEIMiyXn226DfpbZvu/uKY0XN6PO4EYtva7duAAizlTL2a9ER5dYZg zn/A== X-Gm-Message-State: ALoCoQkLYIaNbB7QgCbUc0kvHmxgWULltHHeroYlBBcVqOVMtUSVf0l1hUX3EtSzK1JuJj+pOotS X-Received: by 10.14.1.5 with SMTP id 5mr8186994eec.96.1375969301547; Thu, 08 Aug 2013 06:41:41 -0700 (PDT) Received: from phenom.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPSA id bn13sm19282226eeb.11.2013.08.08.06.41.40 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 08 Aug 2013 06:41:40 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 06/25] drm: kill dev->driver->set_version Date: Thu, 8 Aug 2013 15:41:16 +0200 Message-Id: <1375969295-18929-7-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1375969295-18929-1-git-send-email-daniel.vetter@ffwll.ch> References: <1375969295-18929-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Totally unused, so just rip it out. Anyway, we want drivers to be fully backwards compatible, allowing them to change behaviour is just a recipe for them to break badly. Signed-off-by: Daniel Vetter Reviewed-by: Rob Clark --- drivers/gpu/drm/drm_ioctl.c | 3 --- include/drm/drmP.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index ffd7a7b..0acf080 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -352,9 +352,6 @@ int drm_setversion(struct drm_device *dev, void *data, struct drm_file *file_pri retcode = -EINVAL; goto done; } - - if (dev->driver->set_version) - dev->driver->set_version(dev, sv); } done: diff --git a/include/drm/drmP.h b/include/drm/drmP.h index fba5473..7495fb2 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -885,8 +885,6 @@ struct drm_driver { void (*irq_preinstall) (struct drm_device *dev); int (*irq_postinstall) (struct drm_device *dev); void (*irq_uninstall) (struct drm_device *dev); - void (*set_version) (struct drm_device *dev, - struct drm_set_version *sv); /* Master routines */ int (*master_create)(struct drm_device *dev, struct drm_master *master);