diff mbox

[6/6] drm/exynos: Make Exynos DRM drivers depend on OF

Message ID 1377150323-12546-6-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Aug. 22, 2013, 5:45 a.m. UTC
Exynos is a DT-only platform. Add this info to Kconfig.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/exynos/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tomasz Figa Aug. 22, 2013, 8:27 a.m. UTC | #1
Hi Sachin,

On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote:
> Exynos is a DT-only platform. Add this info to Kconfig.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/gpu/drm/exynos/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/Kconfig
> b/drivers/gpu/drm/exynos/Kconfig index 772c62a..80a251a 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -1,6 +1,6 @@
>  config DRM_EXYNOS
>  	tristate "DRM Support for Samsung SoC EXYNOS Series"
> -	depends on DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM)
> +	depends on OF && DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM)
>  	select DRM_KMS_HELPER
>  	select FB_CFB_FILLRECT
>  	select FB_CFB_COPYAREA
> @@ -24,7 +24,7 @@ config DRM_EXYNOS_DMABUF
> 
>  config DRM_EXYNOS_FIMD
>  	bool "Exynos DRM FIMD"
> -	depends on OF && DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
> +	depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
>  	select FB_MODE_HELPERS
>  	select VIDEOMODE_HELPERS
>  	help

Shouldn't this patch be first in the series?

Best regards,
Tomasz
Sachin Kamat Aug. 22, 2013, 8:31 a.m. UTC | #2
Hi Tomasz,

On 22 August 2013 13:57, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Sachin,
>
> On Thursday 22 of August 2013 11:15:23 Sachin Kamat wrote:
>> Exynos is a DT-only platform. Add this info to Kconfig.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  drivers/gpu/drm/exynos/Kconfig |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/Kconfig
>> b/drivers/gpu/drm/exynos/Kconfig index 772c62a..80a251a 100644
>> --- a/drivers/gpu/drm/exynos/Kconfig
>> +++ b/drivers/gpu/drm/exynos/Kconfig
>> @@ -1,6 +1,6 @@
>>  config DRM_EXYNOS
>>       tristate "DRM Support for Samsung SoC EXYNOS Series"
>> -     depends on DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM)
>> +     depends on OF && DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM)
>>       select DRM_KMS_HELPER
>>       select FB_CFB_FILLRECT
>>       select FB_CFB_COPYAREA
>> @@ -24,7 +24,7 @@ config DRM_EXYNOS_DMABUF
>>
>>  config DRM_EXYNOS_FIMD
>>       bool "Exynos DRM FIMD"
>> -     depends on OF && DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
>> +     depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
>>       select FB_MODE_HELPERS
>>       select VIDEOMODE_HELPERS
>>       help
>
> Shouldn't this patch be first in the series?

I do not recollect my reasoning for having this at the last :)
Thanks for pointing out.
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 772c62a..80a251a 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -1,6 +1,6 @@ 
 config DRM_EXYNOS
 	tristate "DRM Support for Samsung SoC EXYNOS Series"
-	depends on DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM)
+	depends on OF && DRM && (PLAT_SAMSUNG || ARCH_MULTIPLATFORM)
 	select DRM_KMS_HELPER
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
@@ -24,7 +24,7 @@  config DRM_EXYNOS_DMABUF
 
 config DRM_EXYNOS_FIMD
 	bool "Exynos DRM FIMD"
-	depends on OF && DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
+	depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
 	select FB_MODE_HELPERS
 	select VIDEOMODE_HELPERS
 	help