From patchwork Thu Sep 12 15:57:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 2879051 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 35769BFF05 for ; Thu, 12 Sep 2013 16:03:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E27F92035C for ; Thu, 12 Sep 2013 16:03:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id CBA042034F for ; Thu, 12 Sep 2013 16:03:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C7D08E775A for ; Thu, 12 Sep 2013 09:03:55 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F005E75C3 for ; Thu, 12 Sep 2013 08:57:22 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id d49so5386784eek.6 for ; Thu, 12 Sep 2013 08:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QE2iE67KPjhf4zyHkaqkzW0GyCexryAybKnKtw7ajp8=; b=E6Rp04AYIZ9UQsXe4VxxPfsZzrXOkcKYFHosM9WNR74EQMBI/m9piklFf3xEuBcR1m ToCQwr1Io5EyfapSLIEDCopNDeOKK01X+jI06P85Y3delABxKrPLguVmjwMmwGwnqa9i PUHXS+l6Cw+WkcxKypYuJ9I0Vu/UnjQFGeXfQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QE2iE67KPjhf4zyHkaqkzW0GyCexryAybKnKtw7ajp8=; b=c+U0vqmUvDVcJ7AYUnQBHyAQ5rPPK+Ml32tcWd/6gdCoRe3zzom93zDwesSe9r1M+t fCAFky/QZdpoaEQh3z2EJ/wWQh+DJr0jKZUMCvRptFSIS/xENM6XURTGLRvtHP6guswn uYMGHHZfWhWIEK//CtYWQgVZp0HFRKs59mZ6ThgGtFow+hc6LZuRAqN/n/ZAG6zeIcqT dgKehqVSBgYLxIukwyPRIwR/ejnnoIteXCiunyYBJt9Va9woILZOHH7ETJF6SKrJndHn iGf1BG1HUjk70gvHxqdt/aS0v7MJ5+r3IqE6GoXqgPuPgaNMRPdmEtfMUWjw92N8tIz2 keqw== X-Gm-Message-State: ALoCoQmt3q0cIEk38TKVPoO4FN5d/uE9sPApgmmAPK7/HkTP3o/J0uikkovAXdGVvZidUPgjyHsK X-Received: by 10.15.76.73 with SMTP id m49mr1820870eey.91.1379001441414; Thu, 12 Sep 2013 08:57:21 -0700 (PDT) Received: from phenom.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPSA id y47sm6914948eew.12.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Sep 2013 08:57:20 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/2] drm/udl: rip out set_need_resched Date: Thu, 12 Sep 2013 17:57:29 +0200 Message-Id: <1379001449-17380-2-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.8.4.rc3 In-Reply-To: <1379001449-17380-1-git-send-email-daniel.vetter@ffwll.ch> References: <1379001449-17380-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Peter Zijlstra , Daniel Vetter , Intel Graphics Development , LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This very much looks like copypasta from drm/i915's fault handler. It was used there to duct-tape over issues around gpu reset handling. Since that can't ever happen for udl and there's seemingly no other reason for this just drop it. Reported-by: Peter Zijlstra Cc: Peter Zijlstra Cc: Linux Kernel Mailing List Cc: Dave Airlie Signed-off-by: Daniel Vetter Acked-by: Peter Zijlstra --- drivers/gpu/drm/udl/udl_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c index 8dbe9d0..8bf6461 100644 --- a/drivers/gpu/drm/udl/udl_gem.c +++ b/drivers/gpu/drm/udl/udl_gem.c @@ -97,7 +97,6 @@ int udl_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf) ret = vm_insert_page(vma, (unsigned long)vmf->virtual_address, page); switch (ret) { case -EAGAIN: - set_need_resched(); case 0: case -ERESTARTSYS: return VM_FAULT_NOPAGE;