From patchwork Wed Sep 25 11:51:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 2946711 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 37C46BFF05 for ; Thu, 26 Sep 2013 07:13:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 20E7F20328 for ; Thu, 26 Sep 2013 07:13:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id E6685202AE for ; Thu, 26 Sep 2013 07:13:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2426E6CC7 for ; Thu, 26 Sep 2013 00:13:29 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTP id 366ADE6605 for ; Wed, 25 Sep 2013 04:51:57 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTO00HX4JLD4V30@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 25 Sep 2013 12:51:54 +0100 (BST) X-AuditID: cbfec7f4-b7f0a6d000007b1b-47-5242ce5ab40d Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id E4.42.31515.A5EC2425; Wed, 25 Sep 2013 12:51:54 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MTO006WIJM4SD10@eusync3.samsung.com>; Wed, 25 Sep 2013 12:51:54 +0100 (BST) From: Andrzej Hajda To: linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER) Subject: [PATCH 1/2] video: of: display_timing: correct display-timings node finding Date: Wed, 25 Sep 2013 13:51:31 +0200 Message-id: <1380109892-13040-2-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.8.1.2 In-reply-to: <1380109892-13040-1-git-send-email-a.hajda@samsung.com> References: <1380109892-13040-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAJMWRmVeSWpSXmKPExsVy+t/xq7pR55yCDH7M5rO4te4cq8WVr+/Z LM42vWG3ONH3gdVi3cMXTBbr599ic2DzeHXhDovH/e7jTB59W1Yxehy/sZ3J4/MmuQDWKC6b lNSczLLUIn27BK6MKVua2AvWc1csefORsYHxJGcXIyeHhICJxIW505khbDGJC/fWs3UxcnEI CSxllLjz/QkLSEJIoI9J4sFRfhCbTUBT4u/mm2wgtoiArcSxx63sIA3MArcZJWatPMgKkhAW CJNovLyFCcRmEVCVmPn8MdggXgFniUMnbrBAbFOQ+Hn5BNAgDg5OAReJy2ecIHY5Sxw/sIxx AiPvAkaGVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxghofRlB+PiY1aHGAU4GJV4eAWOOgYJ sSaWFVfmHmKU4GBWEuENX+wUJMSbklhZlVqUH19UmpNafIiRiYNTqoGRN1o7wPlIufUxv8Ws s3h/vZ2/vsFsQWXhKimj95N5dq7/8fNMWE+fY7J/ZpqO2f6w1ekvJt2fucO2PbTN5d+XM38X re6wUG1969W49NMRk8mXCg7Ibj8U/XPrXYc33/azir2afoyrTcyMeael4cJJN0Vilb3v6Kn0 Hq6vWuZxjVdVwubz0iJuJZbijERDLeai4kQA2Fz9/AMCAAA= X-Mailman-Approved-At: Thu, 26 Sep 2013 00:13:07 -0700 Cc: Andrzej Hajda , Kyungmin Park , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP of_get_display_timing(s) use of_find_node_by_name to get child node, this is incorrect, of_get_child_by_name should be used instead. The patch fixes it. Small typo is also corrected. Signed-off-by: Andrzej Hajda Signed-off-by: Kyungmin Park --- drivers/video/of_display_timing.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index 171821d..ba5b40f 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -120,7 +120,7 @@ int of_get_display_timing(struct device_node *np, const char *name, return -EINVAL; } - timing_np = of_find_node_by_name(np, name); + timing_np = of_get_child_by_name(np, name); if (!timing_np) { pr_err("%s: could not find node '%s'\n", of_node_full_name(np), name); @@ -143,11 +143,11 @@ struct display_timings *of_get_display_timings(struct device_node *np) struct display_timings *disp; if (!np) { - pr_err("%s: no devicenode given\n", of_node_full_name(np)); + pr_err("%s: no device node given\n", of_node_full_name(np)); return NULL; } - timings_np = of_find_node_by_name(np, "display-timings"); + timings_np = of_get_child_by_name(np, "display-timings"); if (!timings_np) { pr_err("%s: could not find display-timings node\n", of_node_full_name(np));