| Message ID | 1380725919-1961-2-git-send-email-dh.herrmann@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Tomi Ping? Thanks David On Wed, Oct 2, 2013 at 4:58 PM, David Herrmann <dh.herrmann@gmail.com> wrote: > Framebuffers shouldn't be cached and it is usually very uncommon to read > them. Therefore, use ioremap_wc() to get significant speed improvements on > systems which provide it. On all other systems it's aliased to > ioremap_nocache() which is also fine. > > Reported-by: Tom Gundersen <teg@jklm.no> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > Tested-by: Tom Gundersen <teg@jklm.no> > Tested-by: Alexandre Courbot <acourbot@nvidia.com> > Tested-by: Stephen Warren <swarren@wwwdotorg.org> > --- > drivers/video/simplefb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c > index 74b016c..64db54a 100644 > --- a/drivers/video/simplefb.c > +++ b/drivers/video/simplefb.c > @@ -219,8 +219,8 @@ static int simplefb_probe(struct platform_device *pdev) > > info->fbops = &simplefb_ops; > info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE; > - info->screen_base = ioremap(info->fix.smem_start, > - info->fix.smem_len); > + info->screen_base = ioremap_wc(info->fix.smem_start, > + info->fix.smem_len); > if (!info->screen_base) { > framebuffer_release(info); > return -ENODEV; > -- > 1.8.4 >
On 2013-10-30 09:49, David Herrmann wrote: > Hi Tomi > > Ping? Thanks, queued this and the 1/2 patch for 3.13. Tomi > > Thanks > David > > On Wed, Oct 2, 2013 at 4:58 PM, David Herrmann <dh.herrmann@gmail.com> wrote: >> Framebuffers shouldn't be cached and it is usually very uncommon to read >> them. Therefore, use ioremap_wc() to get significant speed improvements on >> systems which provide it. On all other systems it's aliased to >> ioremap_nocache() which is also fine. >> >> Reported-by: Tom Gundersen <teg@jklm.no> >> Signed-off-by: David Herrmann <dh.herrmann@gmail.com> >> Tested-by: Tom Gundersen <teg@jklm.no> >> Tested-by: Alexandre Courbot <acourbot@nvidia.com> >> Tested-by: Stephen Warren <swarren@wwwdotorg.org> >> --- >> drivers/video/simplefb.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c >> index 74b016c..64db54a 100644 >> --- a/drivers/video/simplefb.c >> +++ b/drivers/video/simplefb.c >> @@ -219,8 +219,8 @@ static int simplefb_probe(struct platform_device *pdev) >> >> info->fbops = &simplefb_ops; >> info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE; >> - info->screen_base = ioremap(info->fix.smem_start, >> - info->fix.smem_len); >> + info->screen_base = ioremap_wc(info->fix.smem_start, >> + info->fix.smem_len); >> if (!info->screen_base) { >> framebuffer_release(info); >> return -ENODEV; >> -- >> 1.8.4 >>
diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c index 74b016c..64db54a 100644 --- a/drivers/video/simplefb.c +++ b/drivers/video/simplefb.c @@ -219,8 +219,8 @@ static int simplefb_probe(struct platform_device *pdev) info->fbops = &simplefb_ops; info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE; - info->screen_base = ioremap(info->fix.smem_start, - info->fix.smem_len); + info->screen_base = ioremap_wc(info->fix.smem_start, + info->fix.smem_len); if (!info->screen_base) { framebuffer_release(info); return -ENODEV;