diff mbox

drm/omap: call drm_put_dev directly in ->remove

Message ID 1386768034-27472-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Dec. 11, 2013, 1:20 p.m. UTC 
Again omap already sets the driver data pointer to the drm_device.

v2: Don't rip out the platform_driver_unregister call for omap_dmm_driver.
Pesky difference between drm and dmm ...

Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Clark Dec. 11, 2013, 7:35 p.m. UTC | #1 
On Wed, Dec 11, 2013 at 8:20 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Again omap already sets the driver data pointer to the drm_device.
>
> v2: Don't rip out the platform_driver_unregister call for omap_dmm_driver.
> Pesky difference between drm and dmm ...
>
> Cc: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

looks better, thanks

Reviewed-by: Rob Clark <robdclark@gmail.com>


> ---
>  drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index e7fa3cd96743..7be34b7d06f2 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -665,7 +665,7 @@ static int pdev_probe(struct platform_device *device)
>  static int pdev_remove(struct platform_device *device)
>  {
>         DBG("");
> -       drm_platform_exit(&omap_drm_driver, device);
> +       drm_put_dev(platform_get_drvdata(device));
>
>         platform_driver_unregister(&omap_dmm_driver);
>         return 0;
> --
> 1.8.4.3
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index e7fa3cd96743..7be34b7d06f2 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -665,7 +665,7 @@  static int pdev_probe(struct platform_device *device)
 static int pdev_remove(struct platform_device *device)
 {
 	DBG("");
-	drm_platform_exit(&omap_drm_driver, device);
+	drm_put_dev(platform_get_drvdata(device));
 
 	platform_driver_unregister(&omap_dmm_driver);
 	return 0;