| Message ID | 1391002774-582-1-git-send-email-dh.herrmann@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 29, 2014 at 2:39 PM, David Herrmann <dh.herrmann@gmail.com> wrote: > These are unused and can safely be dropped. DRM core verifies they're > non-NULL before it calls them. > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > --- > drivers/gpu/drm/gma500/psb_drv.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c > index 1199180..d224503 100644 > --- a/drivers/gpu/drm/gma500/psb_drv.c > +++ b/drivers/gpu/drm/gma500/psb_drv.c > @@ -588,15 +588,6 @@ static int psb_stolen_memory_ioctl(struct drm_device *dev, void *data, > return 0; > } > > -static int psb_driver_open(struct drm_device *dev, struct drm_file *priv) > -{ > - return 0; > -} > - > -static void psb_driver_close(struct drm_device *dev, struct drm_file *priv) > -{ > -} > - > static long psb_unlocked_ioctl(struct file *filp, unsigned int cmd, > unsigned long arg) > { > @@ -672,9 +663,7 @@ static struct drm_driver driver = { > .disable_vblank = psb_disable_vblank, > .get_vblank_counter = psb_get_vblank_counter, > .lastclose = psb_lastclose, > - .open = psb_driver_open, > .preclose = psb_driver_preclose, > - .postclose = psb_driver_close, > > .gem_free_object = psb_gem_free_object, > .gem_vm_ops = &psb_gem_vm_ops, > -- > 1.8.5.3 > Thanks, I'll put it in gma500-next Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index 1199180..d224503 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -588,15 +588,6 @@ static int psb_stolen_memory_ioctl(struct drm_device *dev, void *data, return 0; } -static int psb_driver_open(struct drm_device *dev, struct drm_file *priv) -{ - return 0; -} - -static void psb_driver_close(struct drm_device *dev, struct drm_file *priv) -{ -} - static long psb_unlocked_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { @@ -672,9 +663,7 @@ static struct drm_driver driver = { .disable_vblank = psb_disable_vblank, .get_vblank_counter = psb_get_vblank_counter, .lastclose = psb_lastclose, - .open = psb_driver_open, .preclose = psb_driver_preclose, - .postclose = psb_driver_close, .gem_free_object = psb_gem_free_object, .gem_vm_ops = &psb_gem_vm_ops,
These are unused and can safely be dropped. DRM core verifies they're non-NULL before it calls them. Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Signed-off-by: David Herrmann <dh.herrmann@gmail.com> --- drivers/gpu/drm/gma500/psb_drv.c | 11 ----------- 1 file changed, 11 deletions(-)