diff mbox

[v4,04/11] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property()

Message ID 1391780716-21896-5-git-send-email-sagar.a.kamble@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

sagar.a.kamble@intel.com Feb. 7, 2014, 1:45 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Use the new drm_mode_create_rotation_property() in omapdrm.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/omapdrm/omap_plane.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

Comments

Rob Clark Feb. 9, 2014, 1:34 p.m. UTC | #1
On Fri, Feb 7, 2014 at 8:45 AM,  <sagar.a.kamble@intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use the new drm_mode_create_rotation_property() in omapdrm.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_plane.c | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c
> index 046d5e6..fee8f35 100644
> --- a/drivers/gpu/drm/omapdrm/omap_plane.c
> +++ b/drivers/gpu/drm/omapdrm/omap_plane.c
> @@ -300,16 +300,13 @@ void omap_plane_install_properties(struct drm_plane *plane,
>         if (priv->has_dmm) {
>                 prop = priv->rotation_prop;
>                 if (!prop) {
> -                       const struct drm_prop_enum_list props[] = {
> -                                       { DRM_ROTATE_0,   "rotate-0" },
> -                                       { DRM_ROTATE_90,  "rotate-90" },
> -                                       { DRM_ROTATE_180, "rotate-180" },
> -                                       { DRM_ROTATE_270, "rotate-270" },
> -                                       { DRM_REFLECT_X,  "reflect-x" },
> -                                       { DRM_REFLECT_Y,  "reflect-y" },
> -                       };
> -                       prop = drm_property_create_bitmask(dev, 0, "rotation",
> -                                       props, ARRAY_SIZE(props));
> +                       prop = drm_mode_create_rotation_property(dev,
> +                                                                BIT(DRM_ROTATE_0) |
> +                                                                BIT(DRM_ROTATE_90) |
> +                                                                BIT(DRM_ROTATE_180) |
> +                                                                BIT(DRM_ROTATE_270) |
> +                                                                BIT(DRM_REFLECT_X) |
> +                                                                BIT(DRM_REFLECT_Y));
>                         if (prop == NULL)
>                                 return;
>                         priv->rotation_prop = prop;
> --
> 1.8.5
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c
index 046d5e6..fee8f35 100644
--- a/drivers/gpu/drm/omapdrm/omap_plane.c
+++ b/drivers/gpu/drm/omapdrm/omap_plane.c
@@ -300,16 +300,13 @@  void omap_plane_install_properties(struct drm_plane *plane,
 	if (priv->has_dmm) {
 		prop = priv->rotation_prop;
 		if (!prop) {
-			const struct drm_prop_enum_list props[] = {
-					{ DRM_ROTATE_0,   "rotate-0" },
-					{ DRM_ROTATE_90,  "rotate-90" },
-					{ DRM_ROTATE_180, "rotate-180" },
-					{ DRM_ROTATE_270, "rotate-270" },
-					{ DRM_REFLECT_X,  "reflect-x" },
-					{ DRM_REFLECT_Y,  "reflect-y" },
-			};
-			prop = drm_property_create_bitmask(dev, 0, "rotation",
-					props, ARRAY_SIZE(props));
+			prop = drm_mode_create_rotation_property(dev,
+								 BIT(DRM_ROTATE_0) |
+								 BIT(DRM_ROTATE_90) |
+								 BIT(DRM_ROTATE_180) |
+								 BIT(DRM_ROTATE_270) |
+								 BIT(DRM_REFLECT_X) |
+								 BIT(DRM_REFLECT_Y));
 			if (prop == NULL)
 				return;
 			priv->rotation_prop = prop;