| Message ID | 1392011821-2406-1-git-send-email-acourbot@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 10, 2014 at 02:57:01PM +0900, Alexandre Courbot wrote: > Memory was always allocated for 4096 channels. Change this to allocate > what we actually need according to the number of channels we use. > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> > --- > drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good to me: Reviewed-by: Thierry Reding <treding@nvidia.com>
On Mon, Feb 10, 2014 at 10:14 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > On Mon, Feb 10, 2014 at 02:57:01PM +0900, Alexandre Courbot wrote: >> Memory was always allocated for 4096 channels. Change this to allocate >> what we actually need according to the number of channels we use. >> >> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> >> --- >> drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Looks good to me: > > Reviewed-by: Thierry Reding <treding@nvidia.com> Thanks guys! > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/nouveau >
diff --git a/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c b/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c index 9a850fe19515..99c9deea248f 100644 --- a/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c +++ b/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c @@ -852,8 +852,8 @@ nve0_fifo_ctor(struct nouveau_object *parent, struct nouveau_object *engine, return ret; } - ret = nouveau_gpuobj_new(nv_object(priv), NULL, 4096 * 0x200, 0x1000, - NVOBJ_FLAG_ZERO_ALLOC, &priv->user.mem); + ret = nouveau_gpuobj_new(nv_object(priv), NULL, impl->channels * 0x200, + 0x1000, NVOBJ_FLAG_ZERO_ALLOC, &priv->user.mem); if (ret) return ret;
Memory was always allocated for 4096 channels. Change this to allocate what we actually need according to the number of channels we use. Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> --- drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)