From patchwork Fri Feb 21 07:55:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 3694941 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 88F13BF13A for ; Fri, 21 Feb 2014 07:56:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CEB7620142 for ; Fri, 21 Feb 2014 07:56:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 1E32F20145 for ; Fri, 21 Feb 2014 07:56:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52572FB426; Thu, 20 Feb 2014 23:55:53 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-bk0-f50.google.com (mail-bk0-f50.google.com [209.85.214.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B3D9FB426 for ; Thu, 20 Feb 2014 23:55:47 -0800 (PST) Received: by mail-bk0-f50.google.com with SMTP id d7so919146bkh.23 for ; Thu, 20 Feb 2014 23:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VytErQn7vYNBM4ctyrwhgACkNLfnQdvDket5gBQ7wlg=; b=z6f37yCyzj+HbL3VTLGOzo8EAfiUBOLs2+jAfJX7a9zyd6in6d24ScxdK0HjGUzEJu ORdU5q98ZqoPgyjZjUpT0AzdfCHz/mYY7SNAHoJ5Mz+KXkIZScEnG+EZE0ZzsWg0Q8IB EYioyALzX31GrYfAEhlESkjLThUkdjlmyK7riM9CTmL1pVI6EO0MbKUeQcthkdM30xxS c9nocRNurXAxon7rD6UK612QgSvyTKp2bla/m8o3T2YgnCFR/NaEuZ9MjPnDYgPhsBbp DdK/SIiPBKEYmeky35Dd1jmck+55q9jsqD8wC5csDM22ata8vY+akEapgzl/nc8wYRBl 81OA== X-Received: by 10.204.21.69 with SMTP id i5mr1588120bkb.8.1392969347031; Thu, 20 Feb 2014 23:55:47 -0800 (PST) Received: from localhost (port-15573.pppoe.wtnet.de. [84.46.61.18]) by mx.google.com with ESMTPSA id yt4sm6033914bkb.7.2014.02.20.23.55.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Feb 2014 23:55:46 -0800 (PST) From: Thierry Reding To: dri-devel@lists.freedesktop.org Subject: [RFC 10/12] drm/i810: Remove dead code Date: Fri, 21 Feb 2014 08:55:26 +0100 Message-Id: <1392969328-23133-11-git-send-email-thierry.reding@gmail.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1392969328-23133-1-git-send-email-thierry.reding@gmail.com> References: <1392969328-23133-1-git-send-email-thierry.reding@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding The i810 driver never sets DRIVER_HAVE_IRQ, so testing for the presence of the feature will always fail. Signed-off-by: Thierry Reding --- drivers/gpu/drm/i810/i810_dma.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index aeace37415aa..d12e5132c4bc 100644 --- a/drivers/gpu/drm/i810/i810_dma.c +++ b/drivers/gpu/drm/i810/i810_dma.c @@ -200,13 +200,6 @@ static int i810_dma_cleanup(struct drm_device *dev) { struct drm_device_dma *dma = dev->dma; - /* Make sure interrupts are disabled here because the uninstall ioctl - * may not have been called from userspace and after dev_private - * is freed, it's too late. - */ - if (drm_core_check_feature(dev, DRIVER_HAVE_IRQ) && dev->irq_enabled) - drm_irq_uninstall(dev); - if (dev->dev_private) { int i; drm_i810_private_t *dev_priv =