From patchwork Fri Feb 21 07:55:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 3694961 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 558E6BF13A for ; Fri, 21 Feb 2014 07:56:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 88DCB20142 for ; Fri, 21 Feb 2014 07:56:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D024020145 for ; Fri, 21 Feb 2014 07:56:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDBDFFB428; Thu, 20 Feb 2014 23:56:32 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-bk0-f45.google.com (mail-bk0-f45.google.com [209.85.214.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 84C68FB438 for ; Thu, 20 Feb 2014 23:55:51 -0800 (PST) Received: by mail-bk0-f45.google.com with SMTP id mz13so942723bkb.32 for ; Thu, 20 Feb 2014 23:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K16f5umRapFI/71yxzsW136Xer1m8fR5ku2+E9UVko0=; b=Izjoiky6fMixl3JEf9XO0VskTECGy6kbyATn2cdeLWRRcdpC2xa2jCzeI/dDIbot1I 8YNxNAJfKC+K77Nv/kIhDst1mcFwlJCAsQAKw5yxJEbYd2YbJmBajf/FVwmXHjYsswAk +vKpX4v30ZFKkp4r8hOHU3uo/tYRB1hDSKUW2TzL0LaCP4N3JKjYbhHwjneq8aBlgnoQ /u5bYKOv5Pm03PG/pFSrU/EbVpMJFB2PKILuKxtLsDlUjp6m7+ZwMyU0VH0rg0Yz3zYF Q+E/ytLYrCxV3SdIXqIwRWQGVUHUcsusYcytdjDrWIqZoelPn5VmfkTADiAPQTACXFIP NFgg== X-Received: by 10.205.42.6 with SMTP id tw6mr1516403bkb.139.1392969350415; Thu, 20 Feb 2014 23:55:50 -0800 (PST) Received: from localhost (port-15573.pppoe.wtnet.de. [84.46.61.18]) by mx.google.com with ESMTPSA id r1sm6042766bkk.2.2014.02.20.23.55.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Feb 2014 23:55:49 -0800 (PST) From: Thierry Reding To: dri-devel@lists.freedesktop.org Subject: [RFC 12/12] drm/qxl: Remove dead code Date: Fri, 21 Feb 2014 08:55:28 +0100 Message-Id: <1392969328-23133-13-git-send-email-thierry.reding@gmail.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1392969328-23133-1-git-send-email-thierry.reding@gmail.com> References: <1392969328-23133-1-git-send-email-thierry.reding@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding The QXL driver sets DRIVER_MODESET unconditionally, so testing for the absence of the feature will always fail. Signed-off-by: Thierry Reding --- drivers/gpu/drm/qxl/qxl_kms.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index fd88eb4a3f79..eec2e983519b 100644 --- a/drivers/gpu/drm/qxl/qxl_kms.c +++ b/drivers/gpu/drm/qxl/qxl_kms.c @@ -310,10 +310,6 @@ int qxl_driver_load(struct drm_device *dev, unsigned long flags) struct qxl_device *qdev; int r; - /* require kms */ - if (!drm_core_check_feature(dev, DRIVER_MODESET)) - return -ENODEV; - qdev = kzalloc(sizeof(struct qxl_device), GFP_KERNEL); if (qdev == NULL) return -ENOMEM;