Message ID | 1393873738-27327-1-git-send-email-balbi@ti.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, Mar 03, 2014 at 01:08:58PM -0600, Felipe Balbi wrote: > From: Darren Etheridge <detheridge@ti.com> > > 1680x1050 appears to also be within the bandwidth capabilities > of the device and memory infrastructure. > > Signed-off-by: Darren Etheridge <detheridge@ti.com> ping > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > index 5bb64e3..b47ec24 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > @@ -43,7 +43,7 @@ > * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to > * be supportable > */ > -#define TILCDC_DEFAULT_MAX_BANDWIDTH (1280*1024*60) > +#define TILCDC_DEFAULT_MAX_BANDWIDTH (1680*1050*60) > > > struct tilcdc_drm_private { > -- > 1.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
On Mon, Mar 3, 2014 at 2:08 PM, Felipe Balbi <balbi@ti.com> wrote: > From: Darren Etheridge <detheridge@ti.com> > > 1680x1050 appears to also be within the bandwidth capabilities > of the device and memory infrastructure. For this one, is 1680x1050 possible on all devices w/ tilcdc (like 1st gen beaglebone (white), etc)? If not, maybe better to keep the default conservative and override the default in devicetree.. BR, -R > Signed-off-by: Darren Etheridge <detheridge@ti.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > index 5bb64e3..b47ec24 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > @@ -43,7 +43,7 @@ > * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to > * be supportable > */ > -#define TILCDC_DEFAULT_MAX_BANDWIDTH (1280*1024*60) > +#define TILCDC_DEFAULT_MAX_BANDWIDTH (1680*1050*60) > > > struct tilcdc_drm_private { > -- > 1.9.0 >
Rob Clark <robdclark@gmail.com> wrote on Thu [2014-Apr-24 16:51:04 -0400]: > On Mon, Mar 3, 2014 at 2:08 PM, Felipe Balbi <balbi@ti.com> wrote: > > From: Darren Etheridge <detheridge@ti.com> > > > > 1680x1050 appears to also be within the bandwidth capabilities > > of the device and memory infrastructure. > > For this one, is 1680x1050 possible on all devices w/ tilcdc (like 1st > gen beaglebone (white), etc)? If not, maybe better to keep the > default conservative and override the default in devicetree.. > Fair point Rob, I didn't test BeagleBone White at that resolution, only BeagleBone Black. I'll redo this patch as a BBB specific dts change given we already have a max-bandwidth DT binding in place for tilcdc. Thanks for reviewing it. Darren > BR, > -R > > > Signed-off-by: Darren Etheridge <detheridge@ti.com> > > --- > > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > > index 5bb64e3..b47ec24 100644 > > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h > > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > > @@ -43,7 +43,7 @@ > > * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to > > * be supportable > > */ > > -#define TILCDC_DEFAULT_MAX_BANDWIDTH (1280*1024*60) > > +#define TILCDC_DEFAULT_MAX_BANDWIDTH (1680*1050*60) > > > > > > struct tilcdc_drm_private { > > -- > > 1.9.0 > >
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h index 5bb64e3..b47ec24 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h @@ -43,7 +43,7 @@ * with optimized DDR & EMIF settings tweaked 1920x1080@24 appears to * be supportable */ -#define TILCDC_DEFAULT_MAX_BANDWIDTH (1280*1024*60) +#define TILCDC_DEFAULT_MAX_BANDWIDTH (1680*1050*60) struct tilcdc_drm_private {