From patchwork Sat Apr 5 09:44:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 3941901 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 37B64C0DA2 for ; Sat, 5 Apr 2014 09:45:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 712942034E for ; Sat, 5 Apr 2014 09:45:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 960592034C for ; Sat, 5 Apr 2014 09:45:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBC2A6E1D6; Sat, 5 Apr 2014 02:45:13 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 561176E1DA for ; Sat, 5 Apr 2014 02:45:12 -0700 (PDT) Received: by mail-we0-f181.google.com with SMTP id q58so4506802wes.12 for ; Sat, 05 Apr 2014 02:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Q6fOHFARS/6BJgWv2GL2lZVzscB2raGXm49Y6r4HVww=; b=f26blXLjs9VNjUAE7r1Lx0VkvnmsHxSPROxe/5WEqyMx4jNTkl+RwmqYlr8me/2Q1s rmbisoK4xteqR1LKyw67K44INMnQ1GoJfbzzIVbN9Zt9Rb87IhtyFTLUu8CCS0uWE2yn TgdlACm+uGHoO3ddtWZaNwMNkRj0uMKoB+TNw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Q6fOHFARS/6BJgWv2GL2lZVzscB2raGXm49Y6r4HVww=; b=ds5SDE7InoVbj3pOn7QdvH4oR7H+d71mJdJiPYCNZy2x3KCZ/0zo2GRBIvCS8ttp+9 nofAbhXzLZzzUCeP6j/zbY2f1J4Ruw85BiaI8MfSNUadHQ3f4ikXBFEpV74bmFBokb3X tWI+VMoLFpmC47OfZQnmIXOeOfQpaOk1qGVci+cOYsplm4x2VpzIZ3coGekzXfJwGA76 kQvb0ABdpyGcHOxg0f6vJpqLwihXuf6Xc2uXvwi3O9edpQhxsDfAe+rdB1NqV8XzcTcI GdObE78mUKC694MCppdiuZAlyMkT8JXhysjHq1Le3qhTqusyvwoH9oYyHP6ovrL4vbeh Qheg== X-Gm-Message-State: ALoCoQnrstmtJJFF+O+3+XvCvrts5ZXyH4Ie8zMxsAQG5mfSjtVQbj14URJEehheXpQQHel0YdET X-Received: by 10.180.205.230 with SMTP id lj6mr2831743wic.15.1396691111155; Sat, 05 Apr 2014 02:45:11 -0700 (PDT) Received: from phenom.ffwll.local (84-73-67-144.dclient.hispeed.ch. [84.73.67.144]) by mx.google.com with ESMTPSA id m42sm25789245eex.21.2014.04.05.02.45.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 05 Apr 2014 02:45:10 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 01/13] drm/mgag200: Remove unnecessary NULL check in bo_unref Date: Sat, 5 Apr 2014 11:44:50 +0200 Message-Id: <1396691102-22904-3-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1396691102-22904-1-git-send-email-daniel.vetter@ffwll.ch> References: <1396691102-22904-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Dave Jones , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ttm_bo_unref unconditionally calls kref_put on it's argument, so the thing can't be NULL without already causing Oopses. Spotted by coverity. Signed-off-by: Daniel Vetter Reviewed-by: Ian Romanick --- drivers/gpu/drm/mgag200/mgag200_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index 26868e5c55b0..0722d18992f4 100644 --- a/drivers/gpu/drm/mgag200/mgag200_main.c +++ b/drivers/gpu/drm/mgag200/mgag200_main.c @@ -322,9 +322,7 @@ static void mgag200_bo_unref(struct mgag200_bo **bo) tbo = &((*bo)->bo); ttm_bo_unref(&tbo); - if (tbo == NULL) - *bo = NULL; - + *bo = NULL; } void mgag200_gem_free_object(struct drm_gem_object *obj)