| Message ID | 1396691102-22904-6-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/05/2014 02:44 AM, Daniel Vetter wrote: > The ->gem_free_object never gets called with a NULL pointer, the check > is redundant. Also checking after the upcast allows compilers to elide > it anyway. > > Spotted by coverity. > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Same as MGA change. Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> > --- > drivers/gpu/drm/cirrus/cirrus_main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/cirrus/cirrus_main.c b/drivers/gpu/drm/cirrus/cirrus_main.c > index b119f66fed92..99c1983f99d2 100644 > --- a/drivers/gpu/drm/cirrus/cirrus_main.c > +++ b/drivers/gpu/drm/cirrus/cirrus_main.c > @@ -271,8 +271,6 @@ void cirrus_gem_free_object(struct drm_gem_object *obj) > { > struct cirrus_bo *cirrus_bo = gem_to_cirrus_bo(obj); > > - if (!cirrus_bo) > - return; > cirrus_bo_unref(&cirrus_bo); > } > >
diff --git a/drivers/gpu/drm/cirrus/cirrus_main.c b/drivers/gpu/drm/cirrus/cirrus_main.c index b119f66fed92..99c1983f99d2 100644 --- a/drivers/gpu/drm/cirrus/cirrus_main.c +++ b/drivers/gpu/drm/cirrus/cirrus_main.c @@ -271,8 +271,6 @@ void cirrus_gem_free_object(struct drm_gem_object *obj) { struct cirrus_bo *cirrus_bo = gem_to_cirrus_bo(obj); - if (!cirrus_bo) - return; cirrus_bo_unref(&cirrus_bo); }
The ->gem_free_object never gets called with a NULL pointer, the check is redundant. Also checking after the upcast allows compilers to elide it anyway. Spotted by coverity. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/cirrus/cirrus_main.c | 2 -- 1 file changed, 2 deletions(-)