From patchwork Wed Apr 16 14:33:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Kumar X-Patchwork-Id: 4005161 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 95E839F387 for ; Thu, 17 Apr 2014 01:06:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 57AF6202D1 for ; Thu, 17 Apr 2014 01:06:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 1C236202B4 for ; Thu, 17 Apr 2014 01:06:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 262B06E48D; Wed, 16 Apr 2014 18:06:03 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A4626EA6C for ; Wed, 16 Apr 2014 07:33:39 -0700 (PDT) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N44009SROG2LH50@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 16 Apr 2014 23:33:38 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id F6.5B.10092.2C49E435; Wed, 16 Apr 2014 23:33:38 +0900 (KST) X-AuditID: cbfee68f-b7f156d00000276c-98-534e94c2e6fc Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 48.93.29263.2C49E435; Wed, 16 Apr 2014 23:33:38 +0900 (KST) Received: from chromebld-server.sisodomain.com ([107.108.73.106]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4400B1ROFNHZ40@mmp1.samsung.com>; Wed, 16 Apr 2014 23:33:38 +0900 (KST) From: Ajay Kumar To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 3/7] drm/panel: Add driver for exynos_dp based panels Date: Wed, 16 Apr 2014 20:03:02 +0530 Message-id: <1397658786-26138-4-git-send-email-ajaykumar.rs@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1397658786-26138-1-git-send-email-ajaykumar.rs@samsung.com> References: <1397658786-26138-1-git-send-email-ajaykumar.rs@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsWyRsSkTvfQFL9gg1lTTCxurTvHarHy/V9G iwPvD7JYbHizkNniytf3bBaT7k9gsfi+6wu7xdmmN+wWM87vY7JYdXgDu8WURYdZLeYezLW4 /ZvPgddjdsNFFo+ds+6yeyzYVOpxv/s4k0dv8zs2j74tqxg9Pm+SC2CP4rJJSc3JLEst0rdL 4MqYs38qW8Esj4p/396zNTC+tu5i5OSQEDCR+LB/FQuELSZx4d56ti5GLg4hgaWMElumrGWG KZrffBkqsYhR4ueSW6wQzgQmiY/zZ7GCVLEJaEtsm34TbJSIgJtE0+GZYEXMAv1MEtPuPGPs YuTgEBZwlVi+QQ6khkVAVeLh1xawMK+Ah8StqWogpoSAgsScSTYgFZwCnhLnfl8Emy4EVDG1 6Rw7yEQJgWvsEms/3WOBGCMg8W3yIRaIXlmJTQegbpaUOLjiBssERuEFjAyrGEVTC5ILipPS i4z1ihNzi0vz0vWS83M3MQLj5fS/Z/07GO8esD7EmAw0biKzlGhyPjDe8kriDY3NjCxMTUyN jcwtzUgTVhLnvf8wKUhIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDo31+5vIktWlxNzfeWtrW dGwV20/7RWrr18hJ1BgpKvjF+ivoW4YdCv5yU+9E7qYkzbUOk59cKdzzvo81b9PGy+r65t4W dSoPrTrZWtKnrDhXZn/5rMF0ngeXjRrs1aekKIVNWWTpu+i7n9d+TZGoBV6NZreLvVYu3Pyn 3I+t/myZiZBZWeUsJZbijERDLeai4kQAxcfqQq0CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsVy+t9jAd1DU/yCDbb80LS4te4cq8XK938Z LQ68P8hiseHNQmaLK1/fs1lMuj+BxeL7ri/sFmeb3rBbzDi/j8li1eEN7BZTFh1mtZh7MNfi 9m8+B16P2Q0XWTx2zrrL7rFgU6nH/e7jTB69ze/YPPq2rGL0+LxJLoA9qoHRJiM1MSW1SCE1 Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwfoWCWFssScUqBQQGJxsZK+ HaYJoSFuuhYwjRG6viFBcD1GBmggYQ1jxpz9U9kKZnlU/Pv2nq2B8bV1FyMnh4SAicT85sts ELaYxIV764FsLg4hgUWMEj+X3GKFcCYwSXycP4sVpIpNQFti2/SbLCC2iICbRNPhmWBFzAL9 TBLT7jxj7GLk4BAWcJVYvkEOpIZFQFXi4dcWsDCvgIfEralqIKaEgILEnEk2IBWcAp4S535f BJsuBFQxtekc+wRG3gWMDKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgqPxmdQOxpUNFocY BTgYlXh4Z+T4BguxJpYVV+YeYpTgYFYS4b3Q5hcsxJuSWFmVWpQfX1Sak1p8iDEZ6KaJzFKi yfnARJFXEm9obGJuamxqaWJhYmZJmrCSOO+BVutAIYH0xJLU7NTUgtQimC1MHJxSDYw7X7qq rw30n3FM1+fkqkeMbx8kvCytsN2z4s3N15EHH9SFJe+2utSvc8R0yr3Fu/Nyq7XPthof2Ct1 ul1wyeolH7u2x/JxZP3pWbD8y92UY3X+1+Tkfx+qutM49Xeg8P6ZttaJ2S7hire6blolRLzM +N0qLGcifFqxw0vFLF9HYuM764vuNvOVWIozEg21mIuKEwGwGhYmCgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 16 Apr 2014 18:06:02 -0700 Cc: seanpaul@google.com, abrestic@chromium.org, joshi@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com, ajaynumb@gmail.com, treding@nvidia.com, prashanth.g@samsung.com, Ajay Kumar , rahul.sharma@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a simple driver to handle all the LCD and LED powerup/down routines needed to support eDP/eDP-LVDS panels supported on exynos boards. Most of the eDP/LVDS panels need this sequence for powerup: -- LCD unit powerup/LCD_EN -- video data on -- LED unit powerup/BL_EN The LCD and LED units are usually powered up via regulators, and almost on all boards, we will have a BL_EN pin to enable/ disable the backlight. Sometimes, we can have LCD_EN switches as well. The routines in this driver can be used to control panel power sequence on such boards. Signed-off-by: Ajay Kumar --- .../devicetree/bindings/panel/exynos-dp-panel.txt | 32 ++++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-exynos-dp.c | 213 +++++++++++++++++++++ 4 files changed, 255 insertions(+) create mode 100644 Documentation/devicetree/bindings/panel/exynos-dp-panel.txt create mode 100644 drivers/gpu/drm/panel/panel-exynos-dp.c diff --git a/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt b/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt new file mode 100644 index 0000000..a1428d2 --- /dev/null +++ b/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt @@ -0,0 +1,32 @@ +exynos_DP_panel/DP_to_LVDS_panel +================================== + +Required properties: + - compatible: "samsung,exynos-dp-panel" + +Optional properties: + -samsung,lcd-en-gpio: + eDP panel LCD poweron GPIO. + Indicates which GPIO needs to be powered up as output + to powerup/enable the switch to the LCD panel. + -samsung,led-en-gpio: + eDP panel LED enable GPIO. + Indicates which GPIO needs to be powered up as output + to enable the backlight. + -samsung,power-up-delay: + eDP panel powerup delay value in ms. + Delay in ms needed for the eDP panel to properly + powerup after giving powerup signals to the panel. + -samsung,power-down-delay: + eDP panel powerdown delay value in ms. + Delay in ms needed for the eDP panel to properly + powerdown after giving powerdown signals to the panel. + +Example: + + dp-panel { + compatible = "samsung,exynos-dp-panel"; + samsung,led-en-gpio = <&gpx3 0 1>; + samsung,power-up-delay = <40>; + samsung,power-down-delay = <50>; + }; diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 4ec874d..ea9d5ac 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -30,4 +30,13 @@ config DRM_PANEL_S6E8AA0 select DRM_MIPI_DSI select VIDEOMODE_HELPERS +config DRM_PANEL_EXYNOS_DP + tristate "support for DP panels" + depends on OF && DRM_PANEL && DRM_EXYNOS_DP + help + DRM panel driver for DP panels and LVDS connected via DP bridges + that need at most a regulator for LCD unit, a regulator for LED unit + and/or enable GPIOs for LCD or LED units. Delay values can also be + specified to support powerup and powerdown process. + endmenu diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 8b92921..30311a4 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o obj-$(CONFIG_DRM_PANEL_LD9040) += panel-ld9040.o obj-$(CONFIG_DRM_PANEL_S6E8AA0) += panel-s6e8aa0.o +obj-$(CONFIG_DRM_PANEL_EXYNOS_DP) += panel-exynos-dp.o diff --git a/drivers/gpu/drm/panel/panel-exynos-dp.c b/drivers/gpu/drm/panel/panel-exynos-dp.c new file mode 100644 index 0000000..e85a7b2 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-exynos-dp.c @@ -0,0 +1,213 @@ +/* + * Exynos DP panel driver + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd + * + * Ajay Kumar + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +struct panel_exynos_dp { + struct drm_panel base; + struct regulator *bck_fet; + struct regulator *lcd_fet; + int led_en_gpio; + int lcd_en_gpio; + int power_up_delay; + int power_down_delay; + bool enabled; +}; + +static inline struct panel_exynos_dp *to_panel(struct drm_panel *panel) +{ + return container_of(panel, struct panel_exynos_dp, base); +} + +static int panel_exynos_dp_disable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + bool enable_delay = false; + + if (!dp_panel->enabled) + return 0; + + if (gpio_is_valid(dp_panel->led_en_gpio)) + gpio_set_value(dp_panel->led_en_gpio, 0); + + if (!IS_ERR_OR_NULL(dp_panel->bck_fet)) + regulator_disable(dp_panel->bck_fet); + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) { + gpio_set_value(dp_panel->lcd_en_gpio, 0); + enable_delay = true; + } + + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) { + regulator_disable(dp_panel->lcd_fet); + enable_delay = true; + } + + if (enable_delay) + msleep(dp_panel->power_down_delay); + + dp_panel->enabled = false; + + return 0; +} + +static int panel_exynos_dp_pre_enable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + bool enable_delay = false; + + if (dp_panel->enabled) + return 0; + + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) { + if (regulator_enable(dp_panel->lcd_fet)) + DRM_ERROR("Failed to enable LCD fet\n"); + enable_delay = true; + } + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) { + gpio_set_value(dp_panel->lcd_en_gpio, 1); + enable_delay = true; + } + + if (enable_delay) + msleep(dp_panel->power_up_delay); + + return 0; +} + +static int panel_exynos_dp_enable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + + if (dp_panel->enabled) + return 0; + + if (!IS_ERR_OR_NULL(dp_panel->bck_fet)) + if (regulator_enable(dp_panel->bck_fet)) + DRM_ERROR("Failed to enable LED fet\n"); + + if (gpio_is_valid(dp_panel->led_en_gpio)) + gpio_set_value(dp_panel->led_en_gpio, 1); + + dp_panel->enabled = true; + + return 0; +} + +static const struct drm_panel_funcs panel_exynos_dp_funcs = { + .disable = panel_exynos_dp_disable, + .pre_enable = panel_exynos_dp_pre_enable, + .enable = panel_exynos_dp_enable, +}; + +static int panel_exynos_dp_probe(struct platform_device *pdev) +{ + struct panel_exynos_dp *dp_panel; + struct device *dev = &pdev->dev; + int ret; + + dp_panel = devm_kzalloc(dev, sizeof(*dp_panel), GFP_KERNEL); + if (!dp_panel) + return -ENOMEM; + + dp_panel->enabled = false; + + dp_panel->lcd_en_gpio = of_get_named_gpio(dev->of_node, + "samsung,lcd-en-gpio", 0); + dp_panel->led_en_gpio = of_get_named_gpio(dev->of_node, + "samsung,led-en-gpio", 0); + + of_property_read_u32(dev->of_node, "samsung,power-up-delay", + &dp_panel->power_up_delay); + of_property_read_u32(dev->of_node, "samsung,power-down-delay", + &dp_panel->power_down_delay); + + dp_panel->lcd_fet = devm_regulator_get(dev, "lcd_vdd"); + if (IS_ERR(dp_panel->lcd_fet)) + return PTR_ERR(dp_panel->lcd_fet); + + dp_panel->bck_fet = devm_regulator_get(dev, "vcd_led"); + if (IS_ERR(dp_panel->bck_fet)) + return PTR_ERR(dp_panel->bck_fet); + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) { + ret = devm_gpio_request_one(dev, dp_panel->lcd_en_gpio, + GPIOF_OUT_INIT_LOW, "lcd_en_gpio"); + if (ret) { + DRM_ERROR("failed to get lcd-en gpio [%d]\n", ret); + return ret; + } + } else { + dp_panel->lcd_en_gpio = -ENODEV; + } + + if (gpio_is_valid(dp_panel->led_en_gpio)) { + ret = devm_gpio_request_one(dev, dp_panel->led_en_gpio, + GPIOF_OUT_INIT_LOW, "led_en_gpio"); + if (ret) { + DRM_ERROR("failed to get led-en gpio [%d]\n", ret); + return ret; + } + } else { + dp_panel->led_en_gpio = -ENODEV; + } + + drm_panel_init(&dp_panel->base); + dp_panel->base.dev = dev; + dp_panel->base.funcs = &panel_exynos_dp_funcs; + + ret = drm_panel_add(&dp_panel->base); + if (ret < 0) + return ret; + + dev_set_drvdata(dev, dp_panel); + + return 0; +} + +static int panel_exynos_dp_remove(struct platform_device *pdev) +{ + struct panel_exynos_dp *dp_panel = dev_get_drvdata(&pdev->dev); + + drm_panel_detach(&dp_panel->base); + drm_panel_remove(&dp_panel->base); + + panel_exynos_dp_disable(&dp_panel->base); + + return 0; +} + +static const struct of_device_id exynos_dp_panel_dt_match[] = { + { .compatible = "samsung,exynos-dp-panel" }, + {}, +}; + +struct platform_driver exynos_dp_panel_driver = { + .driver = { + .name = "exynos-dp-panel", + .owner = THIS_MODULE, + .of_match_table = exynos_dp_panel_dt_match, + }, + .probe = panel_exynos_dp_probe, + .remove = panel_exynos_dp_remove, +};