From patchwork Sun Apr 20 10:21:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 4021601 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3A7419F387 for ; Sun, 20 Apr 2014 15:04:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7AFBD20213 for ; Sun, 20 Apr 2014 15:04:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 70F142021B for ; Sun, 20 Apr 2014 15:04:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A240F6E1D7; Sun, 20 Apr 2014 08:04:27 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 8ADEF6E067 for ; Sun, 20 Apr 2014 03:22:05 -0700 (PDT) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4B005XORGQJF30@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Sun, 20 Apr 2014 19:22:02 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 6F.2B.11120.ACF93535; Sun, 20 Apr 2014 19:22:02 +0900 (KST) X-AuditID: cbfee68f-b7eff6d000002b70-4d-53539fcace9e Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id D4.40.27725.ACF93535; Sun, 20 Apr 2014 19:22:02 +0900 (KST) Received: from localhost.localdomain ([107.108.83.245]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4B00LC2RGD0880@mmp2.samsung.com>; Sun, 20 Apr 2014 19:22:02 +0900 (KST) From: Rahul Sharma To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH v2 1/3] drm/exynos: remove unnecessary read for phy configuration values Date: Sun, 20 Apr 2014 15:51:15 +0530 Message-id: <1397989277-29602-2-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1397989277-29602-1-git-send-email-rahul.sharma@samsung.com> References: <1397989277-29602-1-git-send-email-rahul.sharma@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsWyRsSkTvfU/OBgg65mLYsrX9+zWUy6P4HF 4vuuL+wWM87vY7JY+CLeYsqiw6wObB47Z91l97jffZzJo2/LKkaPz5vkAliiuGxSUnMyy1KL 9O0SuDImPrjDVHCJq6Lz/EK2BsZXHF2MHBwSAiYSm766dDFyApliEhfurWfrYuTiEBJYyijx /t5pNpiaNX+dIeLTGSW2XDzMBOG0M0ms/zGTHaSbTUBXYvbBZ4wgtoiAm0TT4ZmsIDazQLbE 4QMvweLCAlES5+d0gsVZBFQlNkz6ygZi8wp4SGy4OYEdYpmCxJxJNiAmp4CnxOmlnCAVQkAV z092gK2VEOhml5g/+RQbxBgBiW+TD7FAtMpKbDrADPGLpMTBFTdYJjAKL2BkWMUomlqQXFCc lF5krFecmFtcmpeul5yfu4kRGMqn/z3r38F494D1IcZkoHETmaVEk/OBsZBXEm9obGZkYWpi amxkbmlGmrCSOO/9h0lBQgLpiSWp2ampBalF8UWlOanFhxiZODilGhjzlYVOTlIKbjn2612C 6FzxG2de7l2eO01yg/crjYgcy6uf/YKnVR1mZThbsejLnC61mBefQlbUbNtjdLNO90mSxVTr 6ryfOluj5oge0XeY2VV+Uq9ZiktEzkkv/pRy1eFb5/wXF18Mygo8OPH90pfT2syrZiktEbmp ym3zwMefrZLfrU3+724lluKMREMt5qLiRABo+9EWewIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t9jQd1T84ODDWbekLe48vU9m8Wk+xNY LL7v+sJuMeP8PiaLhS/iLaYsOszqwOaxc9Zddo/73ceZPPq2rGL0+LxJLoAlqoHRJiM1MSW1 SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdouZJCWWJOKVAoILG4 WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYxY+KDO0wFl7gqOs8vZGtgfMXRxcjBISFgIrHm r3MXIyeQKSZx4d56ti5GLg4hgemMElsuHmaCcNqZJNb/mMkOUsUmoCsx++AzRhBbRMBNounw TFYQm1kgW+LwgZdgcWGBKInzczrB4iwCqhIbJn1lA7F5BTwkNtycwA6xWEFiziQbEJNTwFPi 9FJOkAohoIrnJzuYJjDyLmBkWMUomlqQXFCclJ5rqFecmFtcmpeul5yfu4kRHCvPpHYwrmyw OMQowMGoxMP74kdQsBBrYllxZe4hRgkOZiUR3uR5wcFCvCmJlVWpRfnxRaU5qcWHGJOBbprI LCWanA+M47ySeENjE3NTY1NLEwsTM0vShJXEeQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYLRP FzFmmvXzypxgNr2LnzcLxvlNduConXdc1tV5fmtNRfcDER+jJ3ItIXq/P69I7nIKvXyZ+6r4 vtoKfUOXyUJvVNVnbD25J7NccOpezf1TNh1tE7OQdlFWXFP2Uuv7w8eaLJWCD2IMGs8p1yvt WmP0fJ0cp7niySUzAnkX2HTXNzWvz2erVWIpzkg01GIuKk4EAI6yMirZAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Sun, 20 Apr 2014 08:04:17 -0700 Cc: joshi@samsung.com, Rahul Sharma X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rahul Sharma Cleaning up unnecessary i2c read call after hdmiphy configuration. This check is redundant since check for hdmiphy pll lock status confirms the correct settings for phy. Signed-off-by: Rahul Sharma Signed-off-by: Daniel Kurtz Reviewed-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_hdmi.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index ef1cdd0..438eeda 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1517,7 +1517,6 @@ static void hdmiphy_conf_apply(struct hdmi_context *hdata) const u8 *hdmiphy_data; u8 buffer[32]; u8 operation[2]; - u8 read_buffer[32] = {0, }; int ret; int i; @@ -1557,15 +1556,6 @@ static void hdmiphy_conf_apply(struct hdmi_context *hdata) return; } - ret = i2c_master_recv(hdata->hdmiphy_port, read_buffer, 32); - if (ret < 0) { - DRM_ERROR("failed to read hdmiphy config\n"); - return; - } - - for (i = 0; i < ret; i++) - DRM_DEBUG_KMS("hdmiphy[0x%02x] write[0x%02x] - " - "recv [0x%02x]\n", i, buffer[i], read_buffer[i]); } static void hdmi_conf_apply(struct hdmi_context *hdata)