From patchwork Mon Apr 21 22:39:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Kumar X-Patchwork-Id: 4027801 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E247DBFF02 for ; Tue, 22 Apr 2014 01:29:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C642520340 for ; Tue, 22 Apr 2014 01:29:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 25EB620265 for ; Tue, 22 Apr 2014 01:29:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12B556E480; Mon, 21 Apr 2014 18:29:55 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id BC0AC6E460 for ; Mon, 21 Apr 2014 15:39:55 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4E00ES1KAIRBA0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 22 Apr 2014 07:39:54 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.124]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 29.88.18501.A3E95535; Tue, 22 Apr 2014 07:39:54 +0900 (KST) X-AuditID: cbfee68d-b7f4e6d000004845-f6-53559e3a710e Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id C6.32.25708.A3E95535; Tue, 22 Apr 2014 07:39:54 +0900 (KST) Received: from chromebld-server.sisodomain.com ([107.108.73.106]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4E00B0HKA7C630@mmp1.samsung.com>; Tue, 22 Apr 2014 07:39:54 +0900 (KST) From: Ajay Kumar To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH V2 3/9] drm/panel: Add driver for exynos_dp based panels Date: Tue, 22 Apr 2014 04:09:12 +0530 Message-id: <1398119958-32005-4-git-send-email-ajaykumar.rs@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1398119958-32005-1-git-send-email-ajaykumar.rs@samsung.com> References: <1398119958-32005-1-git-send-email-ajaykumar.rs@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsWyRsSkRtdqXmiwwe5mdYsD7w+yWGx4s5DZ 4srX92wWk+5PYLH4vusLu8WM8/uYLFYd3sBuMfdgrgOHx85Zd9k9Fmwq9bjffZzJo2/LKkaP z5vkAlijuGxSUnMyy1KL9O0SuDKOnDvMVPAnvGL2gxlMDYwrPLsYOTgkBEwkdv9J7mLkBDLF JC7cW88GYgsJLGWUmNQeDhE3kbgw9T5TFyMXUHwRo8SqDX9YIZwJTBL3H19jBaliE9CW2Db9 JguILSLgJtF0eCZYEbPADEaJuy8fgI0VFvCQONJ3gRHEZhFQlTh19DiYzQsUX/X4HBPERQoS cybZgIQ5BTwlts/7ywpxkYfExD0/2EFmSggsYpdYe+seE8QcAYlvkw+xQPTKSmw6wAxxtaTE wRU3WCYwCi9gZFjFKJpakFxQnJReZKhXnJhbXJqXrpecn7uJERjqp/89693BePuA9SHGZKBx E5mlRJPzgbGSVxJvaGxmZGFqYmpsZG5pRpqwkjhv0sOkICGB9MSS1OzU1ILUovii0pzU4kOM TBycUg2MWpOmK8UanWqw038VFPprK0fufEdeNdP4hQnHIqYWvpkkyPT7orTz57d7Lbz5431b L928tqzGPuTbiVnPqlT1WvqOH9YPcnJ/4yXk06G9qN3fqIh33RStl6+UXj+5/eFN7f3ZR9Jf bH/rHbKl1cY41VlyE7Pl7eOfj+lMmb9oyqnLidx/5oUKKbEUZyQaajEXFScCABNWbsiLAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jAV2reaHBBtMuSFsceH+QxWLDm4XM Fle+vmezmHR/AovF911f2C1mnN/HZLHq8AZ2i7kHcx04PHbOusvusWBTqcf97uNMHn1bVjF6 fN4kF8Aa1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuW mQN0ipJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx48i5w0wFf8IrZj+Y wdTAuMKzi5GTQ0LAROLC1PtMELaYxIV769m6GLk4hAQWMUqs2vCHFcKZwCRx//E1VpAqNgFt iW3Tb7KA2CICbhJNh2eCFTELzGCUuPvyARtIQljAQ+JI3wVGEJtFQFXi1NHjYDYvUHzV43NA 6ziA1ilIzJlkAxLmFPCU2D7vL9h8IaCSiXt+sE9g5F3AyLCKUTS1ILmgOCk910ivODG3uDQv XS85P3cTIzianknvYFzVYHGIUYCDUYmHV8IgNFiINbGsuDL3EKMEB7OSCO/aNKAQb0piZVVq UX58UWlOavEhxmSgoyYyS4km5wMjPa8k3tDYxNzU2NTSxMLEzJI0YSVx3oOt1oFCAumJJanZ qakFqUUwW5g4OKUaGO2r3t1/+yX0qYPWXouWljiZw8qf/gv0P+jXdH8Romt0/bGD/rQHvgEq q/bv39J9xP2i1fy6yQLTXxg9m9ezJH6n49UXd+uk1zG6ib3OyVjw5XTqIeXKmXI6HHUOz8SK t/498+Gq62Xpjt6pmiGpHz0/NXuWzp5xfzNDS6qTS6S4vdx79ovNV5VYijMSDbWYi4oTAfdR zZXqAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Mon, 21 Apr 2014 18:29:54 -0700 Cc: seanpaul@google.com, joshi@samsung.com, ajaynumb@gmail.com, prashanth.g@samsung.com, Ajay Kumar X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a simple driver to handle all the LCD and LED powerup/down routines needed to support eDP/eDP-LVDS panels supported on exynos boards. The LCD and LED units are usually powered up via regulators, and almost on all boards, we will have a BL_EN pin to enable/ disable the backlight. Sometimes, we can have LCD_EN switches as well. The routines in this driver can be used to control panel power sequence on such boards. Signed-off-by: Ajay Kumar --- Changes since V1: Added routine for post_disable, removed few unwanted headers. Refactored a lot of code. .../devicetree/bindings/panel/exynos-dp-panel.txt | 45 ++++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-exynos-dp.c | 251 ++++++++++++++++++++ 4 files changed, 306 insertions(+) create mode 100644 Documentation/devicetree/bindings/panel/exynos-dp-panel.txt create mode 100644 drivers/gpu/drm/panel/panel-exynos-dp.c diff --git a/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt b/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt new file mode 100644 index 0000000..3fbca54 --- /dev/null +++ b/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt @@ -0,0 +1,45 @@ +exynos_DP_panel/DP_to_LVDS_panel + +Required properties: + - compatible: "samsung,exynos-dp-panel" + +Optional properties: + -samsung,lcd-en-gpio: + eDP panel LCD poweron GPIO. + Indicates which GPIO needs to be powered up as output + to powerup/enable the switch to the LCD panel. + -samsung,led-en-gpio: + eDP panel LED enable GPIO. + Indicates which GPIO needs to be powered up as output + to enable the backlight. + -samsung,panel-pre-enable-delay: + delay value in ms required for panel_pre_enable process + Delay in ms needed for the eDP panel LCD unit to + powerup, and delay needed between panel_VCC and + video_enable. + -samsung,panel-enable-delay: + delay value in ms required for panel_enable process + Delay in ms needed for the eDP panel backlight/LED unit + to powerup, and delay needed between video_enable and + BL_EN. + samsung,panel-disable-delay: + delay value in ms required for panel_disable process + Delay in ms needed for the eDP panel backlight/LED unit + powerdown, and delay needed between BL_DISABLE and + video_disable. + samsung,panel-post-disable-delay: + delay value in ms required for panel_post_disable process + Delay in ms needed for the eDP panel LCD unit to + to powerdown, and delay between video_disable and + panel_VCC going down. + +Example: + + dp-panel { + compatible = "samsung,exynos-dp-panel"; + samsung,led-en-gpio = <&gpx3 0 1>; + samsung,panel-pre-enable-delay = <40>; + samsung,panel-enable-delay = <20>; + samsung,panel-disable-delay = <20>; + samsung,panel-post-disable-delay = <30>; + }; diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 4ec874d..ea9d5ac 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -30,4 +30,13 @@ config DRM_PANEL_S6E8AA0 select DRM_MIPI_DSI select VIDEOMODE_HELPERS +config DRM_PANEL_EXYNOS_DP + tristate "support for DP panels" + depends on OF && DRM_PANEL && DRM_EXYNOS_DP + help + DRM panel driver for DP panels and LVDS connected via DP bridges + that need at most a regulator for LCD unit, a regulator for LED unit + and/or enable GPIOs for LCD or LED units. Delay values can also be + specified to support powerup and powerdown process. + endmenu diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 8b92921..30311a4 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o obj-$(CONFIG_DRM_PANEL_LD9040) += panel-ld9040.o obj-$(CONFIG_DRM_PANEL_S6E8AA0) += panel-s6e8aa0.o +obj-$(CONFIG_DRM_PANEL_EXYNOS_DP) += panel-exynos-dp.o diff --git a/drivers/gpu/drm/panel/panel-exynos-dp.c b/drivers/gpu/drm/panel/panel-exynos-dp.c new file mode 100644 index 0000000..5568d6a --- /dev/null +++ b/drivers/gpu/drm/panel/panel-exynos-dp.c @@ -0,0 +1,251 @@ +/* + * Exynos DP panel driver + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd + * + * Ajay Kumar + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +enum panel_state { + PRE_ENABLE, + ENABLE, + DISABLE, + POST_DISABLE, +}; + +struct panel_exynos_dp { + struct drm_panel base; + struct regulator *backlight_fet; + struct regulator *lcd_fet; + int led_en_gpio; + int lcd_en_gpio; + int panel_pre_enable_delay; + int panel_enable_delay; + int panel_disable_delay; + int panel_post_disable_delay; + enum panel_state panel_state; +}; + +static inline struct panel_exynos_dp *to_panel(struct drm_panel *panel) +{ + return container_of(panel, struct panel_exynos_dp, base); +} + +static int panel_exynos_dp_post_disable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != DISABLE) { + dev_err(dev, "invoking panel_exynos_dp_post_disable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) + gpio_set_value(dp_panel->lcd_en_gpio, 0); + + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) + regulator_disable(dp_panel->lcd_fet); + + msleep(dp_panel->panel_post_disable_delay); + + dp_panel->panel_state = POST_DISABLE; + + return 0; +} + +static int panel_exynos_dp_disable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != ENABLE) { + dev_err(dev, "invoking panel_exynos_dp_disable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (gpio_is_valid(dp_panel->led_en_gpio)) + gpio_set_value(dp_panel->led_en_gpio, 0); + + if (!IS_ERR_OR_NULL(dp_panel->backlight_fet)) + regulator_disable(dp_panel->backlight_fet); + + msleep(dp_panel->panel_disable_delay); + + dp_panel->panel_state = DISABLE; + + return 0; +} + +static int panel_exynos_dp_pre_enable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != POST_DISABLE) { + dev_err(dev, "invoking panel_exynos_dp_pre_enable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) + if (regulator_enable(dp_panel->lcd_fet)) + DRM_ERROR("Failed to enable LCD fet\n"); + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) + gpio_set_value(dp_panel->lcd_en_gpio, 1); + + msleep(dp_panel->panel_pre_enable_delay); + + dp_panel->panel_state = PRE_ENABLE; + + return 0; +} + +static int panel_exynos_dp_enable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != PRE_ENABLE) { + dev_err(dev, "invoking panel_exynos_dp_enable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (!IS_ERR_OR_NULL(dp_panel->backlight_fet)) + if (regulator_enable(dp_panel->backlight_fet)) + DRM_ERROR("Failed to enable LED fet\n"); + + msleep(dp_panel->panel_enable_delay); + + if (gpio_is_valid(dp_panel->led_en_gpio)) + gpio_set_value(dp_panel->led_en_gpio, 1); + + dp_panel->panel_state = ENABLE; + + return 0; +} + +static const struct drm_panel_funcs panel_exynos_dp_funcs = { + .post_disable = panel_exynos_dp_post_disable, + .disable = panel_exynos_dp_disable, + .pre_enable = panel_exynos_dp_pre_enable, + .enable = panel_exynos_dp_enable, +}; + +static int panel_exynos_dp_probe(struct platform_device *pdev) +{ + struct panel_exynos_dp *dp_panel; + struct device *dev = &pdev->dev; + int ret; + + dp_panel = devm_kzalloc(dev, sizeof(*dp_panel), GFP_KERNEL); + if (!dp_panel) + return -ENOMEM; + + dp_panel->panel_state = POST_DISABLE; + + dp_panel->lcd_en_gpio = of_get_named_gpio(dev->of_node, + "samsung,lcd-en-gpio", 0); + dp_panel->led_en_gpio = of_get_named_gpio(dev->of_node, + "samsung,led-en-gpio", 0); + + of_property_read_u32(dev->of_node, "samsung,panel-pre-enable-delay", + &dp_panel->panel_pre_enable_delay); + of_property_read_u32(dev->of_node, "samsung,panel-enable-delay", + &dp_panel->panel_enable_delay); + of_property_read_u32(dev->of_node, "samsung,panel-disable-delay", + &dp_panel->panel_disable_delay); + of_property_read_u32(dev->of_node, "samsung,panel-post-disable-delay", + &dp_panel->panel_post_disable_delay); + + dp_panel->lcd_fet = devm_regulator_get(dev, "lcd_vdd"); + if (IS_ERR(dp_panel->lcd_fet)) + return PTR_ERR(dp_panel->lcd_fet); + + dp_panel->backlight_fet = devm_regulator_get(dev, "vcd_led"); + if (IS_ERR(dp_panel->backlight_fet)) + return PTR_ERR(dp_panel->backlight_fet); + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) { + ret = devm_gpio_request_one(dev, dp_panel->lcd_en_gpio, + GPIOF_OUT_INIT_LOW, "lcd_en_gpio"); + if (ret) { + DRM_ERROR("failed to get lcd-en gpio [%d]\n", ret); + return ret; + } + } else { + dp_panel->lcd_en_gpio = -ENODEV; + } + + if (gpio_is_valid(dp_panel->led_en_gpio)) { + ret = devm_gpio_request_one(dev, dp_panel->led_en_gpio, + GPIOF_OUT_INIT_LOW, "led_en_gpio"); + if (ret) { + DRM_ERROR("failed to get led-en gpio [%d]\n", ret); + return ret; + } + } else { + dp_panel->led_en_gpio = -ENODEV; + } + + dp_panel->panel_state = POST_DISABLE; + drm_panel_init(&dp_panel->base); + dp_panel->base.dev = dev; + dp_panel->base.funcs = &panel_exynos_dp_funcs; + + ret = drm_panel_add(&dp_panel->base); + if (ret < 0) + return ret; + + dev_set_drvdata(dev, dp_panel); + + return 0; +} + +static int panel_exynos_dp_remove(struct platform_device *pdev) +{ + struct panel_exynos_dp *dp_panel = dev_get_drvdata(&pdev->dev); + + dp_panel->panel_state = ENABLE; + panel_exynos_dp_disable(&dp_panel->base); + panel_exynos_dp_post_disable(&dp_panel->base); + + drm_panel_detach(&dp_panel->base); + drm_panel_remove(&dp_panel->base); + + return 0; +} + +static const struct of_device_id exynos_dp_panel_dt_match[] = { + { .compatible = "samsung,exynos-dp-panel" }, + {}, +}; + +struct platform_driver exynos_dp_panel_driver = { + .driver = { + .name = "exynos-dp-panel", + .owner = THIS_MODULE, + .of_match_table = exynos_dp_panel_dt_match, + }, + .probe = panel_exynos_dp_probe, + .remove = panel_exynos_dp_remove, +};