| Message ID | 1399451201-9602-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, May 7, 2014 at 10:26 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Only gma500 is still using this, once that's converted we can kill all > this code. If that conversion doesn't happen soonish I think we should > just move this helper code into the gma500 driver itself to avoid > abuse from new drivers. I'll try to find some time to convert gma500 this weekend. If that fails, I'm ok with moving it into gma500. Thanks for reminding me Patrik > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > Cc: Alan Cox <alan@linux.intel.com> > Cc: Thierry Reding <treding@nvidia.com> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/drm_dp_helper.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index a13f1f51f68e..494219ccdf96 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -213,6 +213,10 @@ i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) > * > * RETURNS: > * 0 on success, -ERRNO on failure. > + * > + * IMPORTANT: > + * This interface is deprecated, please switch to the new dp aux helpers and > + * drm_dp_aux_register_i2c_bus(). > */ > int > i2c_dp_aux_add_bus(struct i2c_adapter *adapter) > -- > 1.9.2 >
On Wed, May 07, 2014 at 10:26:41AM +0200, Daniel Vetter wrote: > Only gma500 is still using this, once that's converted we can kill all > this code. If that conversion doesn't happen soonish I think we should > just move this helper code into the gma500 driver itself to avoid > abuse from new drivers. > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > Cc: Alan Cox <alan@linux.intel.com> > Cc: Thierry Reding <treding@nvidia.com> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/drm_dp_helper.c | 4 ++++ > 1 file changed, 4 insertions(+) Acked-by: Thierry Reding <treding@nvidia.com>
On Wed, May 07, 2014 at 09:24:02PM +0200, Patrik Jakobsson wrote: > On Wed, May 7, 2014 at 10:26 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > Only gma500 is still using this, once that's converted we can kill all > > this code. If that conversion doesn't happen soonish I think we should > > just move this helper code into the gma500 driver itself to avoid > > abuse from new drivers. > > I'll try to find some time to convert gma500 this weekend. If that fails, I'm ok > with moving it into gma500. I don't think there's a need to rush things. In my opinion it's fine if this stays around for another couple of releases, as long as it's removed eventually. Thierry
Typo in the subject bugs my OCD, otherwise agreed. Jani. On Wed, 07 May 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Only gma500 is still using this, once that's converted we can kill all > this code. If that conversion doesn't happen soonish I think we should > just move this helper code into the gma500 driver itself to avoid > abuse from new drivers. > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > Cc: Alan Cox <alan@linux.intel.com> > Cc: Thierry Reding <treding@nvidia.com> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/drm_dp_helper.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index a13f1f51f68e..494219ccdf96 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -213,6 +213,10 @@ i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) > * > * RETURNS: > * 0 on success, -ERRNO on failure. > + * > + * IMPORTANT: > + * This interface is deprecated, please switch to the new dp aux helpers and > + * drm_dp_aux_register_i2c_bus(). > */ > int > i2c_dp_aux_add_bus(struct i2c_adapter *adapter) > -- > 1.9.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tuesday, May 13, 2014 4:38 PM, Thierry Reding wrote: > On Wed, May 07, 2014 at 09:24:02PM +0200, Patrik Jakobsson wrote: > > On Wed, May 7, 2014 at 10:26 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > Only gma500 is still using this, once that's converted we can kill all > > > this code. If that conversion doesn't happen soonish I think we should > > > just move this helper code into the gma500 driver itself to avoid > > > abuse from new drivers. > > > > I'll try to find some time to convert gma500 this weekend. If that fails, I'm ok > > with moving it into gma500. > > I don't think there's a need to rush things. In my opinion it's fine if > this stays around for another couple of releases, as long as it's > removed eventually. I agree with your opinion. Within few releases, it can be changed and removed. Actually, marking it as deprecated looks more urgent. Thanks. Best regards, Jingoo Han > > Thierry
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index a13f1f51f68e..494219ccdf96 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -213,6 +213,10 @@ i2c_dp_aux_prepare_bus(struct i2c_adapter *adapter) * * RETURNS: * 0 on success, -ERRNO on failure. + * + * IMPORTANT: + * This interface is deprecated, please switch to the new dp aux helpers and + * drm_dp_aux_register_i2c_bus(). */ int i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
Only gma500 is still using this, once that's converted we can kill all this code. If that conversion doesn't happen soonish I think we should just move this helper code into the gma500 driver itself to avoid abuse from new drivers. Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: Alan Cox <alan@linux.intel.com> Cc: Thierry Reding <treding@nvidia.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/drm_dp_helper.c | 4 ++++ 1 file changed, 4 insertions(+)