From patchwork Thu Feb 15 11:56:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Borntraeger X-Patchwork-Id: 10220943 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 439DA601E7 for ; Thu, 15 Feb 2018 11:56:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34DE229144 for ; Thu, 15 Feb 2018 11:56:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2935129154; Thu, 15 Feb 2018 11:56:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9529F29144 for ; Thu, 15 Feb 2018 11:56:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BB0D6E460; Thu, 15 Feb 2018 11:56:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C3946E460 for ; Thu, 15 Feb 2018 11:56:53 +0000 (UTC) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1FBsDh3121122 for ; Thu, 15 Feb 2018 06:56:52 -0500 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g58gqb3j6-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 15 Feb 2018 06:56:51 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Feb 2018 11:56:50 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 15 Feb 2018 11:56:45 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1FBujKv50987236; Thu, 15 Feb 2018 11:56:45 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 60D8F11C04A; Thu, 15 Feb 2018 11:49:56 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C7B8111C050; Thu, 15 Feb 2018 11:49:55 +0000 (GMT) Received: from oc7330422307.ibm.com (unknown [9.152.224.153]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 15 Feb 2018 11:49:55 +0000 (GMT) Subject: Re: [PATCH] s390/console: enable dummy console for vt To: Geert Uytterhoeven References: <2324e2cc-ff55-4d57-2807-c7f72f9ea0ca@de.ibm.com> <20180215111423.96598-1-borntraeger@de.ibm.com> From: Christian Borntraeger Date: Thu, 15 Feb 2018 12:56:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18021511-0020-0000-0000-000003F5F019 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021511-0021-0000-0000-0000428882D3 Message-Id: <13a674d4-68d5-6fb4-5902-26c6b631b596@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-02-15_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802150149 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , Linux Fbdev development list , uml-devel , Bartlomiej Zolnierkiewicz , Richard Weinberger , Jeff Dike , Farhan Ali , Linux Kernel Mailing List , DRI Development , Stefan Kristiansson , Thomas Huth , Tomi Valkeinen , Martin Schwidefsky , Chen Liqin , Lennox Wu Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 02/15/2018 12:26 PM, Geert Uytterhoeven wrote: > Hi Christian, > > On Thu, Feb 15, 2018 at 12:14 PM, Christian Borntraeger > wrote: >> To enable the virtual terminal layer with virtio-gpu, we need to >> provide the dummy console. This console is hidden behind CONFIG_IOMEM >> via the graphics support. Instead of fully enabling the graphic >> drivers lets just provide a Kconfig option for the dummy console. >> >> Signed-off-by: Christian Borntraeger >> --- >> New version: instead of moving around the graphic and console stuff, >> let's just keep an s390 specific variant of CONFIG_DUMMY_CONSOLE >> arch/s390/Kconfig | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig >> index cbe1d978693a..a69690f616f3 100644 >> --- a/arch/s390/Kconfig >> +++ b/arch/s390/Kconfig >> @@ -952,6 +952,11 @@ config S390_HYPFS_FS >> >> source "arch/s390/kvm/Kconfig" >> >> +config DUMMY_CONSOLE >> + bool >> + depends on VT >> + default y >> + >> config S390_GUEST >> def_bool y >> prompt "s390 support for virtio devices" > > Really? > > You already have your own copy of HAS_IOMEM, which makes it hard for > people to track which one applies where. > I am open for better suggestions. One idea that I had was to reverse the logic in s390 (and use the common code HAS_IOMEM) like This would enable CONFIG_VT and also CONFIG_DUMMY_CONSOLE as long as PCI is enabled. If DUMMY_CONSOLE is not enabled (e.g. due to missing PCI), we get a crash in the VT layer as conswitchp is then null. Somewhat tricky. diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index cbe1d978693a..123dd593ea20 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -715,8 +715,8 @@ endif # PCI config PCI_DOMAINS def_bool PCI -config HAS_IOMEM - def_bool PCI +config NO_IOMEM + def_bool y if !PCI config IOMMU_HELPER def_bool PCI