diff mbox

[RESEND] drm/ttm: remove declaration of ttm_tt_cache_flush

Message ID 1400817487-27179-2-git-send-email-acourbot@nvidia.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alexandre Courbot May 23, 2014, 3:58 a.m. UTC 
ttm_tt_cache_flush's implementation was removed in 2009 by commit
c9c97b8c, but its declaration has been hiding in ttm_bo_driver.h since
then.

It has been surviving in the dark for too long now ; give it the mercy
blow.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
---
 include/drm/ttm/ttm_bo_driver.h | 12 ------------
 1 file changed, 12 deletions(-)

Comments

David Herrmann May 25, 2014, 12:05 p.m. UTC | #1 
Hi

On Fri, May 23, 2014 at 5:58 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> ttm_tt_cache_flush's implementation was removed in 2009 by commit
> c9c97b8c, but its declaration has been hiding in ttm_bo_driver.h since
> then.
>
> It has been surviving in the dark for too long now ; give it the mercy
> blow.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> ---
>  include/drm/ttm/ttm_bo_driver.h | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index a5183da3ef92..e3f8c99a8a9d 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -653,18 +653,6 @@ extern void ttm_tt_unbind(struct ttm_tt *ttm);
>  extern int ttm_tt_swapin(struct ttm_tt *ttm);
>
>  /**
> - * ttm_tt_cache_flush:
> - *
> - * @pages: An array of pointers to struct page:s to flush.
> - * @num_pages: Number of pages to flush.
> - *
> - * Flush the data of the indicated pages from the cpu caches.
> - * This is used when changing caching attributes of the pages from
> - * cache-coherent.
> - */
> -extern void ttm_tt_cache_flush(struct page *pages[], unsigned long num_pages);
> -
> -/**
>   * ttm_tt_set_placement_caching:
>   *
>   * @ttm A struct ttm_tt the backing pages of which will change caching policy.
> --
> 1.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
index a5183da3ef92..e3f8c99a8a9d 100644
--- a/include/drm/ttm/ttm_bo_driver.h
+++ b/include/drm/ttm/ttm_bo_driver.h
@@ -653,18 +653,6 @@  extern void ttm_tt_unbind(struct ttm_tt *ttm);
 extern int ttm_tt_swapin(struct ttm_tt *ttm);
 
 /**
- * ttm_tt_cache_flush:
- *
- * @pages: An array of pointers to struct page:s to flush.
- * @num_pages: Number of pages to flush.
- *
- * Flush the data of the indicated pages from the cpu caches.
- * This is used when changing caching attributes of the pages from
- * cache-coherent.
- */
-extern void ttm_tt_cache_flush(struct page *pages[], unsigned long num_pages);
-
-/**
  * ttm_tt_set_placement_caching:
  *
  * @ttm A struct ttm_tt the backing pages of which will change caching policy.