From patchwork Thu May 29 10:50:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 4263881 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 06875BF90B for ; Thu, 29 May 2014 10:51:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0AFFB2011B for ; Thu, 29 May 2014 10:51:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DF5F22010C for ; Thu, 29 May 2014 10:50:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63F4F6E2CA; Thu, 29 May 2014 03:50:57 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 02DB66E03E for ; Thu, 29 May 2014 03:50:55 -0700 (PDT) Received: by mail-we0-f179.google.com with SMTP id q59so182356wes.38 for ; Thu, 29 May 2014 03:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=Kt8lSHNGRDr908fpiN6zmsS0+CsOihS0JTwtFVeEjMg=; b=Rx57LRNvDJNrsnC52CC3bQCYUJUu/ur08PPhGt4ffoysLnNUBN6MiaYVr8HnR4oNNI KyEPufLW2N40Bes1LZLnhyHgN1BKXMgo57uOmKiWdBTYFWB4EoWhbNaalYi8V5YVH0vt hEwH2GhQc24WtqPaqCCqBtlWVWZa+k3xUdDvY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Kt8lSHNGRDr908fpiN6zmsS0+CsOihS0JTwtFVeEjMg=; b=baw8wBzNAqL89r0TT5F9PvOhfVxMJE+ePIs6ur6+g1lEo3MPJpKkIogxSYLNNmv8Z1 GsmzLEhb8kQPAtrN5Xhl/G7Om3geMX4OdBRIjeHA9lJxPKTqBqZdRt51a9kC95gvvk3C JcnxducJQoGO6DUy0+mekzArdUn1hfSH6y4FWs2lfePgVClNaesC3vx6UVyZlOpazXUl 1wkKNLP74Gw5aClKdSSnxypidpu6oJnzt28hVq3MV4AXf6eD+44X0atM/xkIsIAfU+wE mPVL99JPEylML+wF2TOqjGeSu+tL1y+WuAa+U7YwcMfPg5CC0ha+5iuG6sW89ZDkEQNi bing== X-Gm-Message-State: ALoCoQmqJrqvFjXYPnxu5rXk3t2BX7wf1NkNqGirtnQlKRUJgZT/xtaMWXTIJrmtC3DKvk9KBW1N X-Received: by 10.194.221.4 with SMTP id qa4mr9610321wjc.38.1401360654795; Thu, 29 May 2014 03:50:54 -0700 (PDT) Received: from phenom.ffwll.local (84-73-67-144.dclient.hispeed.ch. [84.73.67.144]) by mx.google.com with ESMTPSA id vc2sm830581wjc.2.2014.05.29.03.50.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 May 2014 03:50:53 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm: Don't export internal module variables Date: Thu, 29 May 2014 12:50:43 +0200 Message-Id: <1401360643-19363-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.9.2 Cc: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Drivers really have no business touching these. Noticed because exynose _did_ touch the vblank off delay, which could potentially affect other drivers. drm_debug is an exception since it's used in macros and inline functions. Cc: Inki Dae Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_stub.c | 12 ++++-------- drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 ---- drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 -- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 3727ac8bc310..3901b41c214b 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -42,18 +42,14 @@ unsigned int drm_debug = 0; /* 1 to enable debug output */ EXPORT_SYMBOL(drm_debug); -unsigned int drm_rnodes = 0; /* 1 to enable experimental render nodes API */ -EXPORT_SYMBOL(drm_rnodes); +int drm_rnodes = 0; /* 1 to enable experimental render nodes API */ /* 1 to allow user space to request universal planes (experimental) */ -unsigned int drm_universal_planes = 0; -EXPORT_SYMBOL(drm_universal_planes); +int drm_universal_planes = 0; -unsigned int drm_vblank_offdelay = 5000; /* Default to 5000 msecs. */ -EXPORT_SYMBOL(drm_vblank_offdelay); +int drm_vblank_offdelay = 5000; /* Default to 5000 msecs. */ -unsigned int drm_timestamp_precision = 20; /* Default to 20 usecs. */ -EXPORT_SYMBOL(drm_timestamp_precision); +int drm_timestamp_precision = 20; /* Default to 20 usecs. */ /* * Default to use monotonic timestamps for wait-for-vblank and page-flip diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 2d27ba23a6a8..d7c50b0da510 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -38,8 +38,6 @@ #define DRIVER_MAJOR 1 #define DRIVER_MINOR 0 -#define VBLANK_OFF_DELAY 50000 - /* platform device pointer for eynos drm device. */ static struct platform_device *exynos_drm_pdev; @@ -109,8 +107,6 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags) /* setup possible_clones. */ exynos_drm_encoder_setup(dev); - drm_vblank_offdelay = VBLANK_OFF_DELAY; - platform_set_drvdata(dev->platformdev, dev); /* force connectors detection */ diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index ce3e6a30deaa..e28f792d628c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -40,8 +40,6 @@ struct drm_device; struct exynos_drm_overlay; struct drm_connector; -extern unsigned int drm_vblank_offdelay; - /* this enumerates display type. */ enum exynos_drm_output_type { EXYNOS_DISPLAY_TYPE_NONE,