From patchwork Wed Jun 18 11:34:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 4379901 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 838DE9F314 for ; Wed, 18 Jun 2014 23:41:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BACA8200F3 for ; Wed, 18 Jun 2014 23:41:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id E495A20034 for ; Wed, 18 Jun 2014 23:41:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22599A535; Wed, 18 Jun 2014 16:41:13 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BCEE6E464 for ; Wed, 18 Jun 2014 04:37:38 -0700 (PDT) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7D00FLE4APEG20@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 18 Jun 2014 20:37:37 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.125]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id E6.BE.13369.10A71A35; Wed, 18 Jun 2014 20:37:37 +0900 (KST) X-AuditID: cbfee690-b7fb56d000003439-13-53a17a012ff6 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id C9.11.08203.10A71A35; Wed, 18 Jun 2014 20:37:37 +0900 (KST) Received: from localhost.localdomain ([107.108.83.245]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N7D00KA047K8A70@mmp1.samsung.com>; Wed, 18 Jun 2014 20:37:37 +0900 (KST) From: Rahul Sharma To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/5] drm/exynos: stop mixer before gating clocks during poweroff Date: Wed, 18 Jun 2014 17:04:50 +0530 Message-id: <1403091293-15058-3-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1403091293-15058-1-git-send-email-rahul.sharma@samsung.com> References: <1403091293-15058-1-git-send-email-rahul.sharma@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsWyRsSkVpexamGwwfsOMYsrX9+zWUy6P4HF 4vuuL+wWvQuuslnMOL+PyWLhi3iLKYsOszqwe+ycdZfd4373cSaPvi2rGD0+b5ILYInisklJ zcksSy3St0vgyvjdvJa94CNfxe0Z81gaGA/ydDFyckgImEjsfLOJBcIWk7hwbz1bFyMXh5DA UkaJ/TPOM8MUdUx7zAiRWMQocb73EzOE084kselAA1gVm4CuxOyDzxhBbBEBZYm/E1eBdTAL LGeUeLm5hQ0kISwQIHGycQVYEYuAqsSV1w/B4rwCHhL3/75g6mLkAFqnIDFnkg1ImFPAU2L2 k+tg84WASt7Pn8gCMlNCYDq7xIQnO9gg5ghIfJt8iAWiVxboIKirJSUOrrjBMoFReAEjwypG 0dSC5ILipPQiE73ixNzi0rx0veT83E2MwOA+/e/ZhB2M9w5YH2JMBho3kVlKNDkfGB15JfGG xmZGFqYmpsZG5pZmpAkrifOqPUoKEhJITyxJzU5NLUgtii8qzUktPsTIxMEp1cAYdaD/0K/T /v7+Oybv4G11/lzCWnv9gj/rFtYPuUXtIQ9PmoowXC7x2zjdIthjOfumyCsZTxc3nRFb5y/M ciH3rObUdzZvNt8qq0+cPeOlyBlt8Zyn/2ozfDKLzXMOb7ujIB6iHryuNbBTgpHH36HH4Wp0 IrPsrmPz3xsHpzKfWvz421bVp1+UWIozEg21mIuKEwEQsLpshAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jAV3GqoXBBtNX8Vlc+fqezWLS/Qks Ft93fWG36F1wlc1ixvl9TBYLX8RbTFl0mNWB3WPnrLvsHve7jzN59G1ZxejxeZNcAEtUA6NN RmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtAFSgpliTml QKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaM381r2Qs+8lXcnjGPpYHxIE8XIyeH hICJRMe0x4wQtpjEhXvr2boYuTiEBBYxSpzv/cQM4bQzSWw60MAMUsUmoCsx++AzsA4RAWWJ vxNXMYIUMQssZ5R4ubmFDSQhLBAgcbJxBVgRi4CqxJXXD8HivAIeEvf/vmDqYuQAWqcgMWeS DUiYU8BTYvaT62DzhYBK3s+fyDKBkXcBI8MqRtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjODY eSa1g3Flg8UhRgEORiUeXo7cBcFCrIllxZW5hxglOJiVRHiPFS8MFuJNSaysSi3Kjy8qzUkt PsSYDHTURGYp0eR8YFznlcQbGpuYmxqbWppYmJhZkiasJM57oNU6UEggPbEkNTs1tSC1CGYL EwenVAPjyvOLwn5f7tSdo3Rkc0LZHJ0DTE+1j0Q6vm3ccXjjsTB+G9kJn44LvdLe5Lygo9t2 xd+nX6LiRBem8zCob7nic1D0weFpbj6n3huFMnOlL19xsXfTm5ULuCsMr3/V95Xf0mNm+Hwi q2zah2/aWVck+Q8Wq9xZLWN0padexX6lwvpL1b0N/501lFiKMxINtZiLihMB4JnUuOECAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 18 Jun 2014 16:40:54 -0700 Cc: kgene.kim@samsung.com, joshi@samsung.com, linux-samsung-soc@vger.kernel.org, Rahul Sharma X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Mixer should be power gated only after it is gracefully stopped. The recommended sequence is to Stop the mixer and wait till it enters to IDLE state before gating the clocks and power to the mixer. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 15 +++++++++++++++ drivers/gpu/drm/exynos/regs-mixer.h | 1 + 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index c00abbe..d359501 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -377,6 +377,20 @@ static void mixer_run(struct mixer_context *ctx) mixer_regs_dump(ctx); } +static void mixer_stop(struct mixer_context *ctx) +{ + struct mixer_resources *res = &ctx->mixer_res; + int timeout = 20; + + mixer_reg_writemask(res, MXR_STATUS, 0, MXR_STATUS_REG_RUN); + + while (!(mixer_reg_read(res, MXR_STATUS) & MXR_STATUS_REG_IDLE) && + --timeout) + usleep_range(10000, 12000); + + mixer_regs_dump(ctx); +} + static void vp_video_buffer(struct mixer_context *ctx, int win) { struct mixer_resources *res = &ctx->mixer_res; @@ -1094,6 +1108,7 @@ static void mixer_poweroff(struct exynos_drm_manager *mgr) } mutex_unlock(&ctx->mixer_mutex); + mixer_stop(ctx); mixer_window_suspend(mgr); ctx->int_en = mixer_reg_read(res, MXR_INT_EN); diff --git a/drivers/gpu/drm/exynos/regs-mixer.h b/drivers/gpu/drm/exynos/regs-mixer.h index 4537026..5f32e1a 100644 --- a/drivers/gpu/drm/exynos/regs-mixer.h +++ b/drivers/gpu/drm/exynos/regs-mixer.h @@ -78,6 +78,7 @@ #define MXR_STATUS_BIG_ENDIAN (1 << 3) #define MXR_STATUS_ENDIAN_MASK (1 << 3) #define MXR_STATUS_SYNC_ENABLE (1 << 2) +#define MXR_STATUS_REG_IDLE (1 << 1) #define MXR_STATUS_REG_RUN (1 << 0) /* bits for MXR_CFG */