From patchwork Wed Jun 18 11:34:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 4379861 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CFBB89F433 for ; Wed, 18 Jun 2014 23:41:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E198320394 for ; Wed, 18 Jun 2014 23:41:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id F310C20384 for ; Wed, 18 Jun 2014 23:41:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5FC6A52C; Wed, 18 Jun 2014 16:41:00 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C1736E464 for ; Wed, 18 Jun 2014 04:38:03 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7D00DUM4BE8G70@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 18 Jun 2014 20:38:02 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id C1.84.24374.A1A71A35; Wed, 18 Jun 2014 20:38:02 +0900 (KST) X-AuditID: cbfee68d-b7fd46d000005f36-d1-53a17a1aa0c7 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 61.21.08203.91A71A35; Wed, 18 Jun 2014 20:38:02 +0900 (KST) Received: from localhost.localdomain ([107.108.83.245]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N7D00KA047K8A70@mmp1.samsung.com>; Wed, 18 Jun 2014 20:38:01 +0900 (KST) From: Rahul Sharma To: dri-devel@lists.freedesktop.org Subject: [PATCH 3/5] drm/exynos: allow mulitple layer updates per vsync for mixer Date: Wed, 18 Jun 2014 17:04:51 +0530 Message-id: <1403091293-15058-4-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1403091293-15058-1-git-send-email-rahul.sharma@samsung.com> References: <1403091293-15058-1-git-send-email-rahul.sharma@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsWyRsSkTleqamGwwbf5XBZXvr5ns5h0fwKL xfddX9gtehdcZbOYcX4fk8XCF/EWUxYdZnVg99g56y67x/3u40wefVtWMXp83iQXwBLFZZOS mpNZllqkb5fAlXHlWgNbQRNnxapZj5kaGM+zdzFyckgImEgsmj+PBcIWk7hwbz1bFyMXh5DA UkaJBRsus8AUTX21nB0isYhR4t7zHqiqdiaJWZsmMYNUsQnoSsw++IwRxBYRUJb4O3EVI0gR s8ByRomXm1vYQBLCAsESH9ZsB9vNIqAqcerYfLBmXgEPicY7b1i7GDmA1ilIzJlkAxLmFPCU mP3kOliJEFDJ+/kTWUBmSghMZpdonnuMEWKOgMS3yYdYIHplJTYdYIa4WlLi4IobLBMYhRcw MqxiFE0tSC4oTkovMtQrTswtLs1L10vOz93ECAzu0/+e9e5gvH3A+hBjMtC4icxSosn5wOjI K4k3NDYzsjA1MTU2Mrc0I01YSZw36WFSkJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQZGXfls K8UAp9uzp6WYx2tzfO/Y4s34M/5j8f7bgoLuEffady9O+JNcNs/9rJG56fFDhxSWJLVenf/m ROSnq80lL1fd3f5NesOTK41bFyVe5bTaVSS7dLn+xCMrKoVy2g4wMyU/nTdlX/lUmdbDT71k Nuw/pVx10Cp908SPC5KNJzed2igqr/ZKXYmlOCPRUIu5qDgRAGaXKIWEAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jAV2pqoXBBhuPM1pc+fqezWLS/Qks Ft93fWG36F1wlc1ixvl9TBYLX8RbTFl0mNWB3WPnrLvsHve7jzN59G1ZxejxeZNcAEtUA6NN RmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtAFSgpliTml QKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaMK9ca2AqaOCtWzXrM1MB4nr2LkZND QsBEYuqr5VC2mMSFe+vZuhi5OIQEFjFK3HveA+W0M0nM2jSJGaSKTUBXYvbBZ4wgtoiAssTf iasYQYqYBZYzSrzc3MIGkhAWCJb4sGY72FgWAVWJU8fmgzXzCnhINN55w9rFyAG0TkFiziQb kDCngKfE7CfXwUqEgErez5/IMoGRdwEjwypG0dSC5ILipPRcQ73ixNzi0rx0veT83E2M4Nh5 JrWDcWWDxSFGAQ5GJR5ejtwFwUKsiWXFlbmHGCU4mJVEeI8VLwwW4k1JrKxKLcqPLyrNSS0+ xJgMdNREZinR5HxgXOeVxBsam5ibGptamliYmFmSJqwkznug1TpQSCA9sSQ1OzW1ILUIZgsT B6dUA6PQiTfuWy+6Tnm2PDuJc2lS4OG9ad5CF+cetnA2bFVvFpAUFlb/auTGG5v1S3i37b6D QabblvpuMe8/5JP4q2p2NeejnlXSgQc9tgS5tr62sue7+sTA4mRkQcG7apNn4kwFRz5OjFib YrvLqjPKzjdN796TUwXb9/If6tJasXN+eVnsS27VOUosxRmJhlrMRcWJACp/EePhAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 18 Jun 2014 16:40:54 -0700 Cc: kgene.kim@samsung.com, joshi@samsung.com, linux-samsung-soc@vger.kernel.org, Rahul Sharma X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Allowing only one layer update per vsync can cause issues while there are update available for both layers. There is a good amount of possibility to loose updates if we allow single update per vsync. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index d359501..6773b03 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -511,13 +511,8 @@ static void vp_video_buffer(struct mixer_context *ctx, int win) static void mixer_layer_update(struct mixer_context *ctx) { struct mixer_resources *res = &ctx->mixer_res; - u32 val; - - val = mixer_reg_read(res, MXR_CFG); - /* allow one update per vsync only */ - if (!(val & MXR_CFG_LAYER_UPDATE_COUNT_MASK)) - mixer_reg_writemask(res, MXR_CFG, ~0, MXR_CFG_LAYER_UPDATE); + mixer_reg_writemask(res, MXR_CFG, ~0, MXR_CFG_LAYER_UPDATE); } static void mixer_graph_buffer(struct mixer_context *ctx, int win)