From patchwork Wed Jun 18 11:34:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 4379891 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 27E829F314 for ; Wed, 18 Jun 2014 23:41:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 62B4B200F3 for ; Wed, 18 Jun 2014 23:41:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9774B20034 for ; Wed, 18 Jun 2014 23:41:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D4EFAA52B; Wed, 18 Jun 2014 16:41:09 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id C6E306E1D9 for ; Wed, 18 Jun 2014 04:38:54 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7D00J7O4CTRT00@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 18 Jun 2014 20:38:53 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.125]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id EA.B4.24374.D4A71A35; Wed, 18 Jun 2014 20:38:53 +0900 (KST) X-AuditID: cbfee68d-b7fd46d000005f36-6a-53a17a4d5bec Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 2B.31.08203.D4A71A35; Wed, 18 Jun 2014 20:38:53 +0900 (KST) Received: from localhost.localdomain ([107.108.83.245]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N7D00KA047K8A70@mmp1.samsung.com>; Wed, 18 Jun 2014 20:38:52 +0900 (KST) From: Rahul Sharma To: dri-devel@lists.freedesktop.org Subject: [PATCH 5/5] drm/exynos: enable vsync interrupt while waiting for vblank Date: Wed, 18 Jun 2014 17:04:53 +0530 Message-id: <1403091293-15058-6-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1403091293-15058-1-git-send-email-rahul.sharma@samsung.com> References: <1403091293-15058-1-git-send-email-rahul.sharma@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPLMWRmVeSWpSXmKPExsWyRsSkVte3amGwwZO/fBZXvr5ns5h0fwKL xfddX9gtehdcZbOYcX4fk8XCF/EWUxYdZnVg99g56y67x/3u40wefVtWMXp83iQXwBLFZZOS mpNZllqkb5fAlTH9hk7BG46KN8emMTYwHmTvYuTkkBAwkfi86hqULSZx4d56ti5GLg4hgaWM EveeX2KBKbrVPo8NxBYSWMQosWp1DERRO5PEtb7fYEVsAroSsw8+YwSxRQSUJf5OXMUIUsQs sJxR4uXmFrBuYYEAicknNoGtYxFQlVg1YzlYM6+Ah8TLi1+BbA6gbQoScybZgIQ5BTwlZj+5 zgyx2EPi/fyJLCAzJQQms0v8/vieBWKOgMS3yYegemUlNh1ghjhaUuLgihssExiFFzAyrGIU TS1ILihOSi8y1CtOzC0uzUvXS87P3cQIDOzT/5717mC8fcD6EGMy0LiJzFKiyfnAyMgriTc0 NjOyMDUxNTYytzQjTVhJnDfpYVKQkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBsYcA8+wbim5 1tbakq1yAYaJQmXl7Yab5J8qLPm0x0fi++5MpZjHLRUV4VrMM/t+zFPm50m+OjXnx73ZrkxR hifPfpJ6W5Z59oioQsmrg5v53HYJp7Cc4L8vkPepc/OREEvnv7l7Gh9+XXpJR6fNxMi0hOu/ RJBdfuvehf/fu4uJcm61vGnUosRSnJFoqMVcVJwIADVAnhOCAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t9jAV3fqoXBBo2X2S2ufH3PZjHp/gQW i++7vrBb9C64ymYx4/w+JouFL+Itpiw6zOrA7rFz1l12j/vdx5k8+rasYvT4vEkugCWqgdEm IzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+gCJYWyxJxS oFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWPG9Bs6BW84Kt4cm8bYwHiQvYuRk0NC wETiVvs8NghbTOLCvfVgtpDAIkaJVatjuhi5gOx2Jolrfb9ZQBJsAroSsw8+YwSxRQSUJf5O XMUIUsQssJxR4uXmFrBuYYEAicknNoFtYBFQlVg1YzlYM6+Ah8TLi1+BbA6gbQoScybZgIQ5 BTwlZj+5zgyx2EPi/fyJLBMYeRcwMqxiFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECI6bZ1I7 GFc2WBxiFOBgVOLh5chdECzEmlhWXJl7iFGCg1lJhPdY8cJgId6UxMqq1KL8+KLSnNTiQ4zJ QEdNZJYSTc4HxnReSbyhsYm5qbGppYmFiZklacJK4rwHWq0DhQTSE0tSs1NTC1KLYLYwcXBK NTDKX5D/tCVjqXLRxLp1upV6r8+t+W7u6v1py2yBmEc/eOuMJI3/L9g6ga2pd4PKusKn75SW XPnZY7KolD3/3Ywt0v+/9aflLGb/OfltMZdUcOfFiTNaHhz5f+T1cUPj62vPLFn0xfZ9m53h VI5z97UvbAnyTHvUylibZnv4W6lJru6upe8vJNapK7EUZyQaajEXFScCAN9dqHPfAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 18 Jun 2014 16:40:54 -0700 Cc: kgene.kim@samsung.com, joshi@samsung.com, linux-samsung-soc@vger.kernel.org, Rahul Sharma X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP mixer_wait_for_vblank function expects that the upcoming vsync interrupt handler routine will clear the wait_vsync_event atomic variable. For this to happen, interrupts should be enabled and disabled properly. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 6f18581..7927f2e 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -1019,6 +1019,8 @@ static void mixer_wait_for_vblank(struct exynos_drm_manager *mgr) } mutex_unlock(&mixer_ctx->mixer_mutex); + mixer_enable_vblank(mgr); + atomic_set(&mixer_ctx->wait_vsync_event, 1); /* @@ -1029,6 +1031,8 @@ static void mixer_wait_for_vblank(struct exynos_drm_manager *mgr) !atomic_read(&mixer_ctx->wait_vsync_event), HZ/20)) DRM_DEBUG_KMS("vblank wait timed out.\n"); + + mixer_disable_vblank(mgr); } static void mixer_window_suspend(struct exynos_drm_manager *mgr)