Message ID | 1404771009-30657-1-git-send-email-alexander.deucher@amd.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi On Tue, Jul 8, 2014 at 12:10 AM, Alex Deucher <alexdeucher@gmail.com> wrote: > Render nodes are ready to leave the experimental state so > drop the kernel command line parameter which was hiding them > by default. I swore we had already enabled these by default, > that appears to not be the case. > > v2: remove rnodes parameter description > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> For completeness: You still missed the line in drmP.h. I have it queued in my -next branch [1]. Thanks David [1] http://cgit.freedesktop.org/~dvdhrm/linux/commit/?h=drm-next&id=c006394362a28e4949046cd0ce1fbc568e914861 > --- > drivers/gpu/drm/drm_stub.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c > index 14d1646..07bf701 100644 > --- a/drivers/gpu/drm/drm_stub.c > +++ b/drivers/gpu/drm/drm_stub.c > @@ -37,9 +37,6 @@ > unsigned int drm_debug = 0; /* 1 to enable debug output */ > EXPORT_SYMBOL(drm_debug); > > -unsigned int drm_rnodes = 0; /* 1 to enable experimental render nodes API */ > -EXPORT_SYMBOL(drm_rnodes); > - > /* 1 to allow user space to request universal planes (experimental) */ > unsigned int drm_universal_planes = 0; > EXPORT_SYMBOL(drm_universal_planes); > @@ -60,13 +57,11 @@ MODULE_AUTHOR(CORE_AUTHOR); > MODULE_DESCRIPTION(CORE_DESC); > MODULE_LICENSE("GPL and additional rights"); > MODULE_PARM_DESC(debug, "Enable debug output"); > -MODULE_PARM_DESC(rnodes, "Enable experimental render nodes API"); > MODULE_PARM_DESC(vblankoffdelay, "Delay until vblank irq auto-disable [msecs]"); > MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]"); > MODULE_PARM_DESC(timestamp_monotonic, "Use monotonic timestamps"); > > module_param_named(debug, drm_debug, int, 0600); > -module_param_named(rnodes, drm_rnodes, int, 0600); > module_param_named(universal_planes, drm_universal_planes, int, 0600); > module_param_named(vblankoffdelay, drm_vblank_offdelay, int, 0600); > module_param_named(timestamp_precision_usec, drm_timestamp_precision, int, 0600); > @@ -588,7 +583,7 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver, > goto err_minors; > } > > - if (drm_core_check_feature(dev, DRIVER_RENDER) && drm_rnodes) { > + if (drm_core_check_feature(dev, DRIVER_RENDER)) { > ret = drm_minor_alloc(dev, DRM_MINOR_RENDER); > if (ret) > goto err_minors; > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Jul 7, 2014 at 6:20 PM, David Herrmann <dh.herrmann@gmail.com> wrote: > Hi > > On Tue, Jul 8, 2014 at 12:10 AM, Alex Deucher <alexdeucher@gmail.com> wrote: >> Render nodes are ready to leave the experimental state so >> drop the kernel command line parameter which was hiding them >> by default. I swore we had already enabled these by default, >> that appears to not be the case. >> >> v2: remove rnodes parameter description >> >> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> > > For completeness: > You still missed the line in drmP.h. I have it queued in my -next branch [1]. > Thanks! Feel free to add my Acked-by. Alex > Thanks > David > > [1] http://cgit.freedesktop.org/~dvdhrm/linux/commit/?h=drm-next&id=c006394362a28e4949046cd0ce1fbc568e914861 > >> --- >> drivers/gpu/drm/drm_stub.c | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c >> index 14d1646..07bf701 100644 >> --- a/drivers/gpu/drm/drm_stub.c >> +++ b/drivers/gpu/drm/drm_stub.c >> @@ -37,9 +37,6 @@ >> unsigned int drm_debug = 0; /* 1 to enable debug output */ >> EXPORT_SYMBOL(drm_debug); >> >> -unsigned int drm_rnodes = 0; /* 1 to enable experimental render nodes API */ >> -EXPORT_SYMBOL(drm_rnodes); >> - >> /* 1 to allow user space to request universal planes (experimental) */ >> unsigned int drm_universal_planes = 0; >> EXPORT_SYMBOL(drm_universal_planes); >> @@ -60,13 +57,11 @@ MODULE_AUTHOR(CORE_AUTHOR); >> MODULE_DESCRIPTION(CORE_DESC); >> MODULE_LICENSE("GPL and additional rights"); >> MODULE_PARM_DESC(debug, "Enable debug output"); >> -MODULE_PARM_DESC(rnodes, "Enable experimental render nodes API"); >> MODULE_PARM_DESC(vblankoffdelay, "Delay until vblank irq auto-disable [msecs]"); >> MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]"); >> MODULE_PARM_DESC(timestamp_monotonic, "Use monotonic timestamps"); >> >> module_param_named(debug, drm_debug, int, 0600); >> -module_param_named(rnodes, drm_rnodes, int, 0600); >> module_param_named(universal_planes, drm_universal_planes, int, 0600); >> module_param_named(vblankoffdelay, drm_vblank_offdelay, int, 0600); >> module_param_named(timestamp_precision_usec, drm_timestamp_precision, int, 0600); >> @@ -588,7 +583,7 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver, >> goto err_minors; >> } >> >> - if (drm_core_check_feature(dev, DRIVER_RENDER) && drm_rnodes) { >> + if (drm_core_check_feature(dev, DRIVER_RENDER)) { >> ret = drm_minor_alloc(dev, DRM_MINOR_RENDER); >> if (ret) >> goto err_minors; >> -- >> 1.8.3.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi On Tue, Jul 8, 2014 at 12:28 AM, Alex Deucher <alexdeucher@gmail.com> wrote: > On Mon, Jul 7, 2014 at 6:20 PM, David Herrmann <dh.herrmann@gmail.com> wrote: >> Hi >> >> On Tue, Jul 8, 2014 at 12:10 AM, Alex Deucher <alexdeucher@gmail.com> wrote: >>> Render nodes are ready to leave the experimental state so >>> drop the kernel command line parameter which was hiding them >>> by default. I swore we had already enabled these by default, >>> that appears to not be the case. >>> >>> v2: remove rnodes parameter description >>> >>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> >> >> For completeness: >> You still missed the line in drmP.h. I have it queued in my -next branch [1]. >> > > Thanks! Feel free to add my Acked-by. Added! Thanks! David
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 14d1646..07bf701 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -37,9 +37,6 @@ unsigned int drm_debug = 0; /* 1 to enable debug output */ EXPORT_SYMBOL(drm_debug); -unsigned int drm_rnodes = 0; /* 1 to enable experimental render nodes API */ -EXPORT_SYMBOL(drm_rnodes); - /* 1 to allow user space to request universal planes (experimental) */ unsigned int drm_universal_planes = 0; EXPORT_SYMBOL(drm_universal_planes); @@ -60,13 +57,11 @@ MODULE_AUTHOR(CORE_AUTHOR); MODULE_DESCRIPTION(CORE_DESC); MODULE_LICENSE("GPL and additional rights"); MODULE_PARM_DESC(debug, "Enable debug output"); -MODULE_PARM_DESC(rnodes, "Enable experimental render nodes API"); MODULE_PARM_DESC(vblankoffdelay, "Delay until vblank irq auto-disable [msecs]"); MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]"); MODULE_PARM_DESC(timestamp_monotonic, "Use monotonic timestamps"); module_param_named(debug, drm_debug, int, 0600); -module_param_named(rnodes, drm_rnodes, int, 0600); module_param_named(universal_planes, drm_universal_planes, int, 0600); module_param_named(vblankoffdelay, drm_vblank_offdelay, int, 0600); module_param_named(timestamp_precision_usec, drm_timestamp_precision, int, 0600); @@ -588,7 +583,7 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver, goto err_minors; } - if (drm_core_check_feature(dev, DRIVER_RENDER) && drm_rnodes) { + if (drm_core_check_feature(dev, DRIVER_RENDER)) { ret = drm_minor_alloc(dev, DRM_MINOR_RENDER); if (ret) goto err_minors;
Render nodes are ready to leave the experimental state so drop the kernel command line parameter which was hiding them by default. I swore we had already enabled these by default, that appears to not be the case. v2: remove rnodes parameter description Signed-off-by: Alex Deucher <alexander.deucher@amd.com> --- drivers/gpu/drm/drm_stub.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)