From patchwork Mon Jul 21 11:24:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 4594391 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id ADFD59F295 for ; Mon, 21 Jul 2014 11:24:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EA32B2012D for ; Mon, 21 Jul 2014 11:24:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 2677820127 for ; Mon, 21 Jul 2014 11:24:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EBD46E34A; Mon, 21 Jul 2014 04:24:41 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EB546E34A for ; Mon, 21 Jul 2014 04:24:39 -0700 (PDT) Received: by mail-wg0-f44.google.com with SMTP id m15so6234752wgh.27 for ; Mon, 21 Jul 2014 04:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=zHPluKvVACyNEVoZChBKO4gIOcTM6Jcj1dgX9U+Jsxo=; b=B5hi4vQr+8xnlp/3manwzAbN7P6bxPsGn3T5tlbv97eOgf+ABreI5hIj2H5HBIsI4R CQAl1BY1ETlPOF0ArAROq22CURri3EWso16bSr1PwVIliidh1Eh+uWM8F/s5+G6ERHhF AxPEMSLIqi3Pe1LoNTIbJko7VhqCMM5O/KrnBaRYzCLtRLh03zUJTg05HP9Zg0LzpSVA n3NvWjsqKYuNAQxkJuHp5nok0p2CRLwcuMtCSTZzFOsU5TJ0taG6yNzyLyftxOC/QWbC /tWgErHpq2Ool2JYCo8CpJroeOZOOnkAieEMhs0yC9w05AcnVC/4zZMHW3orl6hTnOrZ fMXA== X-Received: by 10.180.9.71 with SMTP id x7mr3267853wia.61.1405941878747; Mon, 21 Jul 2014 04:24:38 -0700 (PDT) Received: from localhost (port-11394.pppoe.wtnet.de. [84.46.44.174]) by mx.google.com with ESMTPSA id fs3sm40920007wic.20.2014.07.21.04.24.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jul 2014 04:24:38 -0700 (PDT) From: Thierry Reding To: David Airlie Subject: [PATCH] drm: Add missing __user annotation Date: Mon, 21 Jul 2014 13:24:37 +0200 Message-Id: <1405941877-27708-1-git-send-email-thierry.reding@gmail.com> X-Mailer: git-send-email 2.0.1 Cc: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding The drm_copy_field() function copies strings into userspace buffers, so the first parameter needs to have a __user annotation to avoid warnings from the sparse checker. Signed-off-by: Thierry Reding Reviewed-by: David Herrmann --- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 8218078b6133..0cc182745e31 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -233,7 +233,7 @@ module_exit(drm_core_exit); /** * Copy and IOCTL return string to user space */ -static int drm_copy_field(char *buf, size_t *buf_len, const char *value) +static int drm_copy_field(char __user *buf, size_t *buf_len, const char *value) { int len;