From patchwork Thu Jul 31 17:42:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Kumar X-Patchwork-Id: 4659801 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B09A4C033C for ; Fri, 1 Aug 2014 01:05:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 738D22015E for ; Fri, 1 Aug 2014 01:05:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3A073201BB for ; Fri, 1 Aug 2014 01:05:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B1416E6DD; Thu, 31 Jul 2014 18:05:12 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D9826E6A6 for ; Thu, 31 Jul 2014 10:45:49 -0700 (PDT) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N9L00JM480CHPB0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 01 Aug 2014 02:45:48 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.124]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 06.39.14752.CC08AD35; Fri, 01 Aug 2014 02:45:48 +0900 (KST) X-AuditID: cbfee68f-b7fa26d0000039a0-ea-53da80cc425b Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 61.3E.05196.CC08AD35; Fri, 01 Aug 2014 02:45:48 +0900 (KST) Received: from chromebld-server.sisodomain.com ([107.108.73.106]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N9L00GWZ7ZJ9070@mmp1.samsung.com>; Fri, 01 Aug 2014 02:45:48 +0900 (KST) From: Ajay Kumar To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, thierry.reding@gmail.com Subject: [PATCH 09/15] drm/panel: ld9040: Add proper definition for prepare and unprepare Date: Thu, 31 Jul 2014 23:12:08 +0530 Message-id: <1406828534-10072-10-git-send-email-ajaykumar.rs@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1406828534-10072-1-git-send-email-ajaykumar.rs@samsung.com> References: <1406828534-10072-1-git-send-email-ajaykumar.rs@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgkeLIzCtJLcpLzFFi42JZI2JSo3um4VawwdMHchYH3h9ksdjwZiGz xfwj51gtrnx9z2Yx6f4EFovLCy+xWnzf9YXdYsb5fUwWqw5vYLeYezDX4ueueSwO3B47Z91l 91iwqdTjfvdxJo++LasYPT5vkgtgjeKySUnNySxLLdK3S+DKOPztFnPBI56KdZ0HWBsY93F1 MXJySAiYSDx9uo8dwhaTuHBvPVsXIxeHkMBSRonpO5YxwxTNWfOVCSKxiFFi3ZVOFghnApPE vxMnWECq2AS0JbZNvwlmiwjUSexffp8RpIhZYC2jxNN5k8ESwgLREk37WxlBbBYBVYlvkzvY QGxeAU+JbdcmA93BAbROQWLOJBuQMCdQeGrvZbCwkICHxLPjaSAjJQS2sUs8OniDHWKMANCY QywQrbISmw5AHS0pcXDFDZYJjMILGBlWMYqmFiQXFCelFxnrFSfmFpfmpesl5+duYgTGwul/ z/p3MN49YH2IMRlo3ERmKdHkfGAs5ZXEGxqbGVmYmpgaG5lbmpEmrCTOe/9hUpCQQHpiSWp2 ampBalF8UWlOavEhRiYOTqkGxhXpOed2pp+13rr2akta19Q760IXymb/ytry/prIpQeLvr2N rO8LEcvXzPhiF+aiUXmteOqHGuMVFmcPpffVxpjcnxn75peFlUki19HNTLGrQl8oLuE8djJ4 /UbVbzsLbtl/07pjuH7SpCssK6+5qj0Vq2vo9w8V3P71QONvnuDcU3dsNBp331ZiKc5INNRi LipOBABwpz+omwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t9jAd0zDbeCDQ5Pk7A48P4gi8WGNwuZ LeYfOcdqceXrezaLSfcnsFhcXniJ1eL7ri/sFjPO72OyWHV4A7vF3IO5Fj93zWNx4PbYOesu u8eCTaUe97uPM3n0bVnF6PF5k1wAa1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6h pYW5kkJeYm6qrZKLT4CuW2YO0GVKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQ QMIaxozD324xFzziqVjXeYC1gXEfVxcjJ4eEgInEnDVfmSBsMYkL99azdTFycQgJLGKUWHel kwXCmcAk8e/ECRaQKjYBbYlt02+C2SICdRL7l99nBCliFljLKPF03mSwhLBAtETT/lZGEJtF QFXi2+QONhCbV8BTYtu1yexdjBxA6xQk5kyyAQlzAoWn9l4GCwsJeEg8O542gZF3ASPDKkbR 1ILkguKk9FwjveLE3OLSvHS95PzcTYzgSHsmvYNxVYPFIUYBDkYlHl6H0FvBQqyJZcWVuYcY JTiYlUR4XcqBQrwpiZVVqUX58UWlOanFhxhNgW6ayCwlmpwPTAJ5JfGGxibmpsamliYWJmaW SuK8B1utA4UE0hNLUrNTUwtSi2D6mDg4pRoYLU41xc28k7y1b6tSwIdLZzT23+39IOT5nHH/ idrYLVUWE4VvPZtrv/nqcq5tzFIJy/MlZBdsOnRvE/+O1j1/d7w70VbsrPI9K/fy+5Cd6rUN 96wYzx/IFVn695laX3oAw6efvnX2jjp/57dbfnN9zb7gR/KSRcsyb5ft9Hq/ubKYIyWuQ+rt XiWW4oxEQy3mouJEAN5u/lzKAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Thu, 31 Jul 2014 18:05:11 -0700 Cc: seanpaul@google.com, joshi@samsung.com, ajaynumb@gmail.com, prashanth.g@samsung.com, Ajay Kumar X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move out code from enable and disable routines to prepare and unprepare routines, so that functionality is properly distributed across all the panel functions. Signed-off-by: Ajay Kumar --- drivers/gpu/drm/panel/panel-ld9040.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c index 9b40bd05..c6aa7f7 100644 --- a/drivers/gpu/drm/panel/panel-ld9040.c +++ b/drivers/gpu/drm/panel/panel-ld9040.c @@ -216,6 +216,11 @@ static int ld9040_power_off(struct ld9040 *ctx) static int ld9040_disable(struct drm_panel *panel) { + return 0; +} + +static int ld9040_unprepare(struct drm_panel *panel) +{ struct ld9040 *ctx = panel_to_ld9040(panel); msleep(120); @@ -228,18 +233,8 @@ static int ld9040_disable(struct drm_panel *panel) return ld9040_power_off(ctx); } -static int ld9040_unprepare(struct drm_panel *panel) -{ - return 0; -} - static int ld9040_prepare(struct drm_panel *panel) { - return 0; -} - -static int ld9040_enable(struct drm_panel *panel) -{ struct ld9040 *ctx = panel_to_ld9040(panel); int ret; @@ -252,11 +247,16 @@ static int ld9040_enable(struct drm_panel *panel) ret = ld9040_clear_error(ctx); if (ret < 0) - ld9040_disable(panel); + ld9040_unprepare(panel); return ret; } +static int ld9040_enable(struct drm_panel *panel) +{ + return 0; +} + static int ld9040_get_modes(struct drm_panel *panel) { struct drm_connector *connector = panel->connector;