From patchwork Thu Aug 14 01:01:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 4731031 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 200CF9F38C for ; Sun, 17 Aug 2014 11:38:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6040C20122 for ; Sun, 17 Aug 2014 11:38:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3518C20131 for ; Sun, 17 Aug 2014 11:38:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FC516E2EB; Sun, 17 Aug 2014 04:38:34 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 929 seconds by postgrey-1.34 at gabe; Wed, 13 Aug 2014 18:17:24 PDT Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by gabe.freedesktop.org (Postfix) with ESMTP id B1DB96E614 for ; Wed, 13 Aug 2014 18:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=mpj85Xrn8wmp9N9G9b GwxLd1dfwhmwRIf01FojQoGMY=; b=F8TvdAYfN/jZFvnYLE+SQwp6Z+ImeX7bj7 0x6LfTVQwU2qxnv6Pm6WsLgZOoWvUxvg5T8xe3gzkHxWFbGAUTy214C7fiZZdqp7 pW+7k4X9mbO1033aAm02MjgA9xgXcxx+XRHjnt1QTMTc0qDGov5WciVdEyQurUz1 u6KNFCtLI= Received: from localhost.localdomain.localdomain (unknown [49.77.231.131]) by smtp8 (Coremail) with SMTP id DMCowEA5pT52CuxTFuqAAA--.1988S2; Thu, 14 Aug 2014 09:01:43 +0800 (CST) X-Coremail-DSSMTP: 49.77.231.131 From: weiyj_lk@163.com To: David Airlie , Hai Li , Rob Clark , Thierry Reding , Daniel Vetter , Dave Airlie , "Matwey V. Kornilov" Subject: [PATCH] drm/msm: Fix missing unlock on error in msm_fbdev_create() Date: Thu, 14 Aug 2014 09:01:40 +0800 Message-Id: <1407978100-15947-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 1.9.3 X-CM-TRANSID: DMCowEA5pT52CuxTFuqAAA--.1988S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4DCF4xGrWxXF4fWw4xXrb_yoW3uFX_W3 4ruwn7XwnFyFn8KF1akrWSyr13tF1Y9r4rWr1Fy3yftrnrtr1rXr9Iyr1UXrWUZF4UtF1D A3WSqrs8Arn7GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU5K1vPUUUUU== X-Originating-IP: [49.77.231.131] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbiGRfn1lEANy-imQAAsN X-Mailman-Approved-At: Sun, 17 Aug 2014 04:38:33 -0700 Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Add the missing unlock before return from function msm_fbdev_create() in the error handling case. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index 9c5221c..ab5bfd2 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -143,7 +143,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, ret = msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); if (ret) { dev_err(dev->dev, "failed to get buffer obj iova: %d\n", ret); - goto fail; + goto fail_unlock; } fbi = framebuffer_alloc(0, dev->dev);