From patchwork Sun Aug 31 23:07:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 4815601 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 449CBC0338 for ; Mon, 1 Sep 2014 00:38:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 556DE20107 for ; Mon, 1 Sep 2014 00:38:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 90C56200FF for ; Mon, 1 Sep 2014 00:38:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 269156E07C; Sun, 31 Aug 2014 17:38:33 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 549F76E00C for ; Sun, 31 Aug 2014 16:08:05 -0700 (PDT) Received: by mail-lb0-f178.google.com with SMTP id v6so5012703lbi.37 for ; Sun, 31 Aug 2014 16:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=m0KU4c0t4S8BCs4N3sMu1fl03cE+mly3mna0LLS2Pvw=; b=nZ4o8GyoLGf2eJZgCCOu6VdYCBuZmfpouHyM88NS6KXQkSzZ9vfl3LsjkwjZxT64L2 o+4MzCaiyMTzW0nRX60ea/+2mZuOlJ8QSc6fNcjD/tmn6GC/3fRw9cWSl9ceBblfjPiN 3frskAf8i+xPYWQhsE4YcSAbeEn2TTiIhzrgpkaochAvexFq3/sIqT1oogGqtFtid0Tk C3z8D+tLcSkMSDFjcrOBmv7TO7C2b315FJacrvacU7pb1UFhaEb1OhuSj+qPuUZdXDzs +qAl4EvJeVd8aALt+4hUOC0Rgm85fuHuUmOdB0nx/B2+NJpKJZ3uzDV8Mwti9BKMbORr UlGw== X-Received: by 10.152.115.232 with SMTP id jr8mr12199568lab.69.1409526483979; Sun, 31 Aug 2014 16:08:03 -0700 (PDT) Received: from grizzly.metropolis ([188.134.19.124]) by mx.google.com with ESMTPSA id bt9sm10390455lbd.47.2014.08.31.16.08.02 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 31 Aug 2014 16:08:03 -0700 (PDT) From: Max Filippov To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/vmwgfx: select FB when DRM_VMWGFX is selected Date: Mon, 1 Sep 2014 03:07:47 +0400 Message-Id: <1409526467-20944-1-git-send-email-jcmvbkbc@gmail.com> X-Mailer: git-send-email 1.7.7.6 X-Mailman-Approved-At: Sun, 31 Aug 2014 17:38:32 -0700 Cc: Max Filippov , David Airlie , linux-kernel@vger.kernel.org, Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Otherwise, if FB is not selected build fails at linking step: vmwgfx_fb.c:(.text+0x4098b): undefined reference to `register_framebuffer' vmwgfx_fb.c:(.text+0x409c0): undefined reference to `framebuffer_release' vmwgfx_fb.c:(.text+0x409f4): undefined reference to `unregister_framebuffer' vmwgfx_fb.c:(.text+0x40a0e): undefined reference to `framebuffer_release' Patch ae6445ac7475ff05 drm/vmwgfx: depends on FB added dependency on FB that was subsequently removed in patch 04381b987292256d drm: Move plane helpers into drm_kms_helper.ko Signed-off-by: Max Filippov --- drivers/gpu/drm/vmwgfx/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig index 67720f7..4fba548 100644 --- a/drivers/gpu/drm/vmwgfx/Kconfig +++ b/drivers/gpu/drm/vmwgfx/Kconfig @@ -1,6 +1,7 @@ config DRM_VMWGFX tristate "DRM driver for VMware Virtual GPU" depends on DRM && PCI + select FB select FB_DEFERRED_IO select FB_CFB_FILLRECT select FB_CFB_COPYAREA