From patchwork Tue Sep 9 13:16:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 4869501 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1CE9A9F371 for ; Tue, 9 Sep 2014 13:17:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E3B302015D for ; Tue, 9 Sep 2014 13:17:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id A9C0B20166 for ; Tue, 9 Sep 2014 13:17:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14BCE6E05E; Tue, 9 Sep 2014 06:17:05 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTP id 82D466E05E for ; Tue, 9 Sep 2014 06:17:04 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NBM003APYD3L7A0@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 09 Sep 2014 14:19:51 +0100 (BST) X-AuditID: cbfec7f4-b7f156d0000063c7-98-540efdce5fc9 Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 03.A3.25543.ECDFE045; Tue, 09 Sep 2014 14:17:02 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NBM00ED9Y7LIDA0@eusync2.samsung.com>; Tue, 09 Sep 2014 14:17:02 +0100 (BST) From: Andrzej Hajda To: Inki Dae Subject: [PATCH 3/9] drm/exynos/fbdev: fix fbdev gem object cleanup Date: Tue, 09 Sep 2014 15:16:07 +0200 Message-id: <1410268573-2297-4-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1410268573-2297-1-git-send-email-a.hajda@samsung.com> References: <1410268573-2297-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGJMWRmVeSWpSXmKPExsVy+t/xK7rn/vKFGFzdIWJxa905VosrX9+z WUy6P4HF4sW9iywWZ5vesFtc3jWHzWLG+X1MFmuP3GW3mDH5JZsDp8f97uNMHn1bVjF6fN4k F8AcxWWTkpqTWZZapG+XwJVxcPpq1oIO9oo3xxpYGhinsHUxcnJICJhIbJv7GsoWk7hwbz2Q zcUhJLCUUeLK1r1MEE4fk8Tju2uYQarYBDQl/m6+CdYhIqAssWpfOztIEbPARyaJK0vfgBUJ CzhLLFi1ghHEZhFQlXi69DQriM0r4CTxtW0JC8Q6OYmTxyYDxTk4OIHq3/4LAAkLAZUsePuN fQIj7wJGhlWMoqmlyQXFSem5hnrFibnFpXnpesn5uZsYIWH1ZQfj4mNWhxgFOBiVeHgbMvhC hFgTy4orcw8xSnAwK4nwWr8ACvGmJFZWpRblxxeV5qQWH2Jk4uCUamAsaZGyqHyufSrtXm3M 3WajPZvrWC9PFdiyMS/vUpL9VfUbTd31AhJHWxu7l/KGlib1OT6VYFmVNOuqY9mOv2XXnvt8 bJBU/fy4aHlq/vTdpbGZAeXa2ZMPPvwj6s+xqrduSUUgVwznvZjsTr8ns0XEJr2s79unoZId Os3/xvtFJzKWS5xOOaTEUpyRaKjFXFScCAD2CvL2CQIAAA== Cc: "moderated list:ARM/S5P EXYNOS AR..." , Seung-Woo Kim , open list , dri-devel@lists.freedesktop.org, Andrzej Hajda , Kyungmin Park , Marek Szyprowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP exynos_gem_obj is used by exynos_drm_fbdev_destroy so it cannot be destroyed before calling the latter. exynos_gem_obj will be destroyed anyway by exynos_drm_fbdev_destroy->...->exynos_drm_fb_destroy. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 32e63f6..586e40d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -353,9 +353,6 @@ void exynos_drm_fbdev_fini(struct drm_device *dev) fbdev = to_exynos_fbdev(private->fb_helper); - if (fbdev->exynos_gem_obj) - exynos_drm_gem_destroy(fbdev->exynos_gem_obj); - exynos_drm_fbdev_destroy(dev, private->fb_helper); kfree(fbdev); private->fb_helper = NULL;