| Message ID | 1413195395-3355-8-git-send-email-thierry.reding@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/13/2014 12:16 PM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Provide a small convenience wrapper that transmits a DCS nop command. > > Signed-off-by: Thierry Reding <treding@nvidia.com> For this and patches 09, 11, 12 the same comments apply as for 06/15. Beside this they look OK to me. Regards Andrzej > --- > drivers/gpu/drm/drm_mipi_dsi.c | 18 ++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 6749b88a6c72..c88dcda2f4ac 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -517,6 +517,24 @@ ssize_t mipi_dsi_dcs_read(struct mipi_dsi_device *dsi, u8 cmd, void *data, > EXPORT_SYMBOL(mipi_dsi_dcs_read); > > /** > + * mipi_dsi_dcs_nop() - send DCS nop packet > + * @dsi: DSI peripheral device > + * > + * Return: 0 on success or a negative error code on failure. > + */ > +int mipi_dsi_dcs_nop(struct mipi_dsi_device *dsi) > +{ > + ssize_t err; > + > + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_NOP, NULL, 0); > + if (err < 0) > + return err; > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_dcs_nop); > + > +/** > * mipi_dsi_dcs_enter_sleep_mode() - disable all unnecessary blocks inside the > * display module except interface communication > * @dsi: DSI peripheral device > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 8693711eb623..be16c8e769bd 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -170,6 +170,7 @@ ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, u8 cmd, > const void *data, size_t len); > ssize_t mipi_dsi_dcs_read(struct mipi_dsi_device *dsi, u8 cmd, void *data, > size_t len); > +int mipi_dsi_dcs_nop(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_enter_sleep_mode(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_exit_sleep_mode(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_set_display_off(struct mipi_dsi_device *dsi);
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 6749b88a6c72..c88dcda2f4ac 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -517,6 +517,24 @@ ssize_t mipi_dsi_dcs_read(struct mipi_dsi_device *dsi, u8 cmd, void *data, EXPORT_SYMBOL(mipi_dsi_dcs_read); /** + * mipi_dsi_dcs_nop() - send DCS nop packet + * @dsi: DSI peripheral device + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_nop(struct mipi_dsi_device *dsi) +{ + ssize_t err; + + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_NOP, NULL, 0); + if (err < 0) + return err; + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_nop); + +/** * mipi_dsi_dcs_enter_sleep_mode() - disable all unnecessary blocks inside the * display module except interface communication * @dsi: DSI peripheral device diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 8693711eb623..be16c8e769bd 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -170,6 +170,7 @@ ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, u8 cmd, const void *data, size_t len); ssize_t mipi_dsi_dcs_read(struct mipi_dsi_device *dsi, u8 cmd, void *data, size_t len); +int mipi_dsi_dcs_nop(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_enter_sleep_mode(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_exit_sleep_mode(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_set_display_off(struct mipi_dsi_device *dsi);