| Message ID | 1414052177-19978-1-git-send-email-acourbot@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 10/23/2014 10:16 AM, Alexandre Courbot wrote: > Add the new flags argument to calls of (devm_)gpiod_get*() and > remove any direction setting code afterwards. > > Currently both forms (with or without the flags argument) > are valid thanks to transitional macros in > <linux/gpio/consumer.h>. These macros will be removed once > all consumers are updated and the flags argument will become > compulsary. > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> It needs patch "gpio: Fix gpio direction flags not getting set" to work correctly. It is not yet present in drm-next. Beside this: Acked-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/panel/panel-ld9040.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c > index 42ac67b21e9f..dd1d3f2e624e 100644 > --- a/drivers/gpu/drm/panel/panel-ld9040.c > +++ b/drivers/gpu/drm/panel/panel-ld9040.c > @@ -336,17 +336,12 @@ static int ld9040_probe(struct spi_device *spi) > if (ret < 0) > return ret; > > - ctx->reset_gpio = devm_gpiod_get(dev, "reset"); > + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); > if (IS_ERR(ctx->reset_gpio)) { > dev_err(dev, "cannot get reset-gpios %ld\n", > PTR_ERR(ctx->reset_gpio)); > return PTR_ERR(ctx->reset_gpio); > } > - ret = gpiod_direction_output(ctx->reset_gpio, 1); > - if (ret < 0) { > - dev_err(dev, "cannot configure reset-gpios %d\n", ret); > - return ret; > - } > > spi->bits_per_word = 9; > ret = spi_setup(spi); >
On Thu, Oct 23, 2014 at 6:45 PM, Andrzej Hajda <a.hajda@samsung.com> wrote: > On 10/23/2014 10:16 AM, Alexandre Courbot wrote: >> Add the new flags argument to calls of (devm_)gpiod_get*() and >> remove any direction setting code afterwards. >> >> Currently both forms (with or without the flags argument) >> are valid thanks to transitional macros in >> <linux/gpio/consumer.h>. These macros will be removed once >> all consumers are updated and the flags argument will become >> compulsary. >> >> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> > > It needs patch "gpio: Fix gpio direction flags not getting set" to work > correctly. It is not yet present in drm-next. Beside this: > > Acked-by: Andrzej Hajda <a.hajda@samsung.com> The required patch is now merged, can we go on with this patch?
On 11/06/2014 04:32 AM, Alexandre Courbot wrote: > On Thu, Oct 23, 2014 at 6:45 PM, Andrzej Hajda <a.hajda@samsung.com> wrote: >> On 10/23/2014 10:16 AM, Alexandre Courbot wrote: >>> Add the new flags argument to calls of (devm_)gpiod_get*() and >>> remove any direction setting code afterwards. >>> >>> Currently both forms (with or without the flags argument) >>> are valid thanks to transitional macros in >>> <linux/gpio/consumer.h>. These macros will be removed once >>> all consumers are updated and the flags argument will become >>> compulsary. >>> >>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> >> It needs patch "gpio: Fix gpio direction flags not getting set" to work >> correctly. It is not yet present in drm-next. Beside this: >> >> Acked-by: Andrzej Hajda <a.hajda@samsung.com> > The required patch is now merged, can we go on with this patch? > Yes, for both panels. Thanks. Regards Andrzej
On Thu, Oct 23, 2014 at 05:16:17PM +0900, Alexandre Courbot wrote: > Add the new flags argument to calls of (devm_)gpiod_get*() and > remove any direction setting code afterwards. > > Currently both forms (with or without the flags argument) > are valid thanks to transitional macros in > <linux/gpio/consumer.h>. These macros will be removed once > all consumers are updated and the flags argument will become > compulsary. > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> > --- > drivers/gpu/drm/panel/panel-ld9040.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Applied, thanks. Thierry
diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c index 42ac67b21e9f..dd1d3f2e624e 100644 --- a/drivers/gpu/drm/panel/panel-ld9040.c +++ b/drivers/gpu/drm/panel/panel-ld9040.c @@ -336,17 +336,12 @@ static int ld9040_probe(struct spi_device *spi) if (ret < 0) return ret; - ctx->reset_gpio = devm_gpiod_get(dev, "reset"); + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(ctx->reset_gpio)) { dev_err(dev, "cannot get reset-gpios %ld\n", PTR_ERR(ctx->reset_gpio)); return PTR_ERR(ctx->reset_gpio); } - ret = gpiod_direction_output(ctx->reset_gpio, 1); - if (ret < 0) { - dev_err(dev, "cannot configure reset-gpios %d\n", ret); - return ret; - } spi->bits_per_word = 9; ret = spi_setup(spi);
Add the new flags argument to calls of (devm_)gpiod_get*() and remove any direction setting code afterwards. Currently both forms (with or without the flags argument) are valid thanks to transitional macros in <linux/gpio/consumer.h>. These macros will be removed once all consumers are updated and the flags argument will become compulsary. Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> --- drivers/gpu/drm/panel/panel-ld9040.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)