From patchwork Thu Nov 27 00:08:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 5390251 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5D8D69F2F5 for ; Thu, 27 Nov 2014 00:08:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A05B720204 for ; Thu, 27 Nov 2014 00:08:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DCEEF201FE for ; Thu, 27 Nov 2014 00:08:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C248E6E47B; Wed, 26 Nov 2014 16:08:28 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qg0-f54.google.com (mail-qg0-f54.google.com [209.85.192.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 7527B6E47B for ; Wed, 26 Nov 2014 16:08:27 -0800 (PST) Received: by mail-qg0-f54.google.com with SMTP id q107so2858268qgd.13 for ; Wed, 26 Nov 2014 16:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=WHzN8uw/b0vS0aX9UgLoM5UqgHL+pVWgKUSH68KOQqU=; b=BcXQiNn1ObrY+HvjetE77lQ4m5dCPTcO0tYGTsj8cEri+eMS8a0m92RSW70nLk1t+d Br/wQoFcZ71BAei6te8KovKDKqlbL6vR4NBd+7iZzQKoHo1LUupJmG6J3oT7gOS0LSJz +ybaGpTRjmKKecTr4bdiK9Q8qRCfmZWfevhDJhz0q9KdgT9YN2LbSlKbFhKxyMIK6tE2 8m3oPnJyiVjhYJQqaekPfM/GTMLSe75yG3Yh/KXEpwtKVh1ZkYD7spu7Ieb2iQKKwoN2 +wgq/VCfxvDYzk2EZimYGX4S3N5Y64WAfXEwNkd/a2zwnRBQbB1v9+CPLOVWeKc3voqw OoKQ== X-Received: by 10.224.167.209 with SMTP id r17mr21971713qay.18.1417046906877; Wed, 26 Nov 2014 16:08:26 -0800 (PST) Received: from localhost ([2601:6:2c00:943:2677:3ff:fed3:ff40]) by mx.google.com with ESMTPSA id o30sm5234316qge.33.2014.11.26.16.08.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2014 16:08:26 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: allow drm_property_change_is_valid() to work on FB's Date: Wed, 26 Nov 2014 19:08:23 -0500 Message-Id: <1417046903-19949-1-git-send-email-robdclark@gmail.com> X-Mailer: git-send-email 1.9.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP _object_find() is not supposed to check for refcnt'd objects, that is done in drm_mode_object_find(). Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_crtc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 9972cc8..3ba84df 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -356,9 +356,6 @@ static struct drm_mode_object *_object_find(struct drm_device *dev, obj = NULL; if (obj && obj->id != id) obj = NULL; - /* don't leak out unref'd fb's */ - if (obj && (obj->type == DRM_MODE_OBJECT_FB)) - obj = NULL; mutex_unlock(&dev->mode_config.idr_mutex); return obj;