diff mbox

[5/5] drm/tegra: Remove dummy ->load_lut() implementation

Message ID 1418211002-23772-5-git-send-email-thierry.reding@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thierry Reding Dec. 10, 2014, 11:30 a.m. UTC 
From: Thierry Reding <treding@nvidia.com>

The ->load_lut() callback is optional, therefore a dummy implementation
is not needed.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/tegra/dc.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Daniel Vetter Dec. 10, 2014, 12:53 p.m. UTC | #1 
On Wed, Dec 10, 2014 at 12:30:02PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The ->load_lut() callback is optional, therefore a dummy implementation
> is not needed.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

All patches merged to drm-misc with the small conflict here resolved,
thanks.

Aside: We should rework the fbdev helper to use the main gamma table entry
point and ditch this special-purpose gamma table save/restore logic here.
But that's a lot more work.
-Daniel

> ---
>  drivers/gpu/drm/tegra/dc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index 80beebdc2566..faa2f5b4c7ac 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -1169,10 +1169,6 @@ static void tegra_crtc_commit(struct drm_crtc *crtc)
>  	drm_crtc_vblank_on(crtc);
>  }
>  
> -static void tegra_crtc_load_lut(struct drm_crtc *crtc)
> -{
> -}
> -
>  static int tegra_crtc_atomic_check(struct drm_crtc *crtc,
>  				   struct drm_crtc_state *state)
>  {
> @@ -1213,7 +1209,6 @@ static const struct drm_crtc_helper_funcs tegra_crtc_helper_funcs = {
>  	.mode_set_base = drm_helper_crtc_mode_set_base,
>  	.prepare = tegra_crtc_prepare,
>  	.commit = tegra_crtc_commit,
> -	.load_lut = tegra_crtc_load_lut,
>  	.atomic_check = tegra_crtc_atomic_check,
>  	.atomic_begin = tegra_crtc_atomic_begin,
>  	.atomic_flush = tegra_crtc_atomic_flush,
> -- 
> 2.1.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index 80beebdc2566..faa2f5b4c7ac 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -1169,10 +1169,6 @@  static void tegra_crtc_commit(struct drm_crtc *crtc)
 	drm_crtc_vblank_on(crtc);
 }
 
-static void tegra_crtc_load_lut(struct drm_crtc *crtc)
-{
-}
-
 static int tegra_crtc_atomic_check(struct drm_crtc *crtc,
 				   struct drm_crtc_state *state)
 {
@@ -1213,7 +1209,6 @@  static const struct drm_crtc_helper_funcs tegra_crtc_helper_funcs = {
 	.mode_set_base = drm_helper_crtc_mode_set_base,
 	.prepare = tegra_crtc_prepare,
 	.commit = tegra_crtc_commit,
-	.load_lut = tegra_crtc_load_lut,
 	.atomic_check = tegra_crtc_atomic_check,
 	.atomic_begin = tegra_crtc_atomic_begin,
 	.atomic_flush = tegra_crtc_atomic_flush,