From patchwork Sat Dec 20 16:15:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5524081 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 93C27BEEBA for ; Sun, 21 Dec 2014 12:59:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 975AB2015A for ; Sun, 21 Dec 2014 12:59:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id AF604200E7 for ; Sun, 21 Dec 2014 12:59:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E5586E26D; Sun, 21 Dec 2014 04:59:24 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id BDA586E094 for ; Sat, 20 Dec 2014 08:13:11 -0800 (PST) Received: by mail-wi0-f182.google.com with SMTP id h11so4461853wiw.15 for ; Sat, 20 Dec 2014 08:13:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AgR8AeUhDMgyc7xZr1/lEoUmc9waHj9gA/kJNj7PPBU=; b=EKkJsDh4fEf8E99GaZAy6eT49ZarGSMBBGWkfpi/mN7RfpOL3BwL7EDjHBe1Da9UTS Cu6nP6EDQoEG4CoTeyoNHQDEFlkR421h1KaLyrrMLEX3Gl3GUpEm/QIcbDrVq0fotk6z 1I3VFG2xIVlkVEg1yz3FsRO4/ISmRLJ+iYfBMfu9dEE/7WlYPTyis8A4gfYr9iY2mwOY ycwDIL6tl9ksESOMRTXrLKJjRqau6RMWwH298o70Rp3goVBQIsAJzlTG6G8OFgpeUOhb dMKt9De8ak7SuVOrL8Ov7hEElkB9hghPpujln0Fu0ySCTm5i0ZgcDe26YuLdxynXnK4b p4uw== X-Gm-Message-State: ALoCoQknoRCYupfpS0YPrqUKg+r7toQl0XIMwoBXeewI2LN4PjEwEq2YXj08pLDD5t9zZWXeoZDR X-Received: by 10.194.184.171 with SMTP id ev11mr24676451wjc.119.1419091990772; Sat, 20 Dec 2014 08:13:10 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id ry19sm16797924wjb.3.2014.12.20.08.13.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Dec 2014 08:13:10 -0800 (PST) From: Rickard Strandqvist To: David Airlie , Dave Airlie Subject: [PATCH] gpu: drm: ast: ast_ttm.c: Remove unused function Date: Sat, 20 Dec 2014 17:15:58 +0100 Message-Id: <1419092158-6896-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 X-Mailman-Approved-At: Sun, 21 Dec 2014 04:59:18 -0800 Cc: Rickard Strandqvist , Daniel Vetter , Josh Triplett , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rashika , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the function ast_bo_unpin() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_ttm.c | 20 -------------------- 2 files changed, 21 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h index 86205a2..1f8db90 100644 --- a/drivers/gpu/drm/ast/ast_drv.h +++ b/drivers/gpu/drm/ast/ast_drv.h @@ -361,7 +361,6 @@ int ast_gem_create(struct drm_device *dev, struct drm_gem_object **obj); int ast_bo_pin(struct ast_bo *bo, u32 pl_flag, u64 *gpu_addr); -int ast_bo_unpin(struct ast_bo *bo); static inline int ast_bo_reserve(struct ast_bo *bo, bool no_wait) { diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/drm/ast/ast_ttm.c index 08f82ea..f7c183a 100644 --- a/drivers/gpu/drm/ast/ast_ttm.c +++ b/drivers/gpu/drm/ast/ast_ttm.c @@ -375,26 +375,6 @@ int ast_bo_pin(struct ast_bo *bo, u32 pl_flag, u64 *gpu_addr) return 0; } -int ast_bo_unpin(struct ast_bo *bo) -{ - int i, ret; - if (!bo->pin_count) { - DRM_ERROR("unpin bad %p\n", bo); - return 0; - } - bo->pin_count--; - if (bo->pin_count) - return 0; - - for (i = 0; i < bo->placement.num_placement ; i++) - bo->placements[i].flags &= ~TTM_PL_FLAG_NO_EVICT; - ret = ttm_bo_validate(&bo->bo, &bo->placement, false, false); - if (ret) - return ret; - - return 0; -} - int ast_bo_push_sysram(struct ast_bo *bo) { int i, ret;