From patchwork Sat Dec 20 22:45:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5524091 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 392B4BEECA for ; Sun, 21 Dec 2014 12:59:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 683FF2011E for ; Sun, 21 Dec 2014 12:59:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 7DAC720158 for ; Sun, 21 Dec 2014 12:59:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA1596E278; Sun, 21 Dec 2014 04:59:24 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTP id F10A16E041 for ; Sat, 20 Dec 2014 14:42:20 -0800 (PST) Received: by mail-wi0-f180.google.com with SMTP id n3so4945743wiv.7 for ; Sat, 20 Dec 2014 14:42:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QHbCeGHn429/51cWX3xMAsemfbYjyAT4HXjL7z+sQjY=; b=gpjq2DB10DgFvivfynxS+vd3F6KS23SeVhUgsk7OXdFtENSUUrtrwYT99+KkgrSfK4 muFuvdMnG46aXVBYhQZDuL65nFZx/DVG5fTo37KbxSiq2m6PWxCtRUDtLJay72BaZDV4 ulJQo5KJuA6KJKA2/ziLUrVdNTGjWYwy3/qTJZ8GUQSUre219x09dGH6UmhElDCK4Tc/ iye/W9oCdyrUut1dKImA3Rbp2N3lkxcFoCX495LSJStR/37Gn6QM7gJ/fZ/GaqfnX2Rm rjgjmAw41sZFpsbMHC4cWtHsJ4RgaghGBMEbrsJpMQoeKcgw2e/zAByngZAzpuguGOiF cE+Q== X-Gm-Message-State: ALoCoQmr53joOOlKcSbaPCDKvj9iPeIdB8iI2U7nOMaaxdVlhO57Sq5QtvRzh3tEiO5pNHftQUtb X-Received: by 10.180.88.165 with SMTP id bh5mr18046180wib.77.1419115339857; Sat, 20 Dec 2014 14:42:19 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id q10sm7919897wjx.34.2014.12.20.14.42.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Dec 2014 14:42:19 -0800 (PST) From: Rickard Strandqvist To: David Airlie , Dave Airlie Subject: [PATCH] gpu: drm: ast: ast_dp501.c: Remove unused function Date: Sat, 20 Dec 2014 23:45:07 +0100 Message-Id: <1419115507-12672-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 X-Mailman-Approved-At: Sun, 21 Dec 2014 04:59:18 -0800 Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rickard Strandqvist X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the function ast_load_dp501_microcode() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/gpu/drm/ast/ast_dp501.c | 12 ------------ drivers/gpu/drm/ast/ast_drv.h | 1 - 2 files changed, 13 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_dp501.c b/drivers/gpu/drm/ast/ast_dp501.c index 76f07f3..28c977c 100644 --- a/drivers/gpu/drm/ast/ast_dp501.c +++ b/drivers/gpu/drm/ast/ast_dp501.c @@ -4,18 +4,6 @@ #include "ast_drv.h" MODULE_FIRMWARE("ast_dp501_fw.bin"); -int ast_load_dp501_microcode(struct drm_device *dev) -{ - struct ast_private *ast = dev->dev_private; - static char *fw_name = "ast_dp501_fw.bin"; - int err; - err = request_firmware(&ast->dp501_fw, fw_name, dev->dev); - if (err) - return err; - - return 0; -} - static void send_ack(struct ast_private *ast) { u8 sendack; diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h index 86205a2..67a872d 100644 --- a/drivers/gpu/drm/ast/ast_drv.h +++ b/drivers/gpu/drm/ast/ast_drv.h @@ -393,7 +393,6 @@ void ast_post_gpu(struct drm_device *dev); u32 ast_mindwm(struct ast_private *ast, u32 r); void ast_moutdwm(struct ast_private *ast, u32 r, u32 v); /* ast dp501 */ -int ast_load_dp501_microcode(struct drm_device *dev); void ast_set_dp501_video_output(struct drm_device *dev, u8 mode); bool ast_launch_m68k(struct drm_device *dev); bool ast_backup_fw(struct drm_device *dev, u8 *addr, u32 size);