From patchwork Sun Jan 4 14:47:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5564641 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AACC89F48A for ; Mon, 5 Jan 2015 01:51:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE9A620166 for ; Mon, 5 Jan 2015 01:51:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 248FA200FF for ; Mon, 5 Jan 2015 01:51:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70EDB6E1BA; Sun, 4 Jan 2015 17:51:32 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 54FE48932E for ; Sun, 4 Jan 2015 06:44:39 -0800 (PST) Received: by mail-lb0-f176.google.com with SMTP id p9so16430872lbv.21 for ; Sun, 04 Jan 2015 06:44:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=u0qi8ZY7JjQZbhzH02HwBbLsCmVj8guWuSZr0bReUGg=; b=PNJFJfEfp+8qvqmKDKvlrSJk+wlbnsTsmE+aMS0z24GnOillWloxSuvVvzTDkpUYn1 PQuxiAJdwSvecLzSd61pp8ex4SYe1fwrmv5VoQWKMoWumdYll8kD2Ru31Q4yujxIozcG EGsx98inMH6GtD/QHRLmxHMewMW8bMnjhOmd79SkEiVhMH3u/Q0wQm9a6g8o8Ykjd5Di X/Su3i0scELKttICmm4V1gZ+m1deBBW4RN+M01+yLFli/5SeSlH4rsDrOYYmbK0lF/yA AhUoFldHJu/z3v4BQXPSin/pwtJnKGVLAO/0sAGr8Ps07fpZBHZP2xZPer/sNTucSGVi tKRA== X-Gm-Message-State: ALoCoQkk73jgx1Xh55FPsk3/PcoHPct6NJYm4RZbhCsospdg1lsT9r2KKB/wTP0YNR9QD1L8tX5G X-Received: by 10.112.85.11 with SMTP id d11mr86976289lbz.100.1420382678905; Sun, 04 Jan 2015 06:44:38 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id am8sm13614420lac.13.2015.01.04.06.44.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jan 2015 06:44:37 -0800 (PST) From: Rickard Strandqvist To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH] gpu: drm: radeon: ci_smc: Remove unused function Date: Sun, 4 Jan 2015 15:47:39 +0100 Message-Id: <1420382860-9141-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 X-Mailman-Approved-At: Sun, 04 Jan 2015 17:51:27 -0800 Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rickard Strandqvist X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the function ci_wait_for_smc_inactive() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/gpu/drm/radeon/ci_dpm.h | 1 - drivers/gpu/drm/radeon/ci_smc.c | 18 ------------------ 2 files changed, 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/ci_dpm.h b/drivers/gpu/drm/radeon/ci_dpm.h index 93bbed9..596d17e 100644 --- a/drivers/gpu/drm/radeon/ci_dpm.h +++ b/drivers/gpu/drm/radeon/ci_dpm.h @@ -322,7 +322,6 @@ void ci_stop_smc_clock(struct radeon_device *rdev); void ci_start_smc_clock(struct radeon_device *rdev); bool ci_is_smc_running(struct radeon_device *rdev); PPSMC_Result ci_send_msg_to_smc(struct radeon_device *rdev, PPSMC_Msg msg); -PPSMC_Result ci_wait_for_smc_inactive(struct radeon_device *rdev); int ci_load_smc_ucode(struct radeon_device *rdev, u32 limit); int ci_read_smc_sram_dword(struct radeon_device *rdev, u32 smc_address, u32 *value, u32 limit); diff --git a/drivers/gpu/drm/radeon/ci_smc.c b/drivers/gpu/drm/radeon/ci_smc.c index b630edc..4f78b8c 100644 --- a/drivers/gpu/drm/radeon/ci_smc.c +++ b/drivers/gpu/drm/radeon/ci_smc.c @@ -184,24 +184,6 @@ PPSMC_Result ci_send_msg_to_smc(struct radeon_device *rdev, PPSMC_Msg msg) return (PPSMC_Result)tmp; } -PPSMC_Result ci_wait_for_smc_inactive(struct radeon_device *rdev) -{ - u32 tmp; - int i; - - if (!ci_is_smc_running(rdev)) - return PPSMC_Result_OK; - - for (i = 0; i < rdev->usec_timeout; i++) { - tmp = RREG32_SMC(SMC_SYSCON_CLOCK_CNTL_0); - if ((tmp & CKEN) == 0) - break; - udelay(1); - } - - return PPSMC_Result_OK; -} - int ci_load_smc_ucode(struct radeon_device *rdev, u32 limit) { unsigned long flags;