From patchwork Tue Jan 13 05:43:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 5617971 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0253AC058D for ; Tue, 13 Jan 2015 05:42:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 371FB205DD for ; Tue, 13 Jan 2015 05:42:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DAA66205BB for ; Tue, 13 Jan 2015 05:42:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 26EB06E419; Mon, 12 Jan 2015 21:42:53 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id F28586E419 for ; Mon, 12 Jan 2015 21:42:51 -0800 (PST) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NI300BQLP7EWG80@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 13 Jan 2015 14:42:50 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.115]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 3F.2C.11124.A50B4B45; Tue, 13 Jan 2015 14:42:50 +0900 (KST) X-AuditID: cbfee68e-f79b46d000002b74-04-54b4b05a405d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 76.08.09430.A50B4B45; Tue, 13 Jan 2015 14:42:50 +0900 (KST) Received: from localhost.localdomain ([10.252.81.123]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NI300E3EP7EJO70@mmp1.samsung.com>; Tue, 13 Jan 2015 14:42:50 +0900 (KST) From: Joonyoung Shim To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/exynos: remove unnecessary runtime pm operations Date: Tue, 13 Jan 2015 14:43:07 +0900 Message-id: <1421127787-16333-1-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsWyRsSkWDdqw5YQg7dT5C2ufH3PZjHp/gQW ixf3LrJYnG16w24xY/JLNgdWj/vdx5k8+rasYgxgiuKySUnNySxLLdK3S+DKOLBqKVPBRc6K 3ScmszYwdnB0MXJySAiYSLxZ95IJwhaTuHBvPRuILSSwlFHi2mknmJrpy04yQ8QXMUose8/Z xcgFZLcxSfRfuA7WzCagJ3Fn23EwW0RAWeLvxFWMIDazQJrE96+bwWxhAVeJ2RvXgw1iEVCV uH28jRXE5hVwlzh5aBcbxDI5iZPHJrOCLJAQuM0m0d6zHKpBQOLb5EMsXYwcQAlZiU0HmCHq JSUOrrjBMoFRcAEjwypG0dSC5ILipPQiI73ixNzi0rx0veT83E2MwCA8/e9Z3w7GmwesDzEK cDAq8fDuyN4SIsSaWFZcmXuI0RRow0RmKdHkfGCo55XEGxqbGVmYmpgaG5lbmimJ8yZI/QwW EkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwLhYaKevx96pCTvjt/iqCVVLS1oE8805M13Z1aGs u+Fw/cxl2/cku094YBG4p71ym8lDIU0F/2SugLQHhwzu3GwSq97xsbqz98aMRfkqU3zrd/5b f9Ce994JWwHhCKfK1PV7785eZ7PsivvhcKM1N4T5Jtv9yS/4dc1/Wu3Cjfe17/5lXbCtyECJ pTgj0VCLuag4EQDC3oVtPQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsVy+t9jAd2oDVtCDHYdEre48vU9m8Wk+xNY LF7cu8hicbbpDbvFjMkv2RxYPe53H2fy6NuyijGAKaqB0SYjNTEltUghNS85PyUzL91WyTs4 3jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaJ+SQlliTilQKCCxuFhJ3w7ThNAQN10LmMYI Xd+QILgeIwM0kLCGMePAqqVMBRc5K3afmMzawNjB0cXIySEhYCIxfdlJZghbTOLCvfVsILaQ wCJGiWXvObsYuYDsNiaJ/gvXmUASbAJ6Ene2HQezRQSUJf5OXMUIYjMLpEl8/7oZzBYWcJWY vXE92FAWAVWJ28fbWEFsXgF3iZOHdrFBLJOTOHlsMusERu4FjAyrGEVTC5ILipPSc430ihNz i0vz0vWS83M3MYKD/Jn0DsZVDRaHGAU4GJV4eAXytoQIsSaWFVfmHmKU4GBWEuG1mwMU4k1J rKxKLcqPLyrNSS0+xGgKtH0is5Rocj4wAvNK4g2NTcyMLI3MDS2MjM2VxHmV7NtChATSE0tS s1NTC1KLYPqYODilGhi3HO6tmBSpEucds0A/lLnw0T82eY49QqLOc7TYbnAJnthznan40hvm 9Ybeb35Ml9A6eWeXh236Bu2TJye6ZFl9Cp9pLfUihzelRmqxe3tRn+u6Lc+3z0gIDt2Z8kRP 36GdsXCHlsOV/CMW3ac7G29nHtBU+FIy38L1AaNP5bLXMzkXz3kh+UOJpTgj0VCLuag4EQC8 7j2KiAIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: kyungmin.park@samsung.com, sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In booting, we can see a below message. [ 3.241728] exynos-mixer 14450000.mixer: Unbalanced pm_runtime_enable! Already pm_runtime_enable is called by probe function. Remove pm_runtime_enable/disable from mixer_bind and mixer_unbind. Signed-off-by: Joonyoung Shim --- I'm not sure whether it's better to remove pm_runtime_enable/disable from probe and remove function than mixer_bind and mixer_unbind. drivers/gpu/drm/exynos/exynos_mixer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index b90a423..0dedb99 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -1256,8 +1256,6 @@ static int mixer_bind(struct device *dev, struct device *manager, void *data) if (ret) goto free_ctx; - pm_runtime_enable(dev); - return 0; free_ctx: @@ -1270,8 +1268,6 @@ static void mixer_unbind(struct device *dev, struct device *master, void *data) struct mixer_context *ctx = dev_get_drvdata(dev); mixer_ctx_remove(ctx); - - pm_runtime_disable(dev); } static const struct component_ops mixer_component_ops = {