From patchwork Tue Jan 13 17:46:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Deucher X-Patchwork-Id: 5622951 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B13ED9F2ED for ; Tue, 13 Jan 2015 17:47:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A113B20558 for ; Tue, 13 Jan 2015 17:47:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 87E2C2039C for ; Tue, 13 Jan 2015 17:47:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 61AB66E67C; Tue, 13 Jan 2015 09:47:19 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qc0-f182.google.com (mail-qc0-f182.google.com [209.85.216.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FE3572031 for ; Tue, 13 Jan 2015 09:47:12 -0800 (PST) Received: by mail-qc0-f182.google.com with SMTP id r5so3376696qcx.13 for ; Tue, 13 Jan 2015 09:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cjd5CKzPZIbtjC0SutZk/rO8tRx22g5dHXx6sar4H6E=; b=otryo/vdnu48Q7sc3jbZVGOhgV0uWWMo9iRN5GdtAG7KGlqIqn77XtBGzvfsRbJZCd YCBSO9nnE6Xsob8Akt8PsJhDXflhwZ4dfLNucg4LSb+kedC6k+cEuPXk5PbdLrohsdZ8 +v4OaLqsYpshIinmy2gA8FplW/Uh6yl5+XOLGMQxn1CVvbEYN24svH/0TtLxhsV6x3sa NGsEyl1BV25cjydJxU3VO8AdpiwIzEDD6tJ16cGk0G6nr6nfEkbKlEbC7m/D6D+2DQAZ bYuKUYHXdW7Fc3NyQd+ni2UZAObPY29TxgJ5QTlXB8RFf4ysyfUg2x//uCCukTzKtLMb Da1Q== X-Received: by 10.224.8.137 with SMTP id h9mr62878065qah.55.1421171231474; Tue, 13 Jan 2015 09:47:11 -0800 (PST) Received: from localhost.localdomain (static-74-96-105-49.washdc.fios.verizon.net. [74.96.105.49]) by mx.google.com with ESMTPSA id 43sm18213707qgb.17.2015.01.13.09.47.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jan 2015 09:47:10 -0800 (PST) From: Alex Deucher X-Google-Original-From: Alex Deucher To: dri-devel@lists.freedesktop.org Subject: [PATCH 18/24] radeon/audio: moved mute programming to a separate function Date: Tue, 13 Jan 2015 12:46:47 -0500 Message-Id: <1421171213-23977-19-git-send-email-alexander.deucher@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1421171213-23977-1-git-send-email-alexander.deucher@amd.com> References: <1421171213-23977-1-git-send-email-alexander.deucher@amd.com> Cc: Alex Deucher , slava.grigorev@amd.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Slava Grigorev Signed-off-by: Slava Grigorev Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/dce3_1_afmt.c | 15 ++++++++++++--- drivers/gpu/drm/radeon/evergreen_hdmi.c | 17 +++++++++++++---- drivers/gpu/drm/radeon/r600_hdmi.c | 16 ++++++++++++---- drivers/gpu/drm/radeon/radeon_audio.c | 19 +++++++++++++++++++ drivers/gpu/drm/radeon/radeon_audio.h | 2 ++ 5 files changed, 58 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/radeon/dce3_1_afmt.c b/drivers/gpu/drm/radeon/dce3_1_afmt.c index fa0e011..b46473a 100644 --- a/drivers/gpu/drm/radeon/dce3_1_afmt.c +++ b/drivers/gpu/drm/radeon/dce3_1_afmt.c @@ -220,6 +220,17 @@ void dce3_2_set_audio_packet(struct drm_encoder *encoder, u32 offset) HDMI0_AUDIO_INFO_LINE(2)); /* anything other than 0 */ } +void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool mute) +{ + struct drm_device *dev = encoder->dev; + struct radeon_device *rdev = dev->dev_private; + + if (mute) + WREG32_OR(HDMI0_GC + offset, HDMI0_GC_AVMUTE); + else + WREG32_AND(HDMI0_GC + offset, ~HDMI0_GC_AVMUTE); +} + /* * update the info frames with the data from the current display mode */ @@ -246,9 +257,7 @@ void dce3_1_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode *m radeon_audio_set_dto(encoder, mode->clock); radeon_audio_set_vbi_packet(encoder); radeon_hdmi_set_color_depth(encoder); - - WREG32(HDMI0_GC + offset, 0); /* unset HDMI0_GC_AVMUTE */ - + radeon_audio_set_mute(encoder, false); radeon_audio_update_acr(encoder, mode->clock); radeon_audio_write_speaker_allocation(encoder); radeon_audio_set_audio_packet(encoder); diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b/drivers/gpu/drm/radeon/evergreen_hdmi.c index 7c7644c..9f35bd0 100644 --- a/drivers/gpu/drm/radeon/evergreen_hdmi.c +++ b/drivers/gpu/drm/radeon/evergreen_hdmi.c @@ -386,6 +386,18 @@ void dce4_set_audio_packet(struct drm_encoder *encoder, u32 offset) AFMT_AUDIO_SAMPLE_SEND | AFMT_RESET_FIFO_WHEN_AUDIO_DIS | AFMT_60958_CS_UPDATE); } + +void dce4_set_mute(struct drm_encoder *encoder, u32 offset, bool mute) +{ + struct drm_device *dev = encoder->dev; + struct radeon_device *rdev = dev->dev_private; + + if (mute) + WREG32_OR(HDMI_GC + offset, HDMI_GC_AVMUTE); + else + WREG32_AND(HDMI_GC + offset, ~HDMI_GC_AVMUTE); +} + /* * update the info frames with the data from the current display mode */ @@ -412,13 +424,10 @@ void evergreen_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode radeon_audio_set_dto(encoder, mode->clock); radeon_audio_set_vbi_packet(encoder); radeon_hdmi_set_color_depth(encoder); - - WREG32(HDMI_GC + offset, 0); /* unset HDMI_GC_AVMUTE */ - + radeon_audio_set_mute(encoder, false); radeon_audio_update_acr(encoder, mode->clock); radeon_audio_write_speaker_allocation(encoder); radeon_audio_set_audio_packet(encoder); - radeon_audio_select_pin(encoder); radeon_audio_write_sad_regs(encoder); radeon_audio_write_latency_fields(encoder, mode); diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index b433823..a4c2ce9 100644 --- a/drivers/gpu/drm/radeon/r600_hdmi.c +++ b/drivers/gpu/drm/radeon/r600_hdmi.c @@ -389,6 +389,17 @@ void r600_set_audio_packet(struct drm_encoder *encoder, u32 offset) ~HDMI0_60958_CS_CHANNEL_NUMBER_R_MASK); } +void r600_set_mute(struct drm_encoder *encoder, u32 offset, bool mute) +{ + struct drm_device *dev = encoder->dev; + struct radeon_device *rdev = dev->dev_private; + + if (mute) + WREG32_OR(HDMI0_GC + offset, HDMI0_GC_AVMUTE); + else + WREG32_AND(HDMI0_GC + offset, ~HDMI0_GC_AVMUTE); +} + /* * update the info frames with the data from the current display mode */ @@ -415,10 +426,7 @@ void r600_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode *mod radeon_audio_set_dto(encoder, mode->clock); radeon_audio_set_vbi_packet(encoder); radeon_hdmi_set_color_depth(encoder); - - WREG32_AND(HDMI0_GC + offset, - ~HDMI0_GC_AVMUTE); /* unset HDMI0_GC_AVMUTE */ - + radeon_audio_set_mute(encoder, false); radeon_audio_update_acr(encoder, mode->clock); radeon_audio_set_audio_packet(encoder); diff --git a/drivers/gpu/drm/radeon/radeon_audio.c b/drivers/gpu/drm/radeon/radeon_audio.c index 728a416..bbfdce3 100644 --- a/drivers/gpu/drm/radeon/radeon_audio.c +++ b/drivers/gpu/drm/radeon/radeon_audio.c @@ -92,6 +92,9 @@ void dce4_hdmi_set_color_depth(struct drm_encoder *encoder, void r600_set_audio_packet(struct drm_encoder *encoder, u32 offset); void dce3_2_set_audio_packet(struct drm_encoder *encoder, u32 offset); void dce4_set_audio_packet(struct drm_encoder *encoder, u32 offset); +void r600_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); +void dce3_2_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); +void dce4_set_mute(struct drm_encoder *encoder, u32 offset, bool mute); static const u32 pin_offsets[7] = { @@ -146,6 +149,7 @@ static struct radeon_audio_funcs r600_hdmi_funcs = { .set_vbi_packet = r600_set_vbi_packet, .set_avi_packet = r600_set_avi_packet, .set_audio_packet = r600_set_audio_packet, + .set_mute = r600_set_mute, }; static struct radeon_audio_funcs dce32_hdmi_funcs = { @@ -157,6 +161,7 @@ static struct radeon_audio_funcs dce32_hdmi_funcs = { .set_vbi_packet = r600_set_vbi_packet, .set_avi_packet = r600_set_avi_packet, .set_audio_packet = dce3_2_set_audio_packet, + .set_mute = dce3_2_set_mute, }; static struct radeon_audio_funcs dce32_dp_funcs = { @@ -178,6 +183,7 @@ static struct radeon_audio_funcs dce4_hdmi_funcs = { .set_color_depth = dce4_hdmi_set_color_depth, .set_avi_packet = evergreen_set_avi_packet, .set_audio_packet = dce4_set_audio_packet, + .set_mute = dce4_set_mute, }; static struct radeon_audio_funcs dce4_dp_funcs = { @@ -200,6 +206,7 @@ static struct radeon_audio_funcs dce6_hdmi_funcs = { .set_color_depth = dce4_hdmi_set_color_depth, .set_avi_packet = evergreen_set_avi_packet, .set_audio_packet = dce4_set_audio_packet, + .set_mute = dce4_set_mute, }; static struct radeon_audio_funcs dce6_dp_funcs = { @@ -635,3 +642,15 @@ void radeon_audio_set_audio_packet(struct drm_encoder *encoder) if (radeon_encoder->audio && radeon_encoder->audio->set_audio_packet) radeon_encoder->audio->set_audio_packet(encoder, dig->afmt->offset); } + +void radeon_audio_set_mute(struct drm_encoder *encoder, bool mute) +{ + struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder); + struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv; + + if (!dig || !dig->afmt) + return; + + if (radeon_encoder->audio && radeon_encoder->audio->set_mute) + radeon_encoder->audio->set_mute(encoder, dig->afmt->offset, mute); +} diff --git a/drivers/gpu/drm/radeon/radeon_audio.h b/drivers/gpu/drm/radeon/radeon_audio.h index cefe457..5ca5e7e 100644 --- a/drivers/gpu/drm/radeon/radeon_audio.h +++ b/drivers/gpu/drm/radeon/radeon_audio.h @@ -60,6 +60,7 @@ struct radeon_audio_funcs void (*set_avi_packet)(struct radeon_device *rdev, u32 offset, unsigned char *buffer, size_t size); void (*set_audio_packet)(struct drm_encoder *encoder, u32 offset); + void (*set_mute)(struct drm_encoder *encoder, u32 offset, bool mute); }; int radeon_audio_init(struct radeon_device *rdev); @@ -85,5 +86,6 @@ void radeon_audio_update_acr(struct drm_encoder *encoder, unsigned int clock); void radeon_audio_set_vbi_packet(struct drm_encoder *encoder); void radeon_hdmi_set_color_depth(struct drm_encoder *encoder); void radeon_audio_set_audio_packet(struct drm_encoder *encoder); +void radeon_audio_set_mute(struct drm_encoder *encoder, bool mute); #endif