diff mbox

[v3] drm/panel: Add support for AUO b101ean01 panel

Message ID 1421375817-21793-1-git-send-email-hl@rock-chips.com (mailing list archive)
State Superseded
Headers show

Commit Message

huang lin Jan. 16, 2015, 2:36 a.m. UTC
The AUO b101ean01 panel is a 10.1" 1280x800 panel,
which can be supported by the simple panel driver.

Signed-off-by: huang lin <hl@rock-chips.com>

---

Changes in v3:
- changed moving auo_b101ean01 definitions under auo_b101aw03

 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Daniel Kurtz Jan. 16, 2015, 3:14 a.m. UTC | #1
On Fri, Jan 16, 2015 at 10:36 AM, huang lin <hl@rock-chips.com> wrote:
> The AUO b101ean01 panel is a 10.1" 1280x800 panel,
> which can be supported by the simple panel driver.
>
> Signed-off-by: huang lin <hl@rock-chips.com>

Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

>
> ---
>
> Changes in v3:
> - changed moving auo_b101ean01 definitions under auo_b101aw03
>
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index e95385b..24828e0 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -345,6 +345,29 @@ static const struct panel_desc auo_b101aw03 = {
>         },
>  };
>
> +static const struct drm_display_mode auo_b101ean01_mode = {
> +       .clock = 72500,
> +       .hdisplay = 1280,
> +       .hsync_start = 1280 + 147,
> +       .hsync_end = 1280 + 147 + 32,
> +       .htotal = 1280 + 147 + 32 + 21,
> +       .vdisplay = 800,
> +       .vsync_start = 800 + 4,
> +       .vsync_end = 800 + 4 + 4,
> +       .vtotal = 800 + 4 + 4 + 8,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_desc auo_b101ean01 = {
> +       .modes = &auo_b101ean01_mode,
> +       .num_modes = 1,
> +       .bpc = 6,
> +       .size = {
> +               .width = 217,
> +               .height = 136,
> +       },
> +};
> +
>  static const struct drm_display_mode auo_b101xtn01_mode = {
>         .clock = 72000,
>         .hdisplay = 1366,
> @@ -727,6 +750,9 @@ static const struct of_device_id platform_of_match[] = {
>                 .compatible = "auo,b101aw03",
>                 .data = &auo_b101aw03,
>         }, {
> +               .compatible = "auo,b101ean01",
> +               .data = &auo_b101ean01,
> +       }, {
>                 .compatible = "auo,b101xtn01",
>                 .data = &auo_b101xtn01,
>         }, {
> --
> 1.9.1
>
>
Daniel Kurtz Jan. 16, 2015, 12:17 p.m. UTC | #2
On Fri, Jan 16, 2015 at 11:14 AM, Daniel Kurtz <djkurtz@chromium.org> wrote:
>
> On Fri, Jan 16, 2015 at 10:36 AM, huang lin <hl@rock-chips.com> wrote:
> > The AUO b101ean01 panel is a 10.1" 1280x800 panel,
> > which can be supported by the simple panel driver.
> >
> > Signed-off-by: huang lin <hl@rock-chips.com>
>

Thierry is going to point out  that this patch is missing devicetree
documentation, so I'll beat him to the punch :-).
Please add an "auo,b101ean01" entry to:
  Documentation/devicetree/bindings/panel/

With the above documentation this is:

>
> >
> > ---
> >
> > Changes in v3:
> > - changed moving auo_b101ean01 definitions under auo_b101aw03
> >
> >  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index e95385b..24828e0 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -345,6 +345,29 @@ static const struct panel_desc auo_b101aw03 = {
> >         },
> >  };
> >
> > +static const struct drm_display_mode auo_b101ean01_mode = {
> > +       .clock = 72500,
> > +       .hdisplay = 1280,
> > +       .hsync_start = 1280 + 147,
> > +       .hsync_end = 1280 + 147 + 32,
> > +       .htotal = 1280 + 147 + 32 + 21,
> > +       .vdisplay = 800,
> > +       .vsync_start = 800 + 4,
> > +       .vsync_end = 800 + 4 + 4,
> > +       .vtotal = 800 + 4 + 4 + 8,
> > +       .vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc auo_b101ean01 = {
> > +       .modes = &auo_b101ean01_mode,
> > +       .num_modes = 1,
> > +       .bpc = 6,
> > +       .size = {
> > +               .width = 217,
> > +               .height = 136,
> > +       },
> > +};
> > +
> >  static const struct drm_display_mode auo_b101xtn01_mode = {
> >         .clock = 72000,
> >         .hdisplay = 1366,
> > @@ -727,6 +750,9 @@ static const struct of_device_id platform_of_match[] = {
> >                 .compatible = "auo,b101aw03",
> >                 .data = &auo_b101aw03,
> >         }, {
> > +               .compatible = "auo,b101ean01",
> > +               .data = &auo_b101ean01,
> > +       }, {
> >                 .compatible = "auo,b101xtn01",
> >                 .data = &auo_b101xtn01,
> >         }, {
> > --
> > 1.9.1
> >
> >
diff mbox

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index e95385b..24828e0 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -345,6 +345,29 @@  static const struct panel_desc auo_b101aw03 = {
 	},
 };
 
+static const struct drm_display_mode auo_b101ean01_mode = {
+	.clock = 72500,
+	.hdisplay = 1280,
+	.hsync_start = 1280 + 147,
+	.hsync_end = 1280 + 147 + 32,
+	.htotal = 1280 + 147 + 32 + 21,
+	.vdisplay = 800,
+	.vsync_start = 800 + 4,
+	.vsync_end = 800 + 4 + 4,
+	.vtotal = 800 + 4 + 4 + 8,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc auo_b101ean01 = {
+	.modes = &auo_b101ean01_mode,
+	.num_modes = 1,
+	.bpc = 6,
+	.size = {
+		.width = 217,
+		.height = 136,
+	},
+};
+
 static const struct drm_display_mode auo_b101xtn01_mode = {
 	.clock = 72000,
 	.hdisplay = 1366,
@@ -727,6 +750,9 @@  static const struct of_device_id platform_of_match[] = {
 		.compatible = "auo,b101aw03",
 		.data = &auo_b101aw03,
 	}, {
+		.compatible = "auo,b101ean01",
+		.data = &auo_b101ean01,
+	}, {
 		.compatible = "auo,b101xtn01",
 		.data = &auo_b101xtn01,
 	}, {