From patchwork Thu Feb 5 07:11:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 5782211 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8D3949F30C for ; Thu, 5 Feb 2015 07:11:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C4664202C8 for ; Thu, 5 Feb 2015 07:11:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id E92D320279 for ; Thu, 5 Feb 2015 07:11:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 181B572087; Wed, 4 Feb 2015 23:11:41 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id C7DB672089 for ; Wed, 4 Feb 2015 23:11:39 -0800 (PST) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJA00EEVEN85740@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 05 Feb 2015 16:11:32 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.115]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id A4.B4.18484.3A713D45; Thu, 05 Feb 2015 16:11:31 +0900 (KST) X-AuditID: cbfee68f-f791c6d000004834-38-54d317a3a05a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 97.98.20081.3A713D45; Thu, 05 Feb 2015 16:11:31 +0900 (KST) Received: from localhost.localdomain ([10.252.81.123]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NJA002ZZEN6UM90@mmp2.samsung.com>; Thu, 05 Feb 2015 16:11:31 +0900 (KST) From: Joonyoung Shim To: dri-devel@lists.freedesktop.org Subject: [PATCH 4/4] drm/exynos: fix NULL pointer reference Date: Thu, 05 Feb 2015 16:11:38 +0900 Message-id: <1423120298-28619-4-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1423120298-28619-1-git-send-email-jy0922.shim@samsung.com> References: <1423120298-28619-1-git-send-email-jy0922.shim@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsWyRsSkWHex+OUQgxnvLC3+b5vIbHHl63s2 i0+rW9ktJt2fwGLx4t5FFosZk1+yObB5/H1+ncVj77cFLB73u48zefRtWcUYwBLFZZOSmpNZ llqkb5fAlfHm5Hb2gn3sFbu2f2NuYNzK1sXIySEhYCJx+fJ5dghbTOLCvfVAcS4OIYGljBLb P/azwxR1Tj3PDJGYzihxdcpGKKeNSeLgnU1MIFVsAnoSd7YdB7NFBJQl/k5cxQhiMwvUStyb /x7MFhawlli+fhGQzcHBIqAqsW6aF0iYV8Bd4v/RR1DL5CROHpvMCmJzCnhI/HkI0SoEVLPk 53ywvRIC7ewS1zfdAdvFIiAg8W3yIRaQmRICshKbDjBDzJGUOLjiBssERuEFjAyrGEVTC5IL ipPSi4z1ihNzi0vz0vWS83M3MQKD+vS/Z/07GO8esD7EKMDBqMTDa7HvUogQa2JZcWXuIUZT oA0TmaVEk/OBsZNXEm9obGZkYWpiamxkbmmmJM67UOpnsJBAemJJanZqakFqUXxRaU5q8SFG Jg5OqQZG4bYKfv70VMYViedb0t3y6+f9ZuP68jRr+vVNJZzPXWy1L+TF/uz9v17oxYQfVcc4 evYYVK+aKrj/0IZ7iyveKJ0S+788LuJ94Ncbc9TPKDzZ82DVu/WXp3z9uvU0o2Dvjgf6Eqc5 3jitOBztO6HQdnLIXl25sN1bfeWOcXEebLusopJqXOM6VYmlOCPRUIu5qDgRABBjORllAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t9jQd3F4pdDDL79N7L4v20is8WVr+/Z LD6tbmW3mHR/AovFi3sXWSxmTH7J5sDm8ff5dRaPvd8WsHjc7z7O5NG3ZRVjAEtUA6NNRmpi SmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtB6JYWyxJxSoFBA YnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWPGm5Pb2Qv2sVfs2v6NuYFxK1sXIyeHhICJ ROfU88wQtpjEhXvrgeJcHEIC0xklrk7ZyAzhtDFJHLyziQmkik1AT+LOtuNgtoiAssTfiasY QWxmgVqJe/Pfg9nCAtYSy9cvArI5OFgEVCXWTfMCCfMKuEv8P/qIHWKZnMTJY5NZQWxOAQ+J Pw8hWoWAapb8nM88gZF3ASPDKkbR1ILkguKk9FxDveLE3OLSvHS95PzcTYzgmHkmtYNxZYPF IUYBDkYlHl7LfZdChFgTy4orcw8xSnAwK4nwanJcDhHiTUmsrEotyo8vKs1JLT7EaAp01ERm KdHkfGA855XEGxqbmBlZGpkbWhgZmyuJ8yrZt4UICaQnlqRmp6YWpBbB9DFxcEo1MMZaWoUc DcpWaJP9n8q3iHnPrTPT/2QkZ3opl/1a7mR9jWX1bC7Dixzf3l0uPnuidp/PRtNLMa9XnvXh k7nRVmLWcU/Rb+/nS1n7fJ5GqEoGdqlsEei+l9AUWrfVtvFZuZ1B96Gd8i0hCkafhY+c1EiU MpXakCv1cu/jtWky+y8xum1vNMpfosRSnJFoqMVcVJwIAAyC0o2vAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: gustavo.padovan@collabora.co.uk, sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is a case called disable_plane callback function even if plane->crtc is NULL from exynos_drm_encoder_disable and it will cause NULL pointer reference error. Signed-off-by: Joonyoung Shim Reviewed-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index 7e282e3..57de0bd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -102,7 +102,7 @@ static void exynos_drm_encoder_disable(struct drm_encoder *encoder) /* all planes connected to this encoder should be also disabled. */ drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) { - if (plane->crtc == encoder->crtc) + if (plane->crtc && (plane->crtc == encoder->crtc)) plane->funcs->disable_plane(plane); } }