From patchwork Thu Feb 5 09:42:46 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Philipp Zabel
X-Patchwork-Id: 5783041
Return-Path:
X-Original-To: patchwork-dri-devel@patchwork.kernel.org
Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.136])
by patchwork1.web.kernel.org (Postfix) with ESMTP id 1E0789F302
for ;
Thu, 5 Feb 2015 09:42:58 +0000 (UTC)
Received: from mail.kernel.org (localhost [127.0.0.1])
by mail.kernel.org (Postfix) with ESMTP id 3874C202C8
for ;
Thu, 5 Feb 2015 09:42:57 +0000 (UTC)
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
by mail.kernel.org (Postfix) with ESMTP id 1D38F202AE
for ;
Thu, 5 Feb 2015 09:42:56 +0000 (UTC)
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
by gabe.freedesktop.org (Postfix) with ESMTP id 82ABF6E19F;
Thu, 5 Feb 2015 01:42:54 -0800 (PST)
X-Original-To: dri-devel@lists.freedesktop.org
Delivered-To: dri-devel@lists.freedesktop.org
Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de
[92.198.50.35])
by gabe.freedesktop.org (Postfix) with ESMTP id D3CFB6E19F
for ;
Thu, 5 Feb 2015 01:42:52 -0800 (PST)
Received: from paszta.hi.pengutronix.de
([2001:67c:670:100:96de:80ff:fec2:9969] helo=paszta)
by metis.ext.pengutronix.de with esmtp (Exim 4.72)
(envelope-from )
id 1YJIxX-0005Gf-BO; Thu, 05 Feb 2015 10:42:51 +0100
Message-ID: <1423129366.3207.7.camel@pengutronix.de>
Subject: Re: [PATCH v2 05/10] Add RGB666_1X24_CPADHI media bus format
From: Philipp Zabel
To: Sakari Ailus
Date: Thu, 05 Feb 2015 10:42:46 +0100
In-Reply-To: <54D22EB0.1080602@linux.intel.com>
References: <1422988504-11123-1-git-send-email-p.zabel@pengutronix.de>
<1422988504-11123-6-git-send-email-p.zabel@pengutronix.de>
<54D22EB0.1080602@linux.intel.com>
X-Mailer: Evolution 3.12.9-1
Mime-Version: 1.0
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de);
SAEximRunCond expanded to false
X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org
Cc: Emil Renner Berthing ,
Mauro Carvalho Chehab ,
dri-devel@lists.freedesktop.org, Hans Verkuil ,
Laurent Pinchart ,
kernel@pengutronix.de, Steve Longerbeam ,
Russell King
X-BeenThere: dri-devel@lists.freedesktop.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Direct Rendering Infrastructure - Development
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED,
T_RP_MATCHES_RCVD,
UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org
X-Virus-Scanned: ClamAV using ClamSMTP
Hi Sakari,
Am Mittwoch, den 04.02.2015, 16:37 +0200 schrieb Sakari Ailus:
> Hi Philipp,
>
> Could you add linux-media next time you send the set, please? I think
> that's the most relevant list for the format related patches.
Will do in the next round. Let's see what Mauro thinks about your
concern regarding potential conflicts in
include/uapi/linux/media-bus-format.h when merging changes through both
drm and media.
> Philipp Zabel wrote:
> > Commit 9e74d2926a28 ("staging: imx-drm: add LVDS666 support for parallel
> > display") describes a 24-bit bus format where three 6-bit components each
> > take the lower part of 8 bits with the two high bits zero padded. Add a
> > component-wise padded media bus format RGB666_1X24_CPADHI to support this
> > connection.
> >
> > Cc: Emil Renner Berthing
> > Signed-off-by: Philipp Zabel
> > ---
> > Documentation/DocBook/media/v4l/subdev-formats.xml | 30 ++++++++++++++++++++++
> > include/uapi/linux/media-bus-format.h | 3 ++-
> > 2 files changed, 32 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
> > index 8d1f624..c02af7a 100644
> > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> > @@ -480,6 +480,36 @@ see .
> > b1
> > b0
> >
> > +
> > + MEDIA_BUS_FMT_RGB666_1X24_CPADHI
>
> Could you add a note on "C" in front of PADHI to the explanation in
> media-bus-format.h?
Thanks, how about this addition:
-----8<-----
From: Philipp Zabel
Subject: [PATCH] fixup! [media] Add RGB666_1X24_CPADHI media bus format
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 0b022a1..a9f62e9 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -91,7 +91,9 @@ see .
For formats where the total number of bits per pixel is smaller
than the number of bus samples per pixel times the bus width, a padding
value stating if the bytes are padded in their most high order bits
- (PADHI) or low order bits (PADLO).
+ (PADHI) or low order bits (PADLO). A "C" prefix is used for component-wise
+ padding in the most high order bits (CPADHI) or low order bits (CPADLO)
+ of each separate component.
For formats where the number of bus samples per pixel is larger
than 1, an endianness value stating if the pixel is transferred MSB first
(BE) or LSB first (LE).
@@ -103,6 +105,10 @@ see .
samples per pixel with the most significant bits (padding, red and half of
the green value) transferred first will be named
MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE.
+ A format where pixels are encoded as 6-bit red, green and blue values,
+ transferred as 1 24-bit sample per pixel where each component is padded to
+ 8-bits with the 2-bit padding in the most significant bits will be named
+ MEDIA_BUS_FMT_RGB666_1X24_CPADHI.
The following tables list existing packed RGB formats.