diff mbox

[v3,2/3] drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test

Message ID 1425894199-489-1-git-send-email-ykk@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yakir Yang March 9, 2015, 9:43 a.m. UTC
As for 1920x1080 display resolution, we should turn on the
Transmitter Trailer-B.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---

Changes in v3: None
Changes in v2:
- Set slopeboost back to 10%-20%, then rasing/falling time would pass.

 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Russell King - ARM Linux March 31, 2015, 4:57 p.m. UTC | #1
On Mon, Mar 09, 2015 at 05:43:19PM +0800, Yakir Yang wrote:
> As for 1920x1080 display resolution, we should turn on the
> Transmitter Trailer-B.
> 
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---

BTW, one of:

 drm/rockchip: dw_hdmi-rockchip: ...
 drm/rockchip: dw_hdmi: ...
 drm: rockchip: dw_hdmi-rockchip: ...
 drm: rockchip: dw_hdmi: ...
 drm: rockchip/dw_hdmi-rockchip: ...
 drm: rockchip/dw_hdmi: ...

might be a better subject line for patches which only touch the rockchip
part of this driver.  I'd also suggest one of:

 drm/imx: dw_hdmi-imx: ...
 drm/imx: dw_hdmi: ...
 drm: imx: dw_hdmi-imx: ...
 drm: imx: dw_hdmi: ...
 drm: imx/dw_hdmi-imx: ...
 drm: imx/dw_hdmi: ...

for iMX-only patches.  It doesn't really mater which as we already have
a mixture of these formats already.
Yakir Yang April 1, 2015, 2:37 a.m. UTC | #2
Hi Russell,

? 2015/4/1 0:57, Russell King - ARM Linux ??:
> On Mon, Mar 09, 2015 at 05:43:19PM +0800, Yakir Yang wrote:
>> As for 1920x1080 display resolution, we should turn on the
>> Transmitter Trailer-B.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
> BTW, one of:
>
>   drm/rockchip: dw_hdmi-rockchip: ...
>   drm/rockchip: dw_hdmi: ...
>   drm: rockchip: dw_hdmi-rockchip: ...
>   drm: rockchip: dw_hdmi: ...
>   drm: rockchip/dw_hdmi-rockchip: ...
>   drm: rockchip/dw_hdmi: ...
>
> might be a better subject line for patches which only touch the rockchip
> part of this driver.  I'd also suggest one of:

Okay, I choose the "drm: rockchip/dw_hdmi-rockchip: ...", improve in v4

Thanks
Yakir Yang

>   drm/imx: dw_hdmi-imx: ...
>   drm/imx: dw_hdmi: ...
>   drm: imx: dw_hdmi-imx: ...
>   drm: imx: dw_hdmi: ...
>   drm: imx/dw_hdmi-imx: ...
>   drm: imx/dw_hdmi: ...
>
> for iMX-only patches.  It doesn't really mater which as we already have
> a mixture of these formats already.
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index e46e1d9..be0371d 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -142,7 +142,7 @@  static const struct dw_hdmi_curr_ctrl rockchip_cur_ctr[] = {
 static const struct dw_hdmi_sym_term rockchip_sym_term[] = {
 	/*pixelclk   symbol   term*/
 	{ 74250000,  0x8009, 0x0004 },
-	{ 148500000, 0x8029, 0x0004 },
+	{ 148500000, 0x802b, 0x0004 },
 	{ 297000000, 0x8039, 0x0005 },
 	{ ~0UL,	     0x0000, 0x0000 }
 };