| Message ID | 1426782956-31214-2-git-send-email-damien.lespiau@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19/03/15 16:35, Damien Lespiau wrote: > It seems that the tests don't need DRM master anymore? at least make > distcheck passes when X is running. > > release.sh is also invoked with just the path to the libdrm git checkout > and we don't want to pass additional arguments that will be treated as > additional modules we want to release. > > Also, make a note that release.sh will run make distcheck for you, so we > don't strickly need to run it beforehand. > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > --- > RELEASING | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/RELEASING b/RELEASING > index 3f07146..e17dbea 100644 > --- a/RELEASING > +++ b/RELEASING > @@ -20,13 +20,12 @@ Follow these steps to release a new version of libdrm: > 4) Run autoconf and then re-run ./configure so the build system > picks up the new version number. > > - 5) Verify that the code passes "make distcheck". libdrm is tricky > - to distcheck since the test suite will need to become drm master. > - This means that you need to run it outside X, that is, in text > - mode (KMS or no KMS doesn't matter). > + 5) (optional step, release.sh will make distcheck for you, but it can be > + heart warming to verify that make distcheck passes) > > - Running "make distcheck" should result in no warnings or errors > - and end with a message of the form: > + Verify that the code passes "make distcheck". Running "make > + distcheck" should result in no warnings or errors and end with a > + message of the form: > Side note: Pretty sure that current make distcheck produces a handful of warnings ;-) Although we'll try to have them sorted by next release. With my comment in patch 2 and Ilia's in 3 the series is Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Thanks for the update. Emil
On Thu, Mar 19, 2015 at 05:39:06PM +0000, Emil Velikov wrote: > On 19/03/15 16:35, Damien Lespiau wrote: > > - Running "make distcheck" should result in no warnings or errors > > - and end with a message of the form: > > + Verify that the code passes "make distcheck". Running "make > > + distcheck" should result in no warnings or errors and end with a > > + message of the form: > > > Side note: Pretty sure that current make distcheck produces a handful of > warnings ;-) Yup, it does, that'll have to be for another time though. > Although we'll try to have them sorted by next release. That'd be excellent. > With my comment in patch 2 and Ilia's in 3 the series is > Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Done and pushed, thanks for the review!
diff --git a/RELEASING b/RELEASING index 3f07146..e17dbea 100644 --- a/RELEASING +++ b/RELEASING @@ -20,13 +20,12 @@ Follow these steps to release a new version of libdrm: 4) Run autoconf and then re-run ./configure so the build system picks up the new version number. - 5) Verify that the code passes "make distcheck". libdrm is tricky - to distcheck since the test suite will need to become drm master. - This means that you need to run it outside X, that is, in text - mode (KMS or no KMS doesn't matter). + 5) (optional step, release.sh will make distcheck for you, but it can be + heart warming to verify that make distcheck passes) - Running "make distcheck" should result in no warnings or errors - and end with a message of the form: + Verify that the code passes "make distcheck". Running "make + distcheck" should result in no warnings or errors and end with a + message of the form: ============================================= libdrm-X.Y.Z archives ready for distribution: @@ -52,11 +51,11 @@ Follow these steps to release a new version of libdrm: 6) Use the release.sh script from the xorg/util/modular repo to upload the tarballs to the freedesktop.org download area and - create an annouce email template. The script takes three - arguments: a "section", the previous tag and the new tag we just - created. For 2.4.16 again, the command is: + create an annouce email template. The script takes one argument: + the path to the libdrm checkout. So, if a checkout of modular is + at the same level than the libdrm repo: - ../modular/release.sh libdrm 2.4.15 2.4.16 + ./modular/release.sh libdrm This copies the two tarballs to freedesktop.org and creates libdrm-2.4.16.announce which has a detailed summary of the
It seems that the tests don't need DRM master anymore? at least make distcheck passes when X is running. release.sh is also invoked with just the path to the libdrm git checkout and we don't want to pass additional arguments that will be treated as additional modules we want to release. Also, make a note that release.sh will run make distcheck for you, so we don't strickly need to run it beforehand. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- RELEASING | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)