| Message ID | 1431183133-14532-2-git-send-email-daniels@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, May 09, 2015 at 03:52:10PM +0100, Daniel Stone wrote: > 672cb1d6ae mistakenly added an extra parameter to the kerneldoc for > drm_property_unreference_blob which wasn't actually present. > > Signed-off-by: Daniel Stone <daniels@collabora.com> > --- > drivers/gpu/drm/drm_crtc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 4f922aa..6f3cafb 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -4267,7 +4267,6 @@ static void drm_property_free_blob(struct kref *kref) > * > * Drop a reference on a blob property. May free the object. > * > - * @param dev Device the blob was created on Same issue with drm_property_unreference_blob_locked. Also this isn't kerneldoc syntax, the proper one is * @blob: Pointer to blob property $ make htmldocs complains about a bunch of your recently added kerneldoc still. I've squashed this one in, but can you pls follow up with more fixups (and respin the later patches in this series too)? Thanks, Daniel > * @param blob Pointer to blob property > */ > void drm_property_unreference_blob(struct drm_property_blob *blob) > -- > 2.4.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi, On Monday, May 11, 2015, Daniel Vetter <daniel@ffwll.ch> wrote: > On Sat, May 09, 2015 at 03:52:10PM +0100, Daniel Stone wrote: > > 672cb1d6ae mistakenly added an extra parameter to the kerneldoc for > > drm_property_unreference_blob which wasn't actually present. > > > > Signed-off-by: Daniel Stone <daniels@collabora.com <javascript:;>> > > --- > > drivers/gpu/drm/drm_crtc.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index 4f922aa..6f3cafb 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -4267,7 +4267,6 @@ static void drm_property_free_blob(struct kref > *kref) > > * > > * Drop a reference on a blob property. May free the object. > > * > > - * @param dev Device the blob was created on > > Same issue with drm_property_unreference_blob_locked. Also this isn't > kerneldoc syntax, the proper one is > > * @blob: Pointer to blob property > > $ make htmldocs complains about a bunch of your recently added kerneldoc > still. I've squashed this one in, but can you pls follow up with more > fixups (and respin the later patches in this series too)? > Augh, had left my editor in Doxygen mode, and hadn't noticed thanks to the 802.11 doc breakage masking everything else. New branch is up at git://git.collabora.co.uk/git/user/daniels/linux wip/4.1.x/drm-blob-props - will send it out to the list when I get in tomorrow morning. Got sidetracked fixing up more unify-flip-modeset issues instead :\ Cheers, Daniel
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 4f922aa..6f3cafb 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4267,7 +4267,6 @@ static void drm_property_free_blob(struct kref *kref) * * Drop a reference on a blob property. May free the object. * - * @param dev Device the blob was created on * @param blob Pointer to blob property */ void drm_property_unreference_blob(struct drm_property_blob *blob)
672cb1d6ae mistakenly added an extra parameter to the kerneldoc for drm_property_unreference_blob which wasn't actually present. Signed-off-by: Daniel Stone <daniels@collabora.com> --- drivers/gpu/drm/drm_crtc.c | 1 - 1 file changed, 1 deletion(-)